[Bug fortran/63733] New: [OOP] wrong resolution for OPERATOR generics

[Bug fortran/63733] New: [OOP] wrong resolution for OPERATOR generics

[sfilippone at uniroma2 dot it]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63733

            Bug ID: 63733
           Summary: [OOP]  wrong resolution for OPERATOR generics
           Product: gcc
           Version: 5.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: fortran
          Assignee: unassigned at gcc dot gnu.org
          Reporter: sfilippone at uniroma2 dot it

Created attachment 33881
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=33881&action=edit
test case

Hi,
The attached test case, slightly modified from an original by Alberto F.
Martin-Huertas in https://gcc.gnu.org/ml/fortran/2014-10/msg00124.html, changes
behaviour across versions; in particular, 4.7.3 seems correct and all other
versions I tried are not. 
According to Steve Lionel https://software.intel.com/en-us/forums/topic/534799 
the current Intel and gfortran behaviour is wrong, and this is also my
impression. 
We have not had a definite answer at 
https://groups.google.com/forum/#!topic/comp.lang.fortran/aFNK3FXqTUA

Again, my reading of the standard is that 4.7.3 is correct and the others are
wrong, but of course I will gladly accept a correction; either way, at least
one version of gfortran is wrong. 
------------------------------------------------------------------
[sfilippo@jacobi F2003]$ module switch gnu gnu/4.6.4
        gnu/4.6.4 - loads the GNU 4.6.4 compilers suite

        Version 4.6.4

[sfilippo@jacobi F2003]$ gfortran -o test_ov test_ov.f90
[sfilippo@jacobi F2003]$ ./test_ov 
 sum_parent
 sum_parent
 sum_child
[sfilippo@jacobi F2003]$ module switch gnu gnu/4.7.3
        gnu/4.7.3 - loads the GNU 4.7.3 compilers suite

        Version 4.7.3

[sfilippo@jacobi F2003]$ gfortran -o test_ov test_ov.f90
[sfilippo@jacobi F2003]$ ./test_ov 
 sum_parent
 sum_child
 sum_child
[sfilippo@jacobi F2003]$ module switch gnu gnu/4.8.3
        gnu/4.8.3 - loads the GNU 4.8.3 compilers suite

        Version 4.8.3

[sfilippo@jacobi F2003]$ gfortran -o test_ov test_ov.f90
[sfilippo@jacobi F2003]$ ./test_ov 
 sum_parent
 sum_parent
 sum_child
[sfilippo@jacobi F2003]$ module switch gnu gnu/4.9.1
        gnu/4.9.1 - loads the GNU 4.9.1 compilers suite

        Version 4.9.1

[sfilippo@jacobi F2003]$ gfortran -o test_ov test_ov.f90
[sfilippo@jacobi F2003]$ ./test_ov 
 sum_parent
 sum_parent
 sum_child
[sfilippo@jacobi F2003]$ module switch gnu gnu/5.0.0 
        gnu/5.0.0 - loads the GNU 5.0.0-pre compilers suite

        Version 5.0.0

[sfilippo@jacobi F2003]$ gfortran -o test_ov test_ov.f90
[sfilippo@jacobi F2003]$ ./test_ov 
 sum_parent
 sum_parent
 sum_child
[sfilippo@jacobi F2003]$

[Bug fortran/63733] [4.8/4.9/5 Regression] [OOP] wrong resolution for OPERATOR generics

[dominiq at lps dot ens.fr]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63733

Dominique d'Humieres <dominiq at lps dot ens.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2014-11-16
      Known to work|                            |4.7.4
            Summary|[OOP]  wrong resolution for |[4.8/4.9/5 Regression]
                   |OPERATOR generics           |[OOP]  wrong resolution for
                   |                            |OPERATOR generics
     Ever confirmed|0                           |1
      Known to fail|                            |4.8.3, 4.9.2, 5.0

--- Comment #1 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
Assuming that the gurus' all agree that answer should be

 sum_parent
 sum_child
 sum_child

I confirm this PR as a regression. The related history is pretty chaotic:

[macbook] f90/bug% /opt/gcc/gcc4.8p-187200/bin/gfortran pr63733.f90
[macbook] f90/bug% a.out
 sum_parent
 sum_parent
 sum_child
[macbook] f90/bug% /opt/gcc/gcc4.8p-187291/bin/gfortran pr63733.f90
[macbook] f90/bug% a.out
 sum_parent
 sum_child
 sum_child

likely r187226 (pr53255), back ported to 4.7 as r187232.

[macbook] f90/bug% /opt/gcc/gcc4.8p-188694/bin/gfortran pr63733.f90
[macbook] f90/bug% a.out
 sum_parent
 sum_child
 sum_child
[macbook] f90/bug% /opt/gcc/gcc4.8p-189336/bin/gfortran pr63733.f90
pr63733.f90:7.32:

     generic   :: operator(+) => sum
                                1
Error: Entity 'sum_parent' at (1) is already present in the interface
pr63733.f90:35.6:

  use overwrite
      1
Fatal Error: Can't open module file 'overwrite.mod' for reading at (1): No such
file or directory

likely r189022 (pr49591).

[macbook] f90/bug% /opt/gcc/gcc4.8a-195701/bin/gfortran pr63733.f90
pr63733.f90:7.32:

     generic   :: operator(+) => sum
                                1
Error: Entity 'sum_parent' at (1) is already present in the interface
pr63733.f90:35.6:

  use overwrite
      1
Fatal Error: Can't open module file 'overwrite.mod' for reading at (1): No such
file or directory
[macbook] f90/bug% /opt/gcc/gcc4.8p-195731/bin/gfortran pr63733.f90
[macbook] f90/bug% a.out
 sum_parent
 sum_parent
 sum_child

likely r195729 (pr54195).

[Bug fortran/63733] [4.8/4.9/5 Regression] [OOP] wrong resolution for OPERATOR generics

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63733

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |4.8.4

[Bug fortran/63733] [4.8/4.9/5 Regression] [OOP] wrong resolution for OPERATOR generics

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63733

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P4
                 CC|                            |jakub at gcc dot gnu.org

[Bug fortran/63733] [4.8/4.9/5 Regression] [OOP] wrong resolution for OPERATOR generics

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63733

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.8.4                       |4.8.5

--- Comment #2 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
GCC 4.8.4 has been released.

[Bug fortran/63733] [4.8/4.9/5 Regression] [OOP] wrong resolution for OPERATOR generics

[janus at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63733

janus at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |janus at gcc dot gnu.org

--- Comment #3 from janus at gcc dot gnu.org ---
(In reply to Dominique d'Humieres from comment #1)
> likely r187226 (pr53255), back ported to 4.7 as r187232.

I just tried reverting that one (r187226 on trunk), but it does not change the
behavior of the test case in comment 0.

[Bug fortran/63733] [4.8/4.9/5 Regression] [OOP] wrong resolution for OPERATOR generics

[janus at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63733

--- Comment #4 from janus at gcc dot gnu.org ---
(In reply to Dominique d'Humieres from comment #1)
> likely r195729 (pr54195).

Reverting this commit on trunk yields:

test_ov.f90:7:32:

      generic   :: operator(+) => sum
                                1
Error: Entity »sum_parent« at (1) is already present in the interface


So it's not the cause of this regression either.
>From gcc-bugs-return-472468-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Thu Jan 08 13:37:54 2015
Return-Path: <gcc-bugs-return-472468-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 8337 invoked by alias); 8 Jan 2015 13:37:53 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 8302 invoked by uid 48); 8 Jan 2015 13:37:48 -0000
From: "janus at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug fortran/63733] [4.8/4.9/5 Regression] [OOP]  wrong resolution for OPERATOR generics
Date: Thu, 08 Jan 2015 13:37:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: fortran
X-Bugzilla-Version: 5.0
X-Bugzilla-Keywords: wrong-code
X-Bugzilla-Severity: normal
X-Bugzilla-Who: janus at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Priority: P4
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 4.8.5
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-63733-4-vEaQhj09cF@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-63733-4@http.gcc.gnu.org/bugzilla/>
References: <bug-63733-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2015-01/txt/msg00462.txt.bz2
Content-length: 1207

https://gcc.gnu.org/bugzilla/show_bug.cgi?idc733

--- Comment #5 from janus at gcc dot gnu.org ---
(In reply to Dominique d'Humieres from comment #1)
> likely r189022 (pr49591).

I think this one is the culprit. Reverting the relevant part restores the
expected behavior. Patch:


Index: gcc/fortran/resolve.c
==================================================================--- gcc/fortran/resolve.c    (Revision 219342)
+++ gcc/fortran/resolve.c    (Arbeitskopie)
@@ -11894,21 +11894,6 @@ resolve_typebound_intrinsic_op (gfc_symbol* derive

       if (!gfc_check_operator_interface (target_proc, op, p->where))
     goto error;
-
-      /* Add target to non-typebound operator list.  */
-      if (!target->specific->deferred && !derived->attr.use_assoc
-      && p->access != ACCESS_PRIVATE && derived->ns == gfc_current_ns)
-    {
-      gfc_interface *head, *intr;
-      if (!gfc_check_new_interface (derived->ns->op[op], target_proc,
p->where))
-        return false;
-      head = derived->ns->op[op];
-      intr = gfc_get_interface ();
-      intr->sym = target_proc;
-      intr->where = p->where;
-      intr->next = head;
-      derived->ns->op[op] = intr;
-    }
     }

   return true;

[Bug fortran/63733] [4.8/4.9/5 Regression] [OOP] wrong resolution for OPERATOR generics

[janus at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63733

janus at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|unassigned at gcc dot gnu.org      |janus at gcc dot gnu.org

--- Comment #6 from janus at gcc dot gnu.org ---
(In reply to janus from comment #5)
> (In reply to Dominique d'Humieres from comment #1)
> > likely r189022 (pr49591).
> 
> I think this one is the culprit. Reverting the relevant part restores the
> expected behavior. Patch:

As expected, this fails on typebound_operator_16.f03, but nothing else.

[Bug fortran/63733] [4.8/4.9/5 Regression] [OOP] wrong resolution for OPERATOR generics

[janus at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63733

--- Comment #7 from janus at gcc dot gnu.org ---
I think the proper fix should be to look for type-bound operators *before*
non-type-bound operators in gfc_extend_expr (interface.c). In gfc_extend_assign
this is already done in the right order (i.e. type-bound first).

[Bug fortran/63733] [4.8/4.9/5 Regression] [OOP] wrong resolution for OPERATOR generics

[janus at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63733

--- Comment #8 from janus at gcc dot gnu.org ---
Author: janus
Date: Sun Jan 11 22:00:06 2015
New Revision: 219440

URL: https://gcc.gnu.org/viewcvs?rev=219440&root=gcc&view=rev
Log:
2015-01-11  Janus Weil  <janus@gcc.gnu.org>

    PR fortran/63733
    * interface.c (gfc_extend_expr): Look for type-bound operators before
    non-typebound ones.

2015-01-11  Janus Weil  <janus@gcc.gnu.org>

    PR fortran/63733
    * gfortran.dg/typebound_operator_20.f90: New.

Added:
    trunk/gcc/testsuite/gfortran.dg/typebound_operator_20.f90
Modified:
    trunk/gcc/fortran/ChangeLog
    trunk/gcc/fortran/interface.c
    trunk/gcc/testsuite/ChangeLog

[Bug fortran/63733] [4.8/4.9/5 Regression] [OOP] wrong resolution for OPERATOR generics

[janus at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63733

--- Comment #9 from janus at gcc dot gnu.org ---
Author: janus
Date: Mon Jan 12 16:14:06 2015
New Revision: 219475

URL: https://gcc.gnu.org/viewcvs?rev=219475&root=gcc&view=rev
Log:
2015-01-12  Janus Weil  <janus@gcc.gnu.org>

    Backport from mainline
    PR fortran/63733
    * interface.c (gfc_extend_expr): Look for type-bound operators before
    non-typebound ones.

2015-01-12  Janus Weil  <janus@gcc.gnu.org>

    Backport from mainline
    PR fortran/63733
    * gfortran.dg/typebound_operator_20.f90: New.

Added:
    branches/gcc-4_9-branch/gcc/testsuite/gfortran.dg/typebound_operator_20.f90
Modified:
    branches/gcc-4_9-branch/gcc/fortran/ChangeLog
    branches/gcc-4_9-branch/gcc/fortran/interface.c
    branches/gcc-4_9-branch/gcc/testsuite/ChangeLog

[Bug fortran/63733] [4.8/4.9/5 Regression] [OOP] wrong resolution for OPERATOR generics

[janus at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63733

--- Comment #10 from janus at gcc dot gnu.org ---
Author: janus
Date: Mon Jan 12 19:40:57 2015
New Revision: 219486

URL: https://gcc.gnu.org/viewcvs?rev=219486&root=gcc&view=rev
Log:
2015-01-12  Janus Weil  <janus@gcc.gnu.org>

    Backport from mainline
    PR fortran/63733
    * interface.c (gfc_extend_expr): Look for type-bound operators before
    non-typebound ones.

2015-01-12  Janus Weil  <janus@gcc.gnu.org>

    Backport from mainline
    PR fortran/63733
    * gfortran.dg/typebound_operator_20.f90: New.

Added:
    branches/gcc-4_8-branch/gcc/testsuite/gfortran.dg/typebound_operator_20.f90
Modified:
    branches/gcc-4_8-branch/gcc/fortran/ChangeLog
    branches/gcc-4_8-branch/gcc/fortran/interface.c
    branches/gcc-4_8-branch/gcc/testsuite/ChangeLog

[Bug fortran/63733] [4.8/4.9/5 Regression] [OOP] wrong resolution for OPERATOR generics

[janus at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63733

janus at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #11 from janus at gcc dot gnu.org ---
Fixed on trunk as well as the 4.9 and 4.8 branches. Closing.