[Bug c/64212] New: ICE [in noninterposable_alias, at symtab.c:1706]

[Bug c/64212] New: ICE [in noninterposable_alias, at symtab.c:1706]

[chris at thdsys dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64212

            Bug ID: 64212
           Summary: ICE [in noninterposable_alias, at symtab.c:1706]
           Product: gcc
           Version: 5.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c
          Assignee: unassigned at gcc dot gnu.org
          Reporter: chris at thdsys dot com

Created attachment 34212
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=34212&action=edit
Preprocessed source (compressed to meet file size limit)

Built on OSX 10.10.1, 64 bit

Using built-in specs.
COLLECT_GCC=x86_64-w64-mingw32-gcc
COLLECT_LTO_WRAPPER=/opt/mingw-w64/libexec/gcc/x86_64-w64-mingw32/5.0.0/lto-wrapper
Target: x86_64-w64-mingw32
Configured with: ../configure --target=x86_64-w64-mingw32
--enable-targets=x86_64-w64-mingw32 --with-sysroot=/opt/mingw-w64
--prefix=/opt/mingw-w64 --with-mpfr=/opt/local --with-gmp=/opt/local
--with-mpc=/opt/local --disable-multilib --enable-languages=c,c++,objc,obj-c++
Thread model: win32
gcc version 5.0.0 20141207 (experimental) (GCC) 

The issue existed on 4.9.2 for me as well, so I tried a build out of the GIT
tree head.  The issue still seems to be there.

The build goes as such:

x86_64-w64-mingw32-gcc -v -save-temps -ansi -Wall -I. -DBSD_SOCKETS
-DHAVE_GETTIMEOFDAY -DHAVE_PWD_H -DHAVE_UNISTD_H -DHAVE_UID_T -D_BSD_SOURCE
-D_GNU_SOURCE -D_SVID_SOURCE -g -fpic -DGSS_MECH1_INIT=krb5_initialize    -c
../dbg_fn.c
Using built-in specs.
COLLECT_GCC=x86_64-w64-mingw32-gcc
Target: x86_64-w64-mingw32
Configured with: ../configure --target=x86_64-w64-mingw32
--enable-targets=x86_64-w64-mingw32 --with-sysroot=/opt/mingw-w64
--prefix=/opt/mingw-w64 --with-mpfr=/opt/local --with-gmp=/opt/local
--with-mpc=/opt/local --disable-multilib --enable-languages=c,c++,objc,obj-c++
Thread model: win32
gcc version 5.0.0 20141207 (experimental) (GCC) 

COLLECT_GCC_OPTIONS='-v' '-save-temps' '-ansi' '-Wall' '-I' '.' '-D'
'BSD_SOCKETS' '-D' 'HAVE_GETTIMEOFDAY' '-D' 'HAVE_PWD_H' '-D' 'HAVE_UNISTD_H'
'-D' 'HAVE_UID_T' '-D' '_BSD_SOURCE' '-D' '_GNU_SOURCE' '-D' '_SVID_SOURCE'
'-g' '-fpic' '-D' 'GSS_MECH1_INIT=krb5_initialize' '-c' '-mtune=generic'
'-march=x86-64'
 /opt/mingw-w64/libexec/gcc/x86_64-w64-mingw32/5.0.0/cc1 -E -quiet -v -I .
-U_REENTRANT -D BSD_SOCKETS -D HAVE_GETTIMEOFDAY -D HAVE_PWD_H -D HAVE_UNISTD_H
-D HAVE_UID_T -D _BSD_SOURCE -D _GNU_SOURCE -D _SVID_SOURCE -D
GSS_MECH1_INIT=krb5_initialize ../dbg_fn.c -mtune=generic -march=x86-64 -ansi
-Wall -fpic -g -fworking-directory -fpch-preprocess -o dbg_fn.i
ignoring nonexistent directory "/opt/mingw-w64/usr/local/include"
ignoring duplicate directory "/opt/mingw-w64/mingw/include"
#include "..." search starts here:
#include <...> search starts here:
 .
 /opt/mingw-w64/lib/gcc/x86_64-w64-mingw32/5.0.0/include
 /opt/mingw-w64/lib/gcc/x86_64-w64-mingw32/5.0.0/include-fixed

/opt/mingw-w64/lib/gcc/x86_64-w64-mingw32/5.0.0/../../../../x86_64-w64-mingw32/include
End of search list.
COLLECT_GCC_OPTIONS='-v' '-save-temps' '-ansi' '-Wall' '-I' '.' '-D'
'BSD_SOCKETS' '-D' 'HAVE_GETTIMEOFDAY' '-D' 'HAVE_PWD_H' '-D' 'HAVE_UNISTD_H'
'-D' 'HAVE_UID_T' '-D' '_BSD_SOURCE' '-D' '_GNU_SOURCE' '-D' '_SVID_SOURCE'
'-g' '-fpic' '-D' 'GSS_MECH1_INIT=krb5_initialize' '-c' '-mtune=generic'
'-march=x86-64'
 /opt/mingw-w64/libexec/gcc/x86_64-w64-mingw32/5.0.0/cc1 -fpreprocessed
dbg_fn.i -quiet -dumpbase dbg_fn.c -mtune=generic -march=x86-64 -auxbase dbg_fn
-g -Wall -ansi -version -fpic -o dbg_fn.s
GNU C89 (GCC) version 5.0.0 20141207 (experimental) (x86_64-w64-mingw32)
    compiled by GNU C version 4.2.1 Compatible Apple LLVM 6.0 (clang-600.0.56),
GMP version 6.0.0, MPFR version 3.1.1-p2, MPC version 1.0.1
GGC heuristics: --param ggc-min-expand=30 --param ggc-min-heapsize=4096
GNU C89 (GCC) version 5.0.0 20141207 (experimental) (x86_64-w64-mingw32)
    compiled by GNU C version 4.2.1 Compatible Apple LLVM 6.0 (clang-600.0.56),
GMP version 6.0.0, MPFR version 3.1.1-p2, MPC version 1.0.1
GGC heuristics: --param ggc-min-expand=30 --param ggc-min-heapsize=4096
Compiler executable checksum: 98d600b2609a3251401848306e36b8d7
../dbg_fn.c: In function ‘dbg_ret’:
../dbg_fn.c:853:15: warning: format ‘%s’ expects argument of type ‘char *’, but
argument 4 has type ‘void *’ [-Wformat=]
   fprintf(tf, "minor_status:= %.*s ", (int)msg_buf.length, msg_buf.value );
               ^
../dbg_fn.c:840:14: warning: variable ‘maj_stat’ set but not used
[-Wunused-but-set-variable]
    OM_uint32         maj_stat, min_stat;
              ^
../dbg_fn.c: In function ‘dbg_lifetime’:
../dbg_fn.c:943:11: warning: unused variable ‘comment’ [-Wunused-variable]
    char     * comment   = "";
           ^
../dbg_fn.c:942:11: warning: unused variable ‘this_Call’ [-Wunused-variable]
    char     * this_Call = "dbg_lifetime";
           ^
../dbg_fn.c: In function ‘dbg_usage’:
../dbg_fn.c:1015:20: warning: format ‘%lu’ expects argument of type ‘long
unsigned int’, but argument 4 has type ‘OM_uint32 {aka unsigned int}’
[-Wformat=]
    DEBUG_VAL((tf, MYPARAM "= %lu            (%s)\n",
                    ^
../dbg_fn.c:988:11: warning: unused variable ‘this_Call’ [-Wunused-variable]
    char     * this_Call = "dbg_usage";
           ^
../dbg_fn.c: In function ‘dbg_flags’:
../dbg_fn.c:1044:11: warning: unused variable ‘this_Call’ [-Wunused-variable]
    char       * this_Call = "dbg_flags";
           ^
../dbg_fn.c: At top level:
../dbg_fn.c:1168:1: internal compiler error: in noninterposable_alias, at
symtab.c:1706
 } /* dbg_print_ptr() */
 ^

Please find the preprocessed intermediate files attached
>From gcc-bugs-return-469669-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Sun Dec 07 17:49:37 2014
Return-Path: <gcc-bugs-return-469669-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 21034 invoked by alias); 7 Dec 2014 17:49:36 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 21003 invoked by uid 55); 7 Dec 2014 17:49:31 -0000
From: "danglin at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug testsuite/64038] [5 Regression] FAIL: gcc.dg/ipa/ipa-icf-5.c (test for excess errors)
Date: Sun, 07 Dec 2014 17:49:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: testsuite
X-Bugzilla-Version: 5.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: danglin at gcc dot gnu.org
X-Bugzilla-Status: WAITING
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 5.0
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-64038-4-z3GzlN1mKy@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-64038-4@http.gcc.gnu.org/bugzilla/>
References: <bug-64038-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-12/txt/msg00676.txt.bz2
Content-length: 540

https://gcc.gnu.org/bugzilla/show_bug.cgi?idd038

--- Comment #2 from John David Anglin <danglin at gcc dot gnu.org> ---
Author: danglin
Date: Sun Dec  7 17:48:56 2014
New Revision: 218467

URL: https://gcc.gnu.org/viewcvs?rev!8467&root=gcc&view=rev
Log:
    PR testsuite/64038
    * gcc.dg/ipa/ipa-icf-5.c: Require c99_runtime.  Add c99_runtime options.
    * gcc.dg/ipa/ipa-icf-7.c: Likewise.


Modified:
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/testsuite/gcc.dg/ipa/ipa-icf-5.c
    trunk/gcc/testsuite/gcc.dg/ipa/ipa-icf-7.c

[Bug target/64212] ICE [in noninterposable_alias, at symtab.c:1706]

[mpolacek at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64212

Marek Polacek <mpolacek at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Target|                            |x86_64-w64-mingw32
                 CC|                            |mpolacek at gcc dot gnu.org
          Component|c                           |target

--- Comment #1 from Marek Polacek <mpolacek at gcc dot gnu.org> ---
Can't reproduce on x86_64-linux.

[Bug target/64212] [5 Regression] ICE [in noninterposable_alias, at symtab.c:1706]

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64212

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hubicka at gcc dot gnu.org
   Target Milestone|---                         |5.0
            Summary|ICE [in                     |[5 Regression] ICE [in
                   |noninterposable_alias, at   |noninterposable_alias, at
                   |symtab.c:1706]              |symtab.c:1706]

[Bug target/64212] [4.9/5 Regression] ICE [in noninterposable_alias, at symtab.c:1706]

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64212

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2015-01-28
                 CC|                            |jakub at gcc dot gnu.org,
                   |                            |ktietz at gcc dot gnu.org
            Summary|[5 Regression] ICE [in      |[4.9/5 Regression] ICE [in
                   |noninterposable_alias, at   |noninterposable_alias, at
                   |symtab.c:1706]              |symtab.c:1706]
     Ever confirmed|0                           |1

--- Comment #2 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Reduced testcase:

inline void
foo (void)
{
}

__attribute__ ((__dllimport__))
void foo (void);

void
bar (void)
{
  foo ();
}

No options are needed, reproduced with x86_64-linux -> x86_64-mingw32 cross.
ICEs the same even with an extra extern void foo (void); prototype above the
inline, and no matter whether -std=gnu89 or -std=c11 is used.
Kai, is this even meant to be valid (i.e. shouldn't we reject this - adding
dllimport attribute after inline fn definition)?  And, is it really a
regression?  Don't have time to build cross-compilers for older gcc versions,
perhaps you have some older ones around?

[Bug target/64212] [4.9/5 Regression] ICE [in noninterposable_alias, at symtab.c:1706]

[ktietz at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64212

--- Comment #3 from Kai Tietz <ktietz at gcc dot gnu.org> ---
(In reply to Jakub Jelinek from comment #2)
> Reduced testcase:
> 
> inline void
> foo (void)
> {
> }
> 
> __attribute__ ((__dllimport__))
> void foo (void);
> 
> void
> bar (void)
> {
>   foo ();
> }
> 
> No options are needed, reproduced with x86_64-linux -> x86_64-mingw32 cross.
> ICEs the same even with an extra extern void foo (void); prototype above the
> inline, and no matter whether -std=gnu89 or -std=c11 is used.
> Kai, is this even meant to be valid (i.e. shouldn't we reject this - adding
> dllimport attribute after inline fn definition)?  And, is it really a
> regression?  Don't have time to build cross-compilers for older gcc
> versions, perhaps you have some older ones around?

I think this scenario is valid.  Of course it is better style for having first
the prototype and then its inline-function.

So by changing sample this way:

__attribute__ ((__dllimport__))
void foo (void);

inline void
foo (void)
{
}

void
bar (void)
{
  foo ();
}

There is no ICE.  The point here is that dllimport indicates that function is
external, but by the dllimport-attribute 'function_and_variable_visibility'
pass gets confused. In symtab_node::noninterposable_alias() we assert on
'decl_binds_to_current_def_p' returning true, which is of course the case for
the inline-case.

[Bug target/64212] [4.9/5 Regression] ICE [in noninterposable_alias, at symtab.c:1706]

[ktietz at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64212

--- Comment #4 from Kai Tietz <ktietz at gcc dot gnu.org> ---
A side-note:  Of course the dllimport attribute is part of the prototype.  So
for C case it would be consistent to have the dllimport-attribute also
specified for the inline, which gets rejected.  This reject might be doubtful
as an inline-function isn't necessarily inlined, and so the function gets
called.
A second side-note:  This issue is only happening for C compiler.  For C++
semantics of inline is different, and sample-code works as expected.

[Bug target/64212] [4.9/5 Regression] ICE [in noninterposable_alias, at symtab.c:1706]

[hubicka at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64212

--- Comment #5 from Jan Hubicka <hubicka at gcc dot gnu.org> ---
Well, can someone overwrite dllimport symbol by different definition?
If not, it is a bug of decl_binds_to_current_def_p to return false here.
If it can be inteprposed, I think the function
symtab_node::noninterposable_alias should remove dllimport attribute on the
alias created and so should symtab_node::make_decl_local

Honza

[Bug target/64212] [4.9/5 Regression] ICE [in noninterposable_alias, at symtab.c:1706]

[ktietz at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64212

--- Comment #6 from Kai Tietz <ktietz at gcc dot gnu.org> ---
(In reply to Jan Hubicka from comment #5)
> Well, can someone overwrite dllimport symbol by different definition?
> If not, it is a bug of decl_binds_to_current_def_p to return false here.
> If it can be inteprposed, I think the function
> symtab_node::noninterposable_alias should remove dllimport attribute on the
> alias created and so should symtab_node::make_decl_local

Thanks Honza,

well, dllimport symbol can be interposed ... well their function-stub can.  So
variant two seems to be the right thing to do.
I am about to prepare a patch for this ...

[Bug target/64212] [4.9/5 Regression] ICE [in noninterposable_alias, at symtab.c:1706]

[ktietz at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64212

--- Comment #7 from Kai Tietz <ktietz at gcc dot gnu.org> ---
Tested patch posted at https://gcc.gnu.org/ml/gcc-patches/2015-02/msg01502.html

[Bug target/64212] [4.9/5 Regression] ICE [in noninterposable_alias, at symtab.c:1706]

[ktietz at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64212

--- Comment #8 from Kai Tietz <ktietz at gcc dot gnu.org> ---
Author: ktietz
Date: Wed Feb 25 16:44:26 2015
New Revision: 220982

URL: https://gcc.gnu.org/viewcvs?rev=220982&root=gcc&view=rev
Log:
    PR target/64212
    * symtab.c (symtab::make_decl_local): Set DECL_IMPORT_P explicit to 0.
    (symtab::noninterposable_alias): Likewise.


Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/symtab.c

[Bug target/64212] [4.9/5 Regression] ICE [in noninterposable_alias, at symtab.c:1706]

[ktietz at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64212

--- Comment #9 from Kai Tietz <ktietz at gcc dot gnu.org> ---
Author: ktietz
Date: Wed Feb 25 16:46:34 2015
New Revision: 220983

URL: https://gcc.gnu.org/viewcvs?rev=220983&root=gcc&view=rev
Log:
    Merged from mainline
    PR target/64212
    * symtab.c (symtab::make_decl_local): Set DECL_IMPORT_P explicit to 0.
    (symtab::noninterposable_alias): Likewise.


Modified:
    branches/gcc-4_9-branch/gcc/ChangeLog
    branches/gcc-4_9-branch/gcc/symtab.c

[Bug target/64212] [4.9/5 Regression] ICE [in noninterposable_alias, at symtab.c:1706]

[ktietz at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64212

Kai Tietz <ktietz at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #10 from Kai Tietz <ktietz at gcc dot gnu.org> ---
Fixed.

[Bug target/64212] [4.9/5 Regression] ICE [in noninterposable_alias, at symtab.c:1706]

[ktietz at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64212

Kai Tietz <ktietz at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |timothygu99 at gmail dot com

--- Comment #11 from Kai Tietz <ktietz at gcc dot gnu.org> ---
*** Bug 61916 has been marked as a duplicate of this bug. ***