public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug rtl-optimization/64287] New: Disable -fuse-caller-save when -pg is active
@ 2014-12-12 15:52 vries at gcc dot gnu.org
  2014-12-12 15:55 ` [Bug rtl-optimization/64287] [5 Regression] " vries at gcc dot gnu.org
                   ` (5 more replies)
  0 siblings, 6 replies; 7+ messages in thread
From: vries at gcc dot gnu.org @ 2014-12-12 15:52 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64287

            Bug ID: 64287
           Summary: Disable -fuse-caller-save when -pg is active
           Product: gcc
           Version: 5.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: rtl-optimization
          Assignee: unassigned at gcc dot gnu.org
          Reporter: vries at gcc dot gnu.org

As discussed in https://gcc.gnu.org/ml/gcc-patches/2014-11/msg01496.html :
...
A problem is detected with building Linux kernel on MIPS platform when
both -fuse-caller-save and -pg options are present. The reason for this
is that -fuse-caller-save relies on the analysis of RTL code, but when
profiling is active (with -pg option) the code is instrumented
by adding a call to mcount function at the beginning of each function.
And this is realized on the most platforms simply by fprintf function,
so this instrumentation is not reflected in RTL code. The result is
that bad code is produced. A solution could be to disable -fuse-caller-save
when -pg is active.
...


^ permalink raw reply	[flat|nested] 7+ messages in thread

* [Bug rtl-optimization/64287] [5 Regression] Disable -fuse-caller-save when -pg is active
  2014-12-12 15:52 [Bug rtl-optimization/64287] New: Disable -fuse-caller-save when -pg is active vries at gcc dot gnu.org
@ 2014-12-12 15:55 ` vries at gcc dot gnu.org
  2014-12-12 16:01 ` vries at gcc dot gnu.org
                   ` (4 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: vries at gcc dot gnu.org @ 2014-12-12 15:55 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64287

vries at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P1
            Summary|Disable -fuse-caller-save   |[5 Regression] Disable
                   |when -pg is active          |-fuse-caller-save when -pg
                   |                            |is active


^ permalink raw reply	[flat|nested] 7+ messages in thread

* [Bug rtl-optimization/64287] [5 Regression] Disable -fuse-caller-save when -pg is active
  2014-12-12 15:52 [Bug rtl-optimization/64287] New: Disable -fuse-caller-save when -pg is active vries at gcc dot gnu.org
  2014-12-12 15:55 ` [Bug rtl-optimization/64287] [5 Regression] " vries at gcc dot gnu.org
@ 2014-12-12 16:01 ` vries at gcc dot gnu.org
  2014-12-12 16:10 ` vries at gcc dot gnu.org
                   ` (3 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: vries at gcc dot gnu.org @ 2014-12-12 16:01 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64287

--- Comment #1 from vries at gcc dot gnu.org ---
AFAIK, Radovan (Radovan.Obradovic@imgtec.com) is working on this.


^ permalink raw reply	[flat|nested] 7+ messages in thread

* [Bug rtl-optimization/64287] [5 Regression] Disable -fuse-caller-save when -pg is active
  2014-12-12 15:52 [Bug rtl-optimization/64287] New: Disable -fuse-caller-save when -pg is active vries at gcc dot gnu.org
  2014-12-12 15:55 ` [Bug rtl-optimization/64287] [5 Regression] " vries at gcc dot gnu.org
  2014-12-12 16:01 ` vries at gcc dot gnu.org
@ 2014-12-12 16:10 ` vries at gcc dot gnu.org
  2014-12-15  9:04 ` rguenth at gcc dot gnu.org
                   ` (2 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: vries at gcc dot gnu.org @ 2014-12-12 16:10 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64287

vries at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch
                 CC|                            |law at gcc dot gnu.org

--- Comment #2 from vries at gcc dot gnu.org ---
STATUS

patch: https://gcc.gnu.org/ml/gcc-patches/2014-11/msg01829.html

approval with question on testing:
https://gcc.gnu.org/ml/gcc-patches/2014-11/msg02162.html


^ permalink raw reply	[flat|nested] 7+ messages in thread

* [Bug rtl-optimization/64287] [5 Regression] Disable -fuse-caller-save when -pg is active
  2014-12-12 15:52 [Bug rtl-optimization/64287] New: Disable -fuse-caller-save when -pg is active vries at gcc dot gnu.org
                   ` (2 preceding siblings ...)
  2014-12-12 16:10 ` vries at gcc dot gnu.org
@ 2014-12-15  9:04 ` rguenth at gcc dot gnu.org
  2015-01-05 23:43 ` clm at gcc dot gnu.org
  2015-01-06  8:32 ` vries at gcc dot gnu.org
  5 siblings, 0 replies; 7+ messages in thread
From: rguenth at gcc dot gnu.org @ 2014-12-15  9:04 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64287

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |5.0


^ permalink raw reply	[flat|nested] 7+ messages in thread

* [Bug rtl-optimization/64287] [5 Regression] Disable -fuse-caller-save when -pg is active
  2014-12-12 15:52 [Bug rtl-optimization/64287] New: Disable -fuse-caller-save when -pg is active vries at gcc dot gnu.org
                   ` (3 preceding siblings ...)
  2014-12-15  9:04 ` rguenth at gcc dot gnu.org
@ 2015-01-05 23:43 ` clm at gcc dot gnu.org
  2015-01-06  8:32 ` vries at gcc dot gnu.org
  5 siblings, 0 replies; 7+ messages in thread
From: clm at gcc dot gnu.org @ 2015-01-05 23:43 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64287

--- Comment #3 from clm at gcc dot gnu.org ---
Author: clm
Date: Mon Jan  5 23:42:27 2015
New Revision: 219208

URL: https://gcc.gnu.org/viewcvs?rev=219208&root=gcc&view=rev
Log:
2015-01-05  Radovan Obradovic  <radovan.obradovic@imgtec.com>

    PR rtl-optimization/64287

    gcc/
    * toplev.c (HAVE_epilogue, HAVE_prologue): Provide default.
    (process_options): Disable flag_ipa_ra if profiling.

    gcc/testsuite/
    * gcc.dg/aru-2.c: New test.


Added:
    trunk/gcc/testsuite/gcc.dg/aru-2.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/toplev.c


^ permalink raw reply	[flat|nested] 7+ messages in thread

* [Bug rtl-optimization/64287] [5 Regression] Disable -fuse-caller-save when -pg is active
  2014-12-12 15:52 [Bug rtl-optimization/64287] New: Disable -fuse-caller-save when -pg is active vries at gcc dot gnu.org
                   ` (4 preceding siblings ...)
  2015-01-05 23:43 ` clm at gcc dot gnu.org
@ 2015-01-06  8:32 ` vries at gcc dot gnu.org
  5 siblings, 0 replies; 7+ messages in thread
From: vries at gcc dot gnu.org @ 2015-01-06  8:32 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64287

vries at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED

--- Comment #4 from vries at gcc dot gnu.org ---
Patch and test-case committed. Marking as resolved, fixed.


^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2015-01-06  8:32 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-12-12 15:52 [Bug rtl-optimization/64287] New: Disable -fuse-caller-save when -pg is active vries at gcc dot gnu.org
2014-12-12 15:55 ` [Bug rtl-optimization/64287] [5 Regression] " vries at gcc dot gnu.org
2014-12-12 16:01 ` vries at gcc dot gnu.org
2014-12-12 16:10 ` vries at gcc dot gnu.org
2014-12-15  9:04 ` rguenth at gcc dot gnu.org
2015-01-05 23:43 ` clm at gcc dot gnu.org
2015-01-06  8:32 ` vries at gcc dot gnu.org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).