[Bug bootstrap/64349] New: [5 Regression] Bootstrapping Ada fails on darwin(9|10).

[Bug bootstrap/64349] New: [5 Regression] Bootstrapping Ada fails on darwin(9|10).

[dominiq at lps dot ens.fr]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64349

            Bug ID: 64349
           Summary: [5 Regression] Bootstrapping Ada fails on
                    darwin(9|10).
           Product: gcc
           Version: 5.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: bootstrap
          Assignee: unassigned at gcc dot gnu.org
          Reporter: dominiq at lps dot ens.fr

[Bug bootstrap/64349] [5 Regression] Bootstrapping Ada fails on darwin(9|10).

[dominiq at lps dot ens.fr]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64349

Dominique d'Humieres <dominiq at lps dot ens.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2014-12-18
                 CC|                            |iains at gcc dot gnu.org
     Ever confirmed|0                           |1

--- Comment #1 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
Bootstrapping Ada fails on darwin(9|10) with

ld: warning: can't add line info to anonymous symbol __const@0 from s-arit64.o

This can be fixed with the following patch from Iain Sandoe

--- ../_clean/gcc/ada/gcc-interface/Makefile.in    2014-11-26
10:44:12.000000000 +0100
+++ gcc/ada/gcc-interface/Makefile.in    2014-11-26 10:55:45.000000000 +0100
@@ -2884,6 +2884,7 @@ gnatlib-shared-darwin:
         -o libgnat$(hyphen)$(LIBRARY_VERSION)$(soext) \
         $(GNATRTL_NONTASKING_OBJS) $(LIBGNAT_OBJS) \
         $(SO_OPTS) \
+        -Wl,-undefined,dynamic_lookup \
         -Wl,-install_name,@rpath/libgnat$(hyphen)$(LIBRARY_VERSION)$(soext) \
         $(MISCLIB)
     cd $(RTSDIR); `echo "$(GCC_FOR_TARGET)" \
@@ -2891,6 +2892,7 @@ gnatlib-shared-darwin:
         -o libgnarl$(hyphen)$(LIBRARY_VERSION)$(soext) \
         $(GNATRTL_TASKING_OBJS) \
         $(SO_OPTS) \
+        -Wl,-undefined,dynamic_lookup \
         -Wl,-install_name,@rpath/libgnarl$(hyphen)$(LIBRARY_VERSION)$(soext) \
         $(THREADSLIB) -Wl,libgnat$(hyphen)$(LIBRARY_VERSION)$(soext)
     cd $(RTSDIR); $(LN_S) libgnat$(hyphen)$(LIBRARY_VERSION)$(soext) \

[Bug bootstrap/64349] [5 Regression] Bootstrapping Ada fails on darwin(9|10).

[iains at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64349

--- Comment #2 from Iain Sandoe <iains at gcc dot gnu.org> ---
Created attachment 34299
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=34299&action=edit
proper fix.

So, the rules on Darwin say that it's OK to access _environ directly from the
main executable, but it is NOT OK to access it from a shared libaray. Instead,
one should use the _NSGetEnviron() API).

===

My initial patch works because it allows the symbol to be satisfied at load
time by dynamic lookup (it will be found from the exe, I assume).

===


The patch attached above uses the correct API - and works AFAICT on
powerpc-darwin9 and x86_64-darwin12.

[Bug bootstrap/64349] [5 Regression] Bootstrapping Ada fails on darwin(9|10).

[dominiq at lps dot ens.fr]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64349

--- Comment #3 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
> The patch attached above uses the correct API - and works AFAICT
> on powerpc-darwin9 and x86_64-darwin12.

It works also on x86_64-apple-darwin10: see results posted at

https://gcc.gnu.org/ml/gcc-testresults/2014-12/msg02400.html.

Thanks for the patch.

[Bug ada/64349] [5 Regression] Bootstrapping Ada fails on darwin(9|10).

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64349

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |build
          Component|bootstrap                   |ada
   Target Milestone|---                         |5.0

[Bug ada/64349] [5 Regression] Bootstrapping Ada fails on darwin(9|10).

[charlet at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64349

--- Comment #4 from Arnaud Charlet <charlet at gcc dot gnu.org> ---
Author: charlet
Date: Wed Jan  7 10:15:18 2015
New Revision: 219290

URL: https://gcc.gnu.org/viewcvs?rev=219290&root=gcc&view=rev
Log:
2015-01-07  Vincent Celier  <celier@adacore.com>

    * clean.adb: Minor error message change.

2015-01-07  Tristan Gingold  <gingold@adacore.com>

    PR ada/64349  
    * env.c (__gnat_environ): Adjust for darwin9/darwin10.

2015-01-07  Javier Miranda  <miranda@adacore.com>

    * sem_ch10.adb (Analyze_With_Clause): Compiling under -gnatq
    protect the frontend against never ending recursion caused by
    circularities in the sources.


Modified:
    trunk/gcc/ada/ChangeLog
    trunk/gcc/ada/clean.adb
    trunk/gcc/ada/env.c
    trunk/gcc/ada/sem_ch10.adb

[Bug ada/64349] [5 Regression] Bootstrapping Ada fails on darwin(9|10).

[charlet at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64349

Arnaud Charlet <charlet at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |charlet at gcc dot gnu.org
         Resolution|---                         |FIXED

--- Comment #5 from Arnaud Charlet <charlet at gcc dot gnu.org> ---
Fixed.

[Bug ada/64349] [5 Regression] Bootstrapping Ada fails on darwin(9|10).

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64349

--- Comment #7 from Richard Biener <rguenth at gcc dot gnu.org> ---
Looks like only a warning?

[Bug ada/64349] [5 Regression] Bootstrapping Ada fails on darwin(9|10).

[dominiq at lps dot ens.fr]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64349

--- Comment #8 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
> Looks like only a warning?

Nope:

...
ld: warning: can't add line info to anonymous symbol __const@0 from s-arit64.o
Undefined symbols:
  "_environ", referenced from:
      ___gnat_environ in env.o
      ___gnat_clearenv in env.o
     (maybe you meant: _system__stack_usage__environment_task_analyzer,
_ada__environment_variables_E , _ada__environment_variables__value ,
_ada__command_line__environment__environment_count ,
_gnat__cgi__cookie__valid_environment , _ada__environment_variables__value__2 ,
_ada__environment_variables__iterate , ___gnat_environment_char ,
_gnat__cgi__cookie__check_environment , _ada__command_line__environment_E ,
_ada__environment_variables__set ,
_ada__command_line__environment__environment_value ,
_ada__environment_variables__clear__2 , _gnat__cgi__valid_environment ,
_ada__environment_variables__exists , _ada__environment_variables__clear ,
_gnat__cgi__check_environment , ___gnat_environ ,
_gnat__directory_operations__environment_styleN ,
_gnat__directory_operations__environment_styleS ,
_system__stack_usage__compute_environment_task )
ld: symbol(s) not found
collect2: error: ld returned 1 exit status

Iain Sandoe has posted a new patch at
https://gcc.gnu.org/ml/gcc-patches/2015-01/msg00437.html.

[Bug ada/64349] [5 Regression] Bootstrapping Ada fails on darwin(9|10).

[iains at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64349

--- Comment #9 from Iain Sandoe <iains at gcc dot gnu.org> ---
although it says "warning" when it encounters the unexpected case, it finally
causes a linkage failure.

Note that this is present on darwin* (it's not really specific to darwin <= 10)
- it's just hidden by the "undefined dynamic lookup" on later darwin.

The library should not be referencing _environ directly (we're all agreed on
that).  I'm sure the Adacore folks will review the new patch in due course.

[Bug ada/64349] [5 Regression] Bootstrapping Ada fails on darwin(9|10).

[demoonlit at panathenaia dot halfmoon.jp]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64349

yuta tomino <demoonlit at panathenaia dot halfmoon.jp> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |demoonlit at panathenaia dot halfm
                   |                            |oon.jp

--- Comment #10 from yuta tomino <demoonlit at panathenaia dot halfmoon.jp> ---
Please move #ifdef in the correct order.

--- a/gcc/ada/env.c
+++ b/gcc/ada/env.c
@@ -44,12 +44,6 @@
 #include <stdlib.h>
 #endif

-#if defined (__APPLE__) && !defined (__arm__)
-/* On Darwin, _NSGetEnviron must be used for shared libraries; but it is not
-   available on iOS.  */
-#include <crt_externs.h>
-#endif
-
 #if defined (__vxworks)
   #if defined (__RTP__)
     /* On VxWorks 6 Real-Time process mode, environ is defined in unistd.h. 
*/
@@ -78,6 +72,12 @@
 #include "system.h"
 #endif /* IN_RTS */

+#if defined (__APPLE__) && !defined (__arm__)
+/* On Darwin, _NSGetEnviron must be used for shared libraries; but it is not
+   available on iOS.  */
+#include <crt_externs.h>
+#endif
+
 #ifdef __cplusplus
 extern "C" {
 #endif
@@ -215,11 +215,11 @@ __gnat_environ (void)
 #elif defined (sun)
   extern char **_environ;
   return _environ;
+#elif defined (__APPLE__) && !defined (__arm__)
+  return *_NSGetEnviron ();
 #elif ! (defined (__vxworks))
   extern char **environ;
   return environ;
-#elif defined (__APPLE__) && !defined (__arm__)
-  return *_NSGetEnviron ();
 #else
   return environ;
 #endif

[Bug ada/64349] [5 Regression] Bootstrapping Ada fails on darwin(9|10).

[dominiq at lps dot ens.fr]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64349

--- Comment #11 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
I have bootstrapped x86_64-apple-darwin10 with the patch. Any plan to commit it
soon?

Thanks,

Dominique

> Le 27 janv. 2015 à 04:00, demoonlit at panathenaia dot halfmoon.jp <gcc-bugzilla@gcc.gnu.org> a écrit :
> 
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64349
> 
> yuta tomino <demoonlit at panathenaia dot halfmoon.jp> changed:
> 
>           What    |Removed                     |Added
> ----------------------------------------------------------------------------
>                 CC|                            |demoonlit at panathenaia dot halfm
>                   |                            |oon.jp
> 
> --- Comment #10 from yuta tomino <demoonlit at panathenaia dot halfmoon.jp> ---
> Please move #ifdef in the correct order.
> 
> --- a/gcc/ada/env.c
> +++ b/gcc/ada/env.c
> @@ -44,12 +44,6 @@
> #include <stdlib.h>
> #endif
> 
> -#if defined (__APPLE__) && !defined (__arm__)
> -/* On Darwin, _NSGetEnviron must be used for shared libraries; but it is not
> -   available on iOS.  */
> -#include <crt_externs.h>
> -#endif
> -
> #if defined (__vxworks)
>   #if defined (__RTP__)
>     /* On VxWorks 6 Real-Time process mode, environ is defined in unistd.h. 
> */
> @@ -78,6 +72,12 @@
> #include "system.h"
> #endif /* IN_RTS */
> 
> +#if defined (__APPLE__) && !defined (__arm__)
> +/* On Darwin, _NSGetEnviron must be used for shared libraries; but it is not
> +   available on iOS.  */
> +#include <crt_externs.h>
> +#endif
> +
> #ifdef __cplusplus
> extern "C" {
> #endif
> @@ -215,11 +215,11 @@ __gnat_environ (void)
> #elif defined (sun)
>   extern char **_environ;
>   return _environ;
> +#elif defined (__APPLE__) && !defined (__arm__)
> +  return *_NSGetEnviron ();
> #elif ! (defined (__vxworks))
>   extern char **environ;
>   return environ;
> -#elif defined (__APPLE__) && !defined (__arm__)
> -  return *_NSGetEnviron ();
> #else
>   return environ;
> #endif
> 
> -- 
> You are receiving this mail because:
> You reported the bug.
>From gcc-bugs-return-475382-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Thu Jan 29 11:03:41 2015
Return-Path: <gcc-bugs-return-475382-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 13960 invoked by alias); 29 Jan 2015 11:03:41 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 13870 invoked by uid 55); 29 Jan 2015 11:03:37 -0000
From: "ienkovich at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug middle-end/64805] Specific use of __attribute ((always_inline)) breaks MPX functionality with -fcheck-pointer-bounds -mmpx
Date: Thu, 29 Jan 2015 11:03:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: middle-end
X-Bugzilla-Version: unknown
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: ienkovich at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-64805-4-dFQwY7SwZc@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-64805-4@http.gcc.gnu.org/bugzilla/>
References: <bug-64805-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2015-01/txt/msg03376.txt.bz2
Content-length: 622

https://gcc.gnu.org/bugzilla/show_bug.cgi?idd805

--- Comment #4 from ienkovich at gcc dot gnu.org ---
Author: ienkovich
Date: Thu Jan 29 11:03:02 2015
New Revision: 220240

URL: https://gcc.gnu.org/viewcvs?rev"0240&root=gcc&view=rev
Log:
gcc/

    PR middle-end/64805
    * ipa-inline.c (early_inliner): Rebuild IPA_REF_CHKP reference
    to avoid error in cgraph node verification.

gcc/testsuite/

    PR middle-end/64805
    * gcc.target/i386/pr64805.c: New.


Added:
    trunk/gcc/testsuite/gcc.target/i386/pr64805.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/ipa-inline.c
    trunk/gcc/testsuite/ChangeLog

[Bug ada/64349] [5 Regression] Bootstrapping Ada fails on darwin(9|10).

[charlet at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64349

--- Comment #12 from Arnaud Charlet <charlet at gcc dot gnu.org> ---
Author: charlet
Date: Fri Jan 30 15:13:15 2015
New Revision: 220285

URL: https://gcc.gnu.org/viewcvs?rev=220285&root=gcc&view=rev
Log:
2015-01-30  Tristan Gingold  <gingold@adacore.com>

    PR ada/64349
    * env.c: Move vxworks and darwin includes out of #ifdef IN_RTS.


Modified:
    trunk/gcc/ada/ChangeLog
    trunk/gcc/ada/env.c

[Bug ada/64349] [5 Regression] Bootstrapping Ada fails on darwin(9|10).

[charlet at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64349

Arnaud Charlet <charlet at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #13 from Arnaud Charlet <charlet at gcc dot gnu.org> ---
Should be fixed, hopefully

[Bug ada/64349] [5 Regression] Bootstrapping Ada fails on darwin(9|10).

[charlet at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64349

--- Comment #15 from Arnaud Charlet <charlet at gcc dot gnu.org> ---
Author: charlet
Date: Thu Feb  5 09:09:51 2015
New Revision: 220437

URL: https://gcc.gnu.org/viewcvs?rev=220437&root=gcc&view=rev
Log:
2015-02-05  Tristan Gingold  <gingold@adacore.com>

    PR ada/64349
    * env.c: Fix thinko: handle Darwin case before default one.


Modified:
    trunk/gcc/ada/ChangeLog
    trunk/gcc/ada/env.c

[Bug ada/64349] [5 Regression] Bootstrapping Ada fails on darwin(9|10).

[charlet at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64349

Arnaud Charlet <charlet at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #16 from Arnaud Charlet <charlet at gcc dot gnu.org> ---
Better now?

[Bug ada/64349] [5 Regression] Bootstrapping Ada fails on darwin(9|10).

[dominiq at lps dot ens.fr]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64349

--- Comment #17 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
> Better now?

Yes, I have bootstrapped a clean revision r220437 on x86_64-apple-darwin10,
regtesting in progress.

For the record, I still see the warning

ld: warning: can't add line info to anonymous symbol __const@0 from s-arit64.o

but no longer

Undefined symbols:
  "_environ", referenced from:
      ___gnat_environ in env.o
      ___gnat_clearenv in env.o
     (maybe you meant: _system__stack_usage__environment_task_analyzer,