[Bug target/64377] New: nios2 compile error in options-save.c

[Bug target/64377] New: nios2 compile error in options-save.c

[joel at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64377

            Bug ID: 64377
           Summary: nios2 compile error in options-save.c
           Product: gcc
           Version: 5.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: target
          Assignee: unassigned at gcc dot gnu.org
          Reporter: joel at gcc dot gnu.org

g++ -c   -g  -DIN_GCC  -DCROSS_DIRECTORY_STRUCTURE  -fno-exceptions -fno-rtti
-fasynchronous-unwind-tables -W -Wall -Wno-narrowing -Wwrite-strings
-Wcast-qual -Wmissing-format-attribute -Woverloaded-virtual -pedantic
-Wno-long-long -Wno-variadic-macros -Wno-overlength-strings -fno-common 
-DHAVE_CONFIG_H -I. -I. -I../../gcc/gcc -I../../gcc/gcc/.
-I../../gcc/gcc/../include -I../../gcc/gcc/../libcpp/include 
-I../../gcc/gcc/../libdecnumber -I../../gcc/gcc/../libdecnumber/dpd
-I../libdecnumber -I../../gcc/gcc/../libbacktrace   -o options-save.o -MT
options-save.o -MMD -MP -MF ./.deps/options-save.TPo options-save.c
options-save.c: In function ‘void cl_target_option_stream_in(data_in*,
bitpack_d*, cl_target_option*)’:
options-save.c:1910:41: error: expected primary-expression before ‘enum’
   ptr->saved_custom_code_status[256] = (enum nios2_ccs_code
saved_custom_code_status[256]) bp_unpack_value (bp, 64);
                                         ^
options-save.c:1910:41: error: expected ‘)’ before ‘enum’
options-save.c:1911:40: error: expected primary-expression before ‘int’
   ptr->saved_custom_code_index[256] = (int saved_custom_code_index[256])
bp_unpack_value (bp, 64);
                                        ^
options-save.c:1911:40: error: expected ‘)’ before ‘int’
options-save.c:1912:49: error: expected primary-expression before ‘int’
   ptr->saved_fpu_custom_code[n2fpu_code_num] = (int
saved_fpu_custom_code[n2fpu_code_num]) bp_unpack_value (bp, 64);
                                                 ^
options-save.c:1912:49: error: expected ‘)’ before ‘int’
make: *** [options-save.o] Error 1
>From gcc-bugs-return-471568-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Mon Dec 22 15:23:45 2014
Return-Path: <gcc-bugs-return-471568-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 13538 invoked by alias); 22 Dec 2014 15:23:45 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 13481 invoked by uid 48); 22 Dec 2014 15:23:41 -0000
From: "olegendo at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug rtl-optimization/63259] Detecting byteswap sequence
Date: Mon, 22 Dec 2014 15:23:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: rtl-optimization
X-Bugzilla-Version: 4.9.1
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: olegendo at gcc dot gnu.org
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: thopre01 at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-63259-4-OEhg2Oysnp@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-63259-4@http.gcc.gnu.org/bugzilla/>
References: <bug-63259-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-12/txt/msg02575.txt.bz2
Content-length: 210

https://gcc.gnu.org/bugzilla/show_bug.cgi?idc259

--- Comment #20 from Oleg Endo <olegendo at gcc dot gnu.org> ---
BTW, PR 42587 contains a few other cases.  I've created PR 64376 for the SH
specific parts.

[Bug target/64377] nios2 compile error in options-save.c

[joel at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64377

--- Comment #1 from Joel Sherrill <joel at gcc dot gnu.org> ---
Looking at the generated options-save.c, the first line of this method is
clearly incorrect in the cast on the RHS. It looks like a full declaration and
not a type. If anyone familiar with the magic in these files looked at it, I am
sure it is easy to fix.

/* Stream in target options  */
void
cl_target_option_stream_in (struct data_in *data_in ATTRIBUTE_UNUSED,
                            struct bitpack_d *bp ATTRIBUTE_UNUSED,
                            struct cl_target_option *ptr ATTRIBUTE_UNUSED)
{
  ptr->saved_custom_code_status[256] = (enum nios2_ccs_code
saved_custom_code_status[256]) bp_unpack_value (bp, 64);
  ptr->saved_custom_code_index[256] = (int saved_custom_code_index[256])
bp_unpack_value (bp, 64);
  ptr->saved_fpu_custom_code[n2fpu_code_num] = (int
saved_fpu_custom_code[n2fpu_code_num]) bp_unpack_value (bp, 64);
  ptr->x_target_flags = (int) bp_unpack_value (bp, 64);
}

[Bug target/64377] nios2 compile error in options-save.c

[sandra at codesourcery dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64377

Sandra Loosemore <sandra at codesourcery dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sandra at codesourcery dot com

--- Comment #4 from Sandra Loosemore <sandra at codesourcery dot com> ---
Consensus from the discussion is that the nios2 backend is *not* broken, this
is a bug in the option streaming code.  Jan Hubicka offered to fix it but I
haven't seen a patch go by yet.

[Bug target/64377] nios2 compile error in options-save.c

[sandra at codesourcery dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64377

--- Comment #5 from Sandra Loosemore <sandra at codesourcery dot com> ---
I think complete failure to build GCC for nios2 target due to target-inspecific
changes is a serious regression that needs to be addressed for GCC 5 release. 
Can we up the priority?

[Bug target/64377] nios2 compile error in options-save.c

[joel at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64377

--- Comment #8 from Joel Sherrill <joel at gcc dot gnu.org> ---
(In reply to Martin Liška from comment #7)
> Hello.
> 
> There's suggested patch [1], may I ask someone from nios2 community for
> testing the patch?
> 
> [1] https://gcc.gnu.org/ml/gcc-patches/2015-01/msg00465.html

I can confirm that is enough to build nios2-rtems and build RTEMS itself with
no issues. I don't have a simulator or target to run the tests on.

Is there a free simulator now?
>From gcc-bugs-return-472844-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Mon Jan 12 18:09:53 2015
Return-Path: <gcc-bugs-return-472844-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 9661 invoked by alias); 12 Jan 2015 18:09:52 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 9552 invoked by uid 48); 12 Jan 2015 18:09:46 -0000
From: "sandra at codesourcery dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/64377] nios2 compile error in options-save.c
Date: Mon, 12 Jan 2015 18:09:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: target
X-Bugzilla-Version: 5.0
X-Bugzilla-Keywords: build
X-Bugzilla-Severity: normal
X-Bugzilla-Who: sandra at codesourcery dot com
X-Bugzilla-Status: NEW
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-64377-4-7NtwAWOVSQ@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-64377-4@http.gcc.gnu.org/bugzilla/>
References: <bug-64377-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2015-01/txt/msg00838.txt.bz2
Content-length: 479

https://gcc.gnu.org/bugzilla/show_bug.cgi?idd377

--- Comment #9 from Sandra Loosemore <sandra at codesourcery dot com> ---
I've started running nios2-elf regression tests on hardware to compare against
a pre-breakage version from early November; it probably will not be done until
tomorrow morning.

I've heard that someone is working on the Nios II QEMU port again, but there is
nothing available to the general public yet, AFAIK, and I'm not sure of the
timeline for that.

[Bug target/64377] nios2 compile error in options-save.c

[sandra at codesourcery dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64377

--- Comment #10 from Sandra Loosemore <sandra at codesourcery dot com> ---
Test results do not look good with the new patch; over 7000 new failures on
-flto tests in the gcc testsuite alone.  :-(  I see a lot of

lto1: internal compiler error: in operator[], at vec.h:736
0x884aba2 vec<tree_node*, va_heap, vl_embed>::operator[](unsigned int)
    /scratch/sandra/nios2-elf-fsf/src/gcc-mainline/gcc/vec.h:736
0x884aba2 vec<tree_node*, va_heap, vl_ptr>::operator[](unsigned int)
    /scratch/sandra/nios2-elf-fsf/src/gcc-mainline/gcc/vec.h:1202
0x884aba2 streamer_tree_cache_get_tree
    /scratch/sandra/nios2-elf-fsf/src/gcc-mainline/gcc/tree-streamer.h:112
0x884aba2 streamer_get_pickled_tree(lto_input_block*, data_in*)
    /scratch/sandra/nios2-elf-fsf/src/gcc-mainline/gcc/tree-streamer-in.c:1112
0x84fa1fb lto_input_tree_1(lto_input_block*, data_in*, LTO_tags, unsigned int)
    /scratch/sandra/nios2-elf-fsf/src/gcc-mainline/gcc/lto-streamer-in.c:1303
0x84fa5ef lto_input_tree(lto_input_block*, data_in*)
    /scratch/sandra/nios2-elf-fsf/src/gcc-mainline/gcc/lto-streamer-in.c:1349
0x8849997 lto_input_ts_common_tree_pointers
    /scratch/sandra/nios2-elf-fsf/src/gcc-mainline/gcc/tree-streamer-in.c:666
0x8849997 streamer_read_tree_body(lto_input_block*, data_in*, tree_node*)
    /scratch/sandra/nios2-elf-fsf/src/gcc-mainline/gcc/tree-streamer-in.c:1044
0x84f9aef lto_read_tree_1
    /scratch/sandra/nios2-elf-fsf/src/gcc-mainline/gcc/lto-streamer-in.c:1179
0x84fa069 lto_read_tree
    /scratch/sandra/nios2-elf-fsf/src/gcc-mainline/gcc/lto-streamer-in.c:1213
0x84fa069 lto_input_tree_1
    /scratch/sandra/nios2-elf-fsf/src/gcc-mainline/gcc/lto-streamer-in.c:1332
0x84fa069 lto_input_tree_1(lto_input_block*, data_in*, LTO_tags, unsigned int)
    /scratch/sandra/nios2-elf-fsf/src/gcc-mainline/gcc/lto-streamer-in.c:1283
0x84fa501 lto_input_scc(lto_input_block*, data_in*, unsigned int*, unsigned
int*)
    /scratch/sandra/nios2-elf-fsf/src/gcc-mainline/gcc/lto-streamer-in.c:1237
0x81a8336 lto_read_decls
    /scratch/sandra/nios2-elf-fsf/src/gcc-mainline/gcc/lto/lto.c:1899
0x81aac1e lto_file_finalize
    /scratch/sandra/nios2-elf-fsf/src/gcc-mainline/gcc/lto/lto.c:2228
0x81aac1e lto_create_files_from_ids
    /scratch/sandra/nios2-elf-fsf/src/gcc-mainline/gcc/lto/lto.c:2238
0x81aac1e lto_file_read
    /scratch/sandra/nios2-elf-fsf/src/gcc-mainline/gcc/lto/lto.c:2279
0x81aac1e read_cgraph_and_symbols
    /scratch/sandra/nios2-elf-fsf/src/gcc-mainline/gcc/lto/lto.c:2980
0x81aac1e lto_main()
    /scratch/sandra/nios2-elf-fsf/src/gcc-mainline/gcc/lto/lto.c:3435
Please submit a full bug report,
with preprocessed source if appropriate.
Please include the complete backtrace with any bug report.
See <http://gcc.gnu.org/bugs.html> for instructions.
lto-wrapper: fatal error: nios2-elf-gcc returned 1 exit status
compilation terminated.

[Bug target/64377] nios2 compile error in options-save.c

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64377

--- Comment #11 from Martin Liška <marxin at gcc dot gnu.org> ---
Created attachment 34435
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=34435&action=edit
Fixed version of the patch
>From gcc-bugs-return-473027-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Tue Jan 13 15:28:59 2015
Return-Path: <gcc-bugs-return-473027-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 9399 invoked by alias); 13 Jan 2015 15:28:58 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 8293 invoked by uid 48); 13 Jan 2015 15:28:44 -0000
From: "marxin at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/64377] nios2 compile error in options-save.c
Date: Tue, 13 Jan 2015 15:28:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: target
X-Bugzilla-Version: 5.0
X-Bugzilla-Keywords: build
X-Bugzilla-Severity: normal
X-Bugzilla-Who: marxin at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-64377-4-LUuv7rDmFS@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-64377-4@http.gcc.gnu.org/bugzilla/>
References: <bug-64377-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2015-01/txt/msg01021.txt.bz2
Content-length: 385

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64377

--- Comment #12 from Martin Liška <marxin at gcc dot gnu.org> ---
There's fixed version of the patch where I fixed wrong loop boundaries:

  for (int i = n2fpu_code_num - 1; i >= 0; i--)
    ptr->saved_fpu_custom_code[i] = (int) bp_unpack_value (bp, 64);

Can you please re-launch few tests that failed?

Thanks,
Martin
>From gcc-bugs-return-473028-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Tue Jan 13 15:30:36 2015
Return-Path: <gcc-bugs-return-473028-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 16342 invoked by alias); 13 Jan 2015 15:30:35 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 15793 invoked by uid 55); 13 Jan 2015 15:30:28 -0000
From: "rth at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug libffi/64572] r219477 breaks bootstrap on x86_64 darwin
Date: Tue, 13 Jan 2015 15:30:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: libffi
X-Bugzilla-Version: 5.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: rth at gcc dot gnu.org
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: rth at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-64572-4-nI6B2oY174@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-64572-4@http.gcc.gnu.org/bugzilla/>
References: <bug-64572-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2015-01/txt/msg01022.txt.bz2
Content-length: 454

https://gcc.gnu.org/bugzilla/show_bug.cgi?idd572

--- Comment #9 from Richard Henderson <rth at gcc dot gnu.org> ---
Author: rth
Date: Tue Jan 13 15:29:47 2015
New Revision: 219538

URL: https://gcc.gnu.org/viewcvs?rev!9538&root=gcc&view=rev
Log:
PR libffi/64572

 * src/x86/ffitarget.h (FFI_GO_CLOSURES): Do not define for darwin.
 (FFI_TARGET_HAS_COMPLEX_TYPE): Likewise.

Modified:
    trunk/libffi/ChangeLog
    trunk/libffi/src/x86/ffitarget.h

[Bug target/64377] nios2 compile error in options-save.c

[sandra at codesourcery dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64377

--- Comment #13 from Sandra Loosemore <sandra at codesourcery dot com> ---
I think the new version of the patch in comment 11 is probably OK.  I ran the
entire gcc testsuite (but not g++, etc yet) and have a couple hundred
regressions compared to my r217010 build, but I don't see a pattern of them
being obviously lto-related.  (I started skimming over them and they look
mostly like broken test cases.)

[Bug target/64377] nios2 compile error in options-save.c

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64377

--- Comment #14 from Martin Liška <marxin at gcc dot gnu.org> ---
Thank you for testing. If the patch is going to be OK, I will send it to
mailing list with corresponding ChangeLog entry.
>From gcc-bugs-return-473068-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Tue Jan 13 20:50:14 2015
Return-Path: <gcc-bugs-return-473068-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 12952 invoked by alias); 13 Jan 2015 20:50:13 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 12892 invoked by uid 48); 13 Jan 2015 20:50:06 -0000
From: "marxin at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug ipa/64307] [5 Regression] ICE: verify_gimple failed: invalid argument to gimple call with -fPIC -fipa-icf
Date: Tue, 13 Jan 2015 20:50:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: ipa
X-Bugzilla-Version: 5.0
X-Bugzilla-Keywords: ice-on-valid-code
X-Bugzilla-Severity: normal
X-Bugzilla-Who: marxin at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Priority: P1
X-Bugzilla-Assigned-To: marxin at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 5.0
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-64307-4-uZnlURM70B@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-64307-4@http.gcc.gnu.org/bugzilla/>
References: <bug-64307-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2015-01/txt/msg01062.txt.bz2
Content-length: 422

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64307

--- Comment #5 from Martin Liška <marxin at gcc dot gnu.org> ---
Hello.

Following patch handles both issues:
https://gcc.gnu.org/ml/gcc-patches/2015-01/msg00934.html.

Problem with the example is that the pass decides to process local redirection
as merge operation. Unfortunately, there's no caller and that's the reason for
empty dump file output.

Martin
>From gcc-bugs-return-473069-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Tue Jan 13 21:00:21 2015
Return-Path: <gcc-bugs-return-473069-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 18512 invoked by alias); 13 Jan 2015 21:00:20 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 18426 invoked by uid 55); 13 Jan 2015 21:00:15 -0000
From: "hubicka at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug ipa/64565] [5 Regression] ICE: in inline_small_functions, at ipa-inline.c:1664
Date: Tue, 13 Jan 2015 21:00:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: ipa
X-Bugzilla-Version: 5.0
X-Bugzilla-Keywords: ice-on-valid-code
X-Bugzilla-Severity: blocker
X-Bugzilla-Who: hubicka at gcc dot gnu.org
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Priority: P1
X-Bugzilla-Assigned-To: hubicka at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 5.0
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-64565-4-Cuvx0S1OQE@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-64565-4@http.gcc.gnu.org/bugzilla/>
References: <bug-64565-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2015-01/txt/msg01063.txt.bz2
Content-length: 636

https://gcc.gnu.org/bugzilla/show_bug.cgi?idd565

--- Comment #7 from Jan Hubicka <hubicka at gcc dot gnu.org> ---
Author: hubicka
Date: Tue Jan 13 20:59:37 2015
New Revision: 219556

URL: https://gcc.gnu.org/viewcvs?rev!9556&root=gcc&view=rev
Log:

    PR ipa/64565
    * g++.dg/torture/pr64565.C: New testcase.
    * ipa-inline.c (inline_small_functions): Update callee keys after
    resolving speculation
    (inline_small_functions): Always check monotonicity of the queue.

Added:
    trunk/gcc/testsuite/g++.dg/torture/pr64565.C
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/ipa-inline.c
    trunk/gcc/testsuite/ChangeLog

[Bug target/64377] nios2 compile error in options-save.c

[sandra at codesourcery dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64377

--- Comment #15 from Sandra Loosemore <sandra at codesourcery dot com> ---
It looks like the apparent regressions in my test results are actually the
result of cascading errors from the test harness (Dejagnu is failing to fully
reset state after a test that got an error talking to the board).  So I'm sure
it's unrelated to the options problem or patch.

Martin, thanks a lot for working on this fix!  :-)

[Bug target/64377] nios2 compile error in options-save.c

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64377

--- Comment #16 from Martin Liška <marxin at gcc dot gnu.org> ---
Thank you for testing, there's patch I've just sent to gcc-patches ML:
https://gcc.gnu.org/ml/gcc-patches/2015-01/msg01008.html.

Martin
>From gcc-bugs-return-473178-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Wed Jan 14 11:34:14 2015
Return-Path: <gcc-bugs-return-473178-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 5149 invoked by alias); 14 Jan 2015 11:34:13 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 4535 invoked by uid 48); 14 Jan 2015 11:34:07 -0000
From: "rguenth at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/64541] FRE pass optimization failure
Date: Wed, 14 Jan 2015 11:34:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: tree-optimization
X-Bugzilla-Version: 5.0
X-Bugzilla-Keywords: missed-optimization
X-Bugzilla-Severity: normal
X-Bugzilla-Who: rguenth at gcc dot gnu.org
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: keywords cc short_desc
Message-ID: <bug-64541-4-gkfWlAPAF1@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-64541-4@http.gcc.gnu.org/bugzilla/>
References: <bug-64541-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2015-01/txt/msg01172.txt.bz2
Content-length: 1299

https://gcc.gnu.org/bugzilla/show_bug.cgi?idd541

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |missed-optimization
                 CC|rguenther at suse dot de           |rguenth at gcc dot gnu.org
            Summary|.fre1 pass optimization     |FRE pass optimization
                   |failure                     |failure

--- Comment #1 from Richard Biener <rguenth at gcc dot gnu.org> ---
The sources are different in that 2.c dereferences *p one more time after
*q is stored to while 1.c dereferences *q for the return value.  Thus an
equivalent 2.c would be

int f (int ** p, int ** q)
{
        ++*p;
        *q = *p;
        return **q;
}

it is true that we can still optimize the original 2.c but only because
*p and *q are equivalent (but it is probably not worthwhile the compile-time
cost
handling this). That is, we have to assume that p == q and thus the store to *q
invalidates the previously load *p.

I also think we have a duplicate report for this somewhere.

Simpler testcase (which is probably that in the duplicate):

int foo (int *p, int *q)
{
  *p = 1;
  *q = 1;
  return *p;
}

[Bug target/64377] nios2 compile error in options-save.c

[marxin at gcc dot gnu.org]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="UTF-8", Size: 4925 bytes --]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64377

--- Comment #17 from Martin Liška <marxin at gcc dot gnu.org> ---
Author: marxin
Date: Thu Jan 15 09:53:55 2015
New Revision: 219636

URL: https://gcc.gnu.org/viewcvs?rev=219636&root=gcc&view=rev
Log:
Target optimization nodes: add support for arrays.

    PR target/64377
    * optc-save-gen.awk: Add support for array types.


Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/optc-save-gen.awk
>From gcc-bugs-return-473311-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Thu Jan 15 09:55:28 2015
Return-Path: <gcc-bugs-return-473311-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 17580 invoked by alias); 15 Jan 2015 09:55:27 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 17545 invoked by uid 48); 15 Jan 2015 09:55:22 -0000
From: "jvoosten at bankai dot nl" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/64611] New: Using a << operator inside an overloaded << operator gives compile error
Date: Thu, 15 Jan 2015 09:55:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: c++
X-Bugzilla-Version: 4.8.2
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: jvoosten at bankai dot nl
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: bug_id short_desc product version bug_status bug_severity priority component assigned_to reporter attachments.created
Message-ID: <bug-64611-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2015-01/txt/msg01305.txt.bz2
Content-length: 2593

https://gcc.gnu.org/bugzilla/show_bug.cgi?idd611

            Bug ID: 64611
           Summary: Using a << operator inside an overloaded << operator
                    gives compile error
           Product: gcc
           Version: 4.8.2
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c++
          Assignee: unassigned at gcc dot gnu.org
          Reporter: jvoosten at bankai dot nl

Created attachment 34453
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id4453&actioníit
Preprocessed file

The following code gives a compile error on the indicated line:

#include <sstream>

class SmartStream
{
public:
    template <typename F> friend F &operator << (F &in, float f)
    {
        in.type ("f");
        in.m_buf << f;          // This causes a 'recursive' compile call
        return in;
    }

protected:
    std::ostringstream m_buf;

    void type(const std::string &_type) {};
};


int main(int argc, char *argv[])
{
    SmartStream ss;
    ss << 123.456;
}


Compile output:

$ g++ -save-temps -c rec_stream.cpp -o rec_stream.o
rec_stream.cpp: In instantiation of 'F& operator<<(F&, float) [with F std::basic_ostringstream<char>]':
rec_stream.cpp:10:18:   required from 'F& operator<<(F&, float) [with F SmartStream]'
rec_stream.cpp:24:11:   required from here
rec_stream.cpp:9:9: error: 'class std::basic_ostringstream<char>' has no member
named 'type'
         in.type ("f");
         ^
rec_stream.cpp:10:18: error: 'class std::basic_ostringstream<char>' has no
member named 'm_buf'
         in.m_buf << f;          // This causes a 'recursive' compile call
                  ^


Basically, it's applying the friend operator << function on the internal
std::ostringstream object, while I would expect the compiler to pick
'std::ostringstream::operator <<()'. Furthermore, casting, using :: resolution
operators, using the 'using' word all does not work. In fact, even the
following still triggers the error:


template <typename G>
std::string xyz(std::ostringstream &buf, G _param)
{
    buf.str("");
    buf << _param;
    return buf.str();
}

..and replacing the offending line with

  xyz<float>(m_buf, f);


Only if I move the code completely outside of SmartStream in a separate
function it will compile.

I also posted this on StackOverflow
(http://stackoverflow.com/questions/27952591/using-a-operator-inside-an-overloaded-operator)
and apparently this compiles on clang++. Perhaps there's an ambiguity towards
which 'operator <<' must be applied, but then I'd expect to be able to specify
which one.

[Bug target/64377] nios2 compile error in options-save.c

[joel at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64377

--- Comment #18 from Joel Sherrill <joel at gcc dot gnu.org> ---
I added Jon Beniston who did the initial port and Sebastien Bourdeauducq who is
listed as the lm32 maintainer but hasn't committed since 2011. I hope one of
them can help out here.

[Bug target/64377] nios2 compile error in options-save.c

[joel at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64377

--- Comment #19 from Joel Sherrill <joel at gcc dot gnu.org> ---
Sorry.. wrong PR.

[Bug target/64377] nios2 compile error in options-save.c

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64377

--- Comment #20 from Martin Liška <marxin at gcc dot gnu.org> ---
Can I please ask someone to confirm that the patch works and mark this issue as
resolved?
>From gcc-bugs-return-476505-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Mon Feb 09 16:22:54 2015
Return-Path: <gcc-bugs-return-476505-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 7718 invoked by alias); 9 Feb 2015 16:22:53 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 7635 invoked by uid 48); 9 Feb 2015 16:22:49 -0000
From: "jakub at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug sanitizer/64984] [5 Regression] ICE in check_noexcept_t with ubsan
Date: Mon, 09 Feb 2015 16:22:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: sanitizer
X-Bugzilla-Version: 5.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: jakub at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 5.0
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-64984-4-VHPvh2g3a3@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-64984-4@http.gcc.gnu.org/bugzilla/>
References: <bug-64984-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2015-02/txt/msg00838.txt.bz2
Content-length: 145

https://gcc.gnu.org/bugzilla/show_bug.cgi?idd984

--- Comment #2 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
I'll have a look tomorrow.

[Bug target/64377] nios2 compile error in options-save.c

[joel at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64377

Joel Sherrill <joel at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #21 from Joel Sherrill <joel at gcc dot gnu.org> ---
(In reply to Martin Liška from comment #20)
> Can I please ask someone to confirm that the patch works and mark this issue
> as resolved?

As reported above, I built the toolset and RTEMS but have no target to test on.
I am going to close it.

Sandra was testing on hardware so it is safe to safe she got by this as well.
>From gcc-bugs-return-476506-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Mon Feb 09 16:30:21 2015
Return-Path: <gcc-bugs-return-476506-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 25730 invoked by alias); 9 Feb 2015 16:30:19 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 25618 invoked by uid 48); 9 Feb 2015 16:30:13 -0000
From: "trippels at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug ipa/64978] [5 Regression] ICE: in ipcp_verify_propagated_values, at ipa-cp.c:1060
Date: Mon, 09 Feb 2015 16:30:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: ipa
X-Bugzilla-Version: 5.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: trippels at gcc dot gnu.org
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Priority: P1
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 5.0
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-64978-4-22rCHmN5N3@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-64978-4@http.gcc.gnu.org/bugzilla/>
References: <bug-64978-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2015-02/txt/msg00839.txt.bz2
Content-length: 919

https://gcc.gnu.org/bugzilla/show_bug.cgi?idd978

--- Comment #5 from Markus Trippelsdorf <trippels at gcc dot gnu.org> ---
Reduced testcase for comment 4:

trippels@gcc20 test % cat VTableBuilder.ii
class A {
public:
  A(int, int);
};
class B {
public:
  void m_fn1(bool, const int *, int &);
  unsigned m_fn2();
};
namespace {
class C {
  B &VTables;
  void m_fn3(A, unsigned, const int *, int &);

public:
  int VFTableBuilder_VisitedBases;
  B VFTableBuilder_VTables;
  C() : VTables(VFTableBuilder_VTables) {
    m_fn3(A(0, 0), 0, 0, VFTableBuilder_VisitedBases);
  }
};
}
int a;
void C::m_fn3(A, unsigned, const int *, int &) {
  for (;;)
    1 ? VTables.m_fn2() : 0;
}
void B::m_fn1(bool, const int *, int &) { C(); }
unsigned B::m_fn2() { m_fn1(0, 0, a); }

trippels@gcc20 test % g++ -O2 -c VTableBuilder.ii
VTableBuilder.ii:29:39: internal compiler error: in
ipcp_verify_propagated_values, at ipa-cp.c:1060