[Bug middle-end/64388] New: [5 Regression] r219037 caused FAIL: gcc.dg/pr44194-1.c

[Bug middle-end/64388] New: [5 Regression] r219037 caused FAIL: gcc.dg/pr44194-1.c

[hjl.tools at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64388

            Bug ID: 64388
           Summary: [5 Regression] r219037 caused FAIL: gcc.dg/pr44194-1.c
           Product: gcc
           Version: 5.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: middle-end
          Assignee: unassigned at gcc dot gnu.org
          Reporter: hjl.tools at gmail dot com
                CC: danglin at gcc dot gnu.org

On Linux/x86-64, r219037 caused

FAIL: gcc.dg/pr44194-1.c scan-rtl-dump dse1 "global deletions = (2|3)"
FAIL: gcc.dg/pr44194-1.c scan-rtl-dump-not final "insn[: ][^\n]*set
\\(mem(?![^\n]*scratch)"

[Bug middle-end/64388] [5 Regression] r219037 caused FAIL: gcc.dg/pr44194-1.c

[hjl.tools at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64388

H.J. Lu <hjl.tools at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |5.0

[Bug middle-end/64388] [5 Regression] r219037 caused FAIL: gcc.dg/pr44194-1.c

[dave.anglin at bell dot net]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64388

--- Comment #1 from dave.anglin at bell dot net ---
On 2014-12-23, at 12:31 PM, hjl.tools at gmail dot com wrote:

> On Linux/x86-64, r219037 caused
> 
> FAIL: gcc.dg/pr44194-1.c scan-rtl-dump dse1 "global deletions = (2|3)"
> FAIL: gcc.dg/pr44194-1.c scan-rtl-dump-not final "insn[: ][^\n]*set
> \\(mem(?![^\n]*scratch)"

The optimization could easily be restored if there was a procedure or target
hook to provide a way
to determine if a sibcall may read from the frame.  On hppa-linux, this would
be true if the sibcall
arguments were all passed in registers.  It might be possible to do this by
analyzing the decl.

The dse pass avoids looking at call usage information.

--
John David Anglin    dave.anglin@bell.net

[Bug middle-end/64388] [5 Regression] r219037 caused FAIL: gcc.dg/pr44194-1.c

[hjl.tools at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64388

H.J. Lu <hjl.tools at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2014-12-30
     Ever confirmed|0                           |1

--- Comment #2 from H.J. Lu <hjl.tools at gmail dot com> ---
(In reply to dave.anglin from comment #1)
> On 2014-12-23, at 12:31 PM, hjl.tools at gmail dot com wrote:
> 
> > On Linux/x86-64, r219037 caused
> > 
> > FAIL: gcc.dg/pr44194-1.c scan-rtl-dump dse1 "global deletions = (2|3)"
> > FAIL: gcc.dg/pr44194-1.c scan-rtl-dump-not final "insn[: ][^\n]*set
> > \\(mem(?![^\n]*scratch)"
> 
> The optimization could easily be restored if there was a procedure or target
> hook to provide a way
> to determine if a sibcall may read from the frame.  On hppa-linux, this
> would be true if the sibcall
> arguments were all passed in registers.  It might be possible to do this by
> analyzing the decl.

Can you add such a hook? Thanks.

[Bug middle-end/64388] [5 Regression] r219037 caused FAIL: gcc.dg/pr44194-1.c

[hjl.tools at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64388

--- Comment #4 from H.J. Lu <hjl.tools at gmail dot com> ---
A patch is posted at

https://gcc.gnu.org/ml/gcc-patches/2014-12/msg01990.html

[Bug middle-end/64388] [5 Regression] r219037 caused FAIL: gcc.dg/pr44194-1.c

[dave.anglin at bell dot net]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64388

--- Comment #5 from dave.anglin at bell dot net ---
On 2015-01-03, at 10:01 AM, hjl.tools at gmail dot com wrote:

> --- Comment #4 from H.J. Lu <hjl.tools at gmail dot com> ---
> A patch is posted at
> 
> https://gcc.gnu.org/ml/gcc-patches/2014-12/msg01990.html

Can't review but the implementation looks good to me.

Dave
--
John David Anglin    dave.anglin@bell.net

[Bug middle-end/64388] [5 Regression] r219037 caused FAIL: gcc.dg/pr44194-1.c

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64388

--- Comment #6 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Author: jakub
Date: Thu Jan  8 21:29:44 2015
New Revision: 219361

URL: https://gcc.gnu.org/viewcvs?rev=219361&root=gcc&view=rev
Log:
    PR target/55023
    PR middle-end/64388
    * dse.c (struct insn_info): Mention frame_read set also
    before reload for tail calls on some targets.
    (scan_insn): Revert 2014-12-22 change.  Set frame_read
    also before reload for tail calls if
    HARD_FRAME_POINTER_IS_ARG_POINTER.  Call add_wild_read
    instead of add_non_frame_wild_read for non-const/memset
    tail calls after reload.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/dse.c

[Bug middle-end/64388] [5 Regression] r219037 caused FAIL: gcc.dg/pr44194-1.c

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64388

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |jakub at gcc dot gnu.org
         Resolution|---                         |FIXED

--- Comment #7 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Should be fixed now.