public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "mw_triad at users dot sourceforge.net" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug libstdc++/64399] g++ does not diagnose when upcasting owning pointer (e.g. unique_ptr) with non-virtual destructor Date: Wed, 24 Dec 2014 16:59:00 -0000 [thread overview] Message-ID: <bug-64399-4-z3QyddtDs3@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-64399-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64399 --- Comment #7 from Matthew Woehlke <mw_triad at users dot sourceforge.net> --- (In reply to Thiago Macieira from comment #3) > Because it's not a bug. > > This is a totally valid scenario. Valid in what way? I constructed a Y but arranged, probably by accident, that its dtor is never called. I fail to see how that's not likely a bug in my code that reasonably warrants a diagnostic. (Note that I'm talking about a *warning*, and possibly one that isn't even on by default, not an error.) (In reply to Marc Glisse from comment #6) > It might pedantically be illegal, but it is useful, and I believe some people > would like to avoid the warning when the two destructors are equivalent. However, the compiler doesn't know that here, because I didn't provided a definition thereof; Y's dtor, even in this example, could have important side effects. Even if the compiler *can* prove equivalence, I'd be suspicious whether this was intended, but I'd be okay with a different (i.e. more pedantic) warning in that case. (I'd also point out that it's not unreasonable to require the user to somehow annotate if this is intentional if they care about avoiding the warning when it's enabled.) Anyway, I still get no warning if Y has members that need to be destroyed, which definitely causes bad behavior when its dtor isn't called.
next prev parent reply other threads:[~2014-12-24 16:59 UTC|newest] Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-12-23 22:58 [Bug libstdc++/64399] New: " mw_triad at users dot sourceforge.net 2014-12-23 23:33 ` [Bug libstdc++/64399] " redi at gcc dot gnu.org 2014-12-23 23:37 ` mw_triad at users dot sourceforge.net 2014-12-24 1:37 ` thiago at kde dot org 2014-12-24 8:59 ` redi at gcc dot gnu.org 2014-12-24 9:01 ` redi at gcc dot gnu.org 2014-12-24 10:36 ` glisse at gcc dot gnu.org 2014-12-24 16:59 ` mw_triad at users dot sourceforge.net [this message] 2021-08-31 18:20 ` redi at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-64399-4-z3QyddtDs3@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).