public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "mw_triad at users dot sourceforge.net" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug libstdc++/64399] New: g++ does not diagnose when upcasting owning pointer (e.g. unique_ptr) with non-virtual destructor Date: Tue, 23 Dec 2014 22:58:00 -0000 [thread overview] Message-ID: <bug-64399-4@http.gcc.gnu.org/bugzilla/> (raw) https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64399 Bug ID: 64399 Summary: g++ does not diagnose when upcasting owning pointer (e.g. unique_ptr) with non-virtual destructor Product: gcc Version: 4.8.3 Status: UNCONFIRMED Severity: normal Priority: P3 Component: libstdc++ Assignee: unassigned at gcc dot gnu.org Reporter: mw_triad at users dot sourceforge.net Consider the following code: #include <memory> struct X { ~X(); }; struct Y : X { ~Y(); }; std::unique_ptr<Y> f(); void g() { std::unique_ptr<X> x = f(); } This code is almost certainly broken; ownership of the constructed Y is transferred to an owning unique_ptr in a way that will most likely (in general; "always" in this specific example) result in Y's destructor never being called. It seems pretty silly that there is no diagnostic for this. There ought to be a warning in unique_ptr's conversion operator converting from Derived to Base if ~Base is not virtual. (Arranging at the library level to trip -Wnon-virtual-dtor seems logical.)
next reply other threads:[~2014-12-23 22:58 UTC|newest] Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-12-23 22:58 mw_triad at users dot sourceforge.net [this message] 2014-12-23 23:33 ` [Bug libstdc++/64399] " redi at gcc dot gnu.org 2014-12-23 23:37 ` mw_triad at users dot sourceforge.net 2014-12-24 1:37 ` thiago at kde dot org 2014-12-24 8:59 ` redi at gcc dot gnu.org 2014-12-24 9:01 ` redi at gcc dot gnu.org 2014-12-24 10:36 ` glisse at gcc dot gnu.org 2014-12-24 16:59 ` mw_triad at users dot sourceforge.net 2021-08-31 18:20 ` redi at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-64399-4@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).