[Bug libstdc++/64476] New: std::uninitialized_copy tests assignability the wrong way, resulting in performance pessimization

[Bug libstdc++/64476] New: std::uninitialized_copy tests assignability the wrong way, resulting in performance pessimization

[gcc-bugzilla at contacts dot eelis.net]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64476

            Bug ID: 64476
           Summary: std::uninitialized_copy tests assignability the wrong
                    way, resulting in performance pessimization
           Product: gcc
           Version: 5.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: libstdc++
          Assignee: unassigned at gcc dot gnu.org
          Reporter: gcc-bugzilla at contacts dot eelis.net

It does:

  typedef typename iterator_traits<_InputIterator>::reference _RefType;
  const bool __assignable = is_assignable<_ValueType1, _RefType>::value;

but should do:

  typedef typename iterator_traits<_ForwardIterator>::reference _RefType;
  const bool __assignable = is_assignable<_RefType, _ValueType1>::value;

[Bug libstdc++/64476] [4.9/5 Regression] std::uninitialized_copy tests assignability the wrong way, resulting in performance pessimization

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64476

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
   Last reconfirmed|                            |2015-01-09
           Assignee|unassigned at gcc dot gnu.org      |redi at gcc dot gnu.org
   Target Milestone|---                         |4.9.3
            Summary|std::uninitialized_copy     |[4.9/5 Regression]
                   |tests assignability the     |std::uninitialized_copy
                   |wrong way, resulting in     |tests assignability the
                   |performance pessimization   |wrong way, resulting in
                   |                            |performance pessimization
     Ever confirmed|0                           |1

[Bug libstdc++/64476] [4.9/5 Regression] std::uninitialized_copy tests assignability the wrong way, resulting in performance pessimization

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64476

--- Comment #2 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Author: redi
Date: Fri Jan  9 18:02:47 2015
New Revision: 219398

URL: https://gcc.gnu.org/viewcvs?rev=219398&root=gcc&view=rev
Log:
    PR libstdc++/64476
    * include/bits/stl_uninitialized.h (uninitialized_copy): Fix
    is_assignable arguments.
    * testsuite/20_util/specialized_algorithms/uninitialized_copy/64476.cc:
    New.

Added:
   
trunk/libstdc++-v3/testsuite/20_util/specialized_algorithms/uninitialized_copy/64476.cc
Modified:
    trunk/libstdc++-v3/ChangeLog
    trunk/libstdc++-v3/include/bits/stl_uninitialized.h

[Bug libstdc++/64476] [4.9/5 Regression] std::uninitialized_copy tests assignability the wrong way, resulting in performance pessimization

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64476

--- Comment #1 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Author: redi
Date: Fri Jan  9 18:02:30 2015
New Revision: 219397

URL: https://gcc.gnu.org/viewcvs?rev=219397&root=gcc&view=rev
Log:
    PR libstdc++/64476
    * include/bits/stl_uninitialized.h (uninitialized_copy): Fix
    is_assignable arguments.
    * testsuite/20_util/specialized_algorithms/uninitialized_copy/64476.cc:
    New.

Added:
   
branches/gcc-4_9-branch/libstdc++-v3/testsuite/20_util/specialized_algorithms/uninitialized_copy/64476.cc
Modified:
    branches/gcc-4_9-branch/libstdc++-v3/ChangeLog
    branches/gcc-4_9-branch/libstdc++-v3/include/bits/stl_uninitialized.h

[Bug libstdc++/64476] [4.9/5 Regression] std::uninitialized_copy tests assignability the wrong way, resulting in performance pessimization

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64476

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Fixed for 4.9.3 and 5.0