[Bug tree-optimization/64528] [5 Regression] ICE: in process_constraint, at tree-ssa-structalias.c:3002 with -O -fno-tree-ccp -fno-tree-dce

[Bug tree-optimization/64528] [5 Regression] ICE: in process_constraint, at tree-ssa-structalias.c:3002 with -O -fno-tree-ccp -fno-tree-dce

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64528

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |5.0

[Bug tree-optimization/64528] [5 Regression] ICE: in process_constraint, at tree-ssa-structalias.c:3002 with -O -fno-tree-ccp -fno-tree-dce

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64528

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2015-01-12
                 CC|                            |jakub at gcc dot gnu.org
     Ever confirmed|0                           |1

--- Comment #1 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Started with r211736.

[Bug fortran/64528] [5 Regression] ICE: in process_constraint, at tree-ssa-structalias.c:3002 with -O -fno-tree-ccp -fno-tree-dce

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64528

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |burnus at gcc dot gnu.org
          Component|tree-optimization           |fortran

--- Comment #2 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
I'd say this is a Fortran FE bug.
The reason this ICEs is that the inliner emits 10 = 11; statement (with
INTEGER_CST on lhs), but that happens because myint PARM_DECL is TREE_READONLY,
which looks wrong when it clearly is assigned to.
The setting of TREE_READONLY happens in trans-decl.c:
2330          /* All implementation args are read-only.  */
2331          TREE_READONLY (parm) = 1;
That looks just wrong at least for some f->sym->attr.value dummy arguments ==
PARM_DECLs, perhaps all?

[Bug fortran/64528] [5 Regression] ICE: in process_constraint, at tree-ssa-structalias.c:3002 with -O -fno-tree-ccp -fno-tree-dce

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64528

--- Comment #3 from Richard Biener <rguenth at gcc dot gnu.org> ---
Indeed:

/* In a VAR_DECL, PARM_DECL or FIELD_DECL, or any kind of ..._REF node,
   nonzero means it may not be the lhs of an assignment.
   Nonzero in a FUNCTION_DECL means this function should be treated
   as "const" function (can only read its arguments).  */
#define TREE_READONLY(NODE) (NON_TYPE_CHECK (NODE)->base.readonly_flag)

OTOH the stmt verifier should better catch this error as well.

[Bug fortran/64528] [5 Regression] ICE: in process_constraint, at tree-ssa-structalias.c:3002 with -O -fno-tree-ccp -fno-tree-dce

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64528

--- Comment #4 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Author: jakub
Date: Tue Jan 13 16:42:22 2015
New Revision: 219543

URL: https://gcc.gnu.org/viewcvs?rev=219543&root=gcc&view=rev
Log:
    PR fortran/64528
    * trans-decl.c (create_function_arglist): Don't set TREE_READONLY
    on dummy args with VALUE attribute.

    * gfortran.dg/pr64528.f90: New test.

Added:
    trunk/gcc/testsuite/gfortran.dg/pr64528.f90
Modified:
    trunk/gcc/fortran/ChangeLog
    trunk/gcc/fortran/trans-decl.c
    trunk/gcc/testsuite/ChangeLog

[Bug fortran/64528] [5 Regression] ICE: in process_constraint, at tree-ssa-structalias.c:3002 with -O -fno-tree-ccp -fno-tree-dce

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64528

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #5 from Richard Biener <rguenth at gcc dot gnu.org> ---
Fixed.

[Bug fortran/64528] [5 Regression] ICE: in process_constraint, at tree-ssa-structalias.c:3002 with -O -fno-tree-ccp -fno-tree-dce

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64528

--- Comment #6 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Author: jakub
Date: Wed Jan 14 20:22:47 2015
New Revision: 219613

URL: https://gcc.gnu.org/viewcvs?rev=219613&root=gcc&view=rev
Log:
    Backported from mainline
    2015-01-13  Jakub Jelinek  <jakub@redhat.com>

    PR fortran/64528
    * trans-decl.c (create_function_arglist): Don't set TREE_READONLY
    on dummy args with VALUE attribute.

    * gfortran.dg/pr64528.f90: New test.

Added:
    branches/gcc-4_9-branch/gcc/testsuite/gfortran.dg/pr64528.f90
Modified:
    branches/gcc-4_9-branch/gcc/fortran/ChangeLog
    branches/gcc-4_9-branch/gcc/fortran/trans-decl.c
    branches/gcc-4_9-branch/gcc/testsuite/ChangeLog

[Bug fortran/64528] [5 Regression] ICE: in process_constraint, at tree-ssa-structalias.c:3002 with -O -fno-tree-ccp -fno-tree-dce

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64528

--- Comment #7 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Author: jakub
Date: Sun Feb  1 21:51:40 2015
New Revision: 220333

URL: https://gcc.gnu.org/viewcvs?rev=220333&root=gcc&view=rev
Log:
    Backported from mainline
    2015-01-13  Jakub Jelinek  <jakub@redhat.com>

    PR fortran/64528
    * trans-decl.c (create_function_arglist): Don't set TREE_READONLY
    on dummy args with VALUE attribute.

    * gfortran.dg/pr64528.f90: New test.

Added:
    branches/gcc-4_8-branch/gcc/testsuite/gfortran.dg/pr64528.f90
Modified:
    branches/gcc-4_8-branch/gcc/fortran/ChangeLog
    branches/gcc-4_8-branch/gcc/fortran/trans-decl.c
    branches/gcc-4_8-branch/gcc/testsuite/ChangeLog