[Bug target/64600] New: arm-rtems ICE on valid code (-mcpu=xscale)

[Bug target/64600] New: arm-rtems ICE on valid code (-mcpu=xscale)

[joel at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64600

            Bug ID: 64600
           Summary: arm-rtems ICE on valid code (-mcpu=xscale)
           Product: gcc
           Version: 5.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: target
          Assignee: unassigned at gcc dot gnu.org
          Reporter: joel at gcc dot gnu.org

$ arm-rtems4.11-gcc --version
arm-rtems4.11-gcc (GCC) 5.0.0 20150114 (experimental)

Last hash per git: commit d4cbe45aae70e38c12f3cd7430427c98289d7882

The fix for 64460 is in place.

Attached test case compiles at -Os but not -O1 or -O2. 
-O2 without -mcpu=xscale also works.

arm-rtems4.11-gcc --pipe -DHAVE_CONFIG_H   -I..
-I../../cpukit/../../../gumstix/lib/include   -mcpu=xscale -O2 -g -Wall
-Wmissing-prototypes -Wimplicit-function-declaration -Wstrict-prototypes
-Wnested-externs -MT src/libcsupport_a-cfgetospeed.o -MD -MP -MF
src/.deps/libcsupport_a-cfgetospeed.Tpo -c -o src/libcsupport_a-cfgetospeed.o
`test -f 'src/cfgetospeed.c' || echo
'../../../../../../rtems/c/src/../../cpukit/libcsupport/'`src/cfgetospeed.c
../../../../../../rtems/c/src/../../cpukit/libcsupport/src/cfgetospeed.c: In
function 'cfgetospeed':
../../../../../../rtems/c/src/../../cpukit/libcsupport/src/cfgetospeed.c:37:1:
internal compiler error: in decompose, at rtl.h:2005
 }
 ^
0x41c918 wi::int_traits<std::pair<rtx_def*, machine_mode> >::decompose(long*,
unsigned int, std::pair<rtx_def*, machine_mode> const&)
    ../../gcc/gcc/rtl.h:2005
0x91eae0 wi::int_traits<std::pair<rtx_def*, machine_mode> >::decompose(long*,
unsigned int, std::pair<rtx_def*, machine_mode> const&)
    ../../gcc/gcc/rtl.h:2005
0x91eae0 wide_int_ref_storage<false>::wide_int_ref_storage<std::pair<rtx_def*,
machine_mode> >(std::pair<rtx_def*, machine_mode> const&, unsigned int)
    ../../gcc/gcc/wide-int.h:957
0x91eae0 generic_wide_int<wide_int_ref_storage<false>
>::generic_wide_int<std::pair<rtx_def*, machine_mode> >(std::pair<rtx_def*,
machine_mode> const&, unsigned int)
    ../../gcc/gcc/wide-int.h:733
0x91eae0 wi::binary_traits<std::pair<rtx_def*, machine_mode>,
std::pair<rtx_def*, machine_mode>, wi::int_traits<std::pair<rtx_def*,
machine_mode> >::precision_type, wi::int_traits<std::pair<rtx_def*,
machine_mode> >::precision_type>::result_type wi::sub<std::pair<rtx_def*,
machine_mode>, std::pair<rtx_def*, machine_mode> >(std::pair<rtx_def*,
machine_mode> const&, std::pair<rtx_def*, machine_mode> const&)
    ../../gcc/gcc/wide-int.h:2357
0x91eae0 simplify_const_binary_operation(rtx_code, machine_mode, rtx_def*,
rtx_def*)
    ../../gcc/gcc/simplify-rtx.c:3867
0x91bf3f simplify_binary_operation(rtx_code, machine_mode, rtx_def*, rtx_def*)
    ../../gcc/gcc/simplify-rtx.c:1972
0x91fc77 simplify_associative_operation
    ../../gcc/gcc/simplify-rtx.c:1929
0x9188cc simplify_binary_operation_1
    ../../gcc/gcc/simplify-rtx.c:2967
0xdd4f21 combine_simplify_rtx
    ../../gcc/gcc/combine.c:5541
0xdd743b subst
    ../../gcc/gcc/combine.c:5374
0xdd70c8 subst
    ../../gcc/gcc/combine.c:5319
0xdd97ce try_combine
    ../../gcc/gcc/combine.c:3266
0xddef81 combine_instructions
    ../../gcc/gcc/combine.c:1312
0xddef81 rest_of_handle_combine
    ../../gcc/gcc/combine.c:14094
0xddef81 execute
    ../../gcc/gcc/combine.c:14137
Please submit a full bug report,
with preprocessed source if appropriate.

[Bug target/64600] arm-rtems ICE on valid code (-mcpu=xscale)

[joel at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64600

--- Comment #1 from Joel Sherrill <joel at gcc dot gnu.org> ---
Created attachment 34450
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=34450&action=edit
Preprocessed RTEMS source which produces the error

[Bug target/64600] arm-rtems ICE on valid code (-mcpu=xscale)

[joel at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64600

--- Comment #2 from Joel Sherrill <joel at gcc dot gnu.org> ---
*** Bug 64599 has been marked as a duplicate of this bug. ***

[Bug target/64600] arm-rtems ICE on valid code (-mcpu=xscale)

[joel at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64600

--- Comment #3 from Joel Sherrill <joel at gcc dot gnu.org> ---
(In reply to Joel Sherrill from comment #1)
> Created attachment 34450 [details]
> Preprocessed RTEMS source which produces the error

Attached test case compiles at -Os but not -O1 or -O2. 
-O2 without -mcpu=xscale also works.

Compiles find with end of 4.9 branch

arm-rtems4.11-gcc (GCC) 4.9.3 20150104 (prerelease)

[Bug target/64600] arm-rtems ICE on valid code (-mcpu=xscale)

[ktkachov at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64600

--- Comment #4 from ktkachov at gcc dot gnu.org ---
I can't reproduce with -mcpu=xscale and any of -Os,O1,O2,O3 with or without -g.

Can you post the full configuration of gcc? maybe there's something there that
plays a role...

[Bug target/64600] [5.0 regression] arm-rtems ICE on valid code (-mcpu=xscale)

[ramana at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64600

Ramana Radhakrishnan <ramana at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2015-01-15
     Ever confirmed|0                           |1

--- Comment #5 from Ramana Radhakrishnan <ramana at gcc dot gnu.org> ---
Confirmed - svn+ssh://gcc.gnu.org/svn/gcc/trunk@219641

Passed in a build I had from 13/01/2015.

This is a regression.

[Bug target/64600] [5.0 regression] arm-rtems ICE on valid code (-mcpu=xscale)

[ktkachov at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64600

--- Comment #6 from ktkachov at gcc dot gnu.org ---
(In reply to Ramana Radhakrishnan from comment #5)
> Confirmed - svn+ssh://gcc.gnu.org/svn/gcc/trunk@219641
> 
> Passed in a build I had from 13/01/2015.
> 
> This is a regression.

Huh, I reproduced it now with a clean toolchain.
Seems that some patch in my tree hid this (from the stack trace don't think
anything I have fixes this).

[Bug target/64600] [5.0 regression] arm-rtems ICE on valid code (-mcpu=xscale)

[ktkachov at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64600

--- Comment #7 from ktkachov at gcc dot gnu.org ---
(In reply to Ramana Radhakrishnan from comment #5)
> Confirmed - svn+ssh://gcc.gnu.org/svn/gcc/trunk@219641
> 
> Passed in a build I had from 13/01/2015.
> 
> This is a regression.

now that I reproduced this I can't un-reproduce ;)
This goes for me at least as far back as Dec 15.
The ICE is a gcc_checking_assert so perhaps your 13/01 toolchain doesn't have
checking enabled?

[Bug target/64600] [5.0 regression] arm-rtems ICE on valid code (-mcpu=xscale)

[ktkachov at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64600

ktkachov at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rsandifo at gcc dot gnu.org

--- Comment #8 from ktkachov at gcc dot gnu.org ---
The ICE is in the wide-int bit_and code when trying to process the rtx:

(and:SI
  (const_int 4294963215 [0xfffff00f])
  (const_int 4111 [0x100f])
)

In particular it seems to have problems constructing a wide-int for
(const_int 4294963215 [0xfffff00f])

Richard, does the trace give you any ideas on this?

[Bug target/64600] [5.0 regression] arm-rtems ICE on valid code (-mcpu=xscale)

[joel at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64600

--- Comment #9 from Joel Sherrill <joel at gcc dot gnu.org> ---
I don't build with checking enabled. 

The normal recommended configuration for an RTEMS toolchain is long since we
build newlib at the same time and have iconv options. When I do git bisect, I
usually drop the newlib and disable-multilib. But here is how it failed for me
per the top level config.log:

/users/joel/test-gcc/gcc/configure --verbose --disable-werror
--disable-libstdcxx-pch --with-gnu-as --with-gnu-ld --with-newlib
--enable-multilib --enable-newlib-mb --enable-newlib-iconv --with-system-zlib
--disable-nls --without-included-gettext --disable-win32-registry
--enable-version-specific-runtime-libs --enable-newlib-iconv
--enable-newlib-iconv-encodings=big5,cp775,cp850,cp852,cp855,cp866,euc_jp,euc_kr,euc_tw,iso_8859_1,iso_8859_10,iso_8859_11,iso_8859_13,iso_8859_14,iso_8859_15,iso_8859_2,iso_8859_3,iso_8859_4,iso_8859_5,iso_8859_6,iso_8859_7,iso_8859_8,iso_8859_9,iso_ir_111,koi8_r,koi8_ru,koi8_u,koi8_uni,ucs_2,ucs_2_internal,ucs_2be,ucs_2le,ucs_4,ucs_4_internal,ucs_4be,ucs_4le,us_ascii,utf_16,utf_16be,utf_16le,utf_8,win_1250,win_1251,win_1252,win_1253,win_1254,win_1255,win_1256,win_1257,win_1258
--disable-lto --enable-newlib-io-c99-formats --enable-threads --disable-plugin
--enable-languages=c,c++ --target=arm-rtems4.11
--prefix=/users/joel/test-gcc/install-head

I am happy to try anything you need.

[Bug target/64600] [5.0 regression] arm-rtems ICE on valid code (-mcpu=xscale)

[rsandifo at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64600

--- Comment #10 from rsandifo at gcc dot gnu.org <rsandifo at gcc dot gnu.org> ---
(In reply to ktkachov from comment #8)
> The ICE is in the wide-int bit_and code when trying to process the rtx:
> 
> (and:SI
>   (const_int 4294963215 [0xfffff00f])
>   (const_int 4111 [0x100f])
> )
> 
> In particular it seems to have problems constructing a wide-int for
> (const_int 4294963215 [0xfffff00f])

Yeah, that isn't a valid SImode const_int.  It needs to be sign-extended rather
than zero-extended from bit 31.

[Bug target/64600] [5.0 regression] arm-rtems ICE on valid code (-mcpu=xscale)

[ramana at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64600

Ramana Radhakrishnan <ramana at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |5.0
      Known to fail|                            |5.0

[Bug target/64600] [5 regression] arm-rtems ICE on valid code (-mcpu=xscale)

[ktkachov at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64600

ktkachov at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|unassigned at gcc dot gnu.org      |ktkachov at gcc dot gnu.org

--- Comment #12 from ktkachov at gcc dot gnu.org ---
I have a fix in the works.

[Bug target/64600] [5 regression] arm-rtems ICE on valid code (-mcpu=xscale)

[ktkachov at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64600

--- Comment #13 from ktkachov at gcc dot gnu.org ---
Author: ktkachov
Date: Fri Mar 13 10:48:44 2015
New Revision: 221413

URL: https://gcc.gnu.org/viewcvs?rev=221413&root=gcc&view=rev
Log:
[ARM] PR target/64600 Fix another ICE with -mtune=xscale: properly sign-extend
mask during constant splitting

    PR target/64600
    * config/arm/arm.c (arm_gen_constant, AND case): Use
    ARM_SIGN_EXTEND when constructing AND mask.

    PR target/64600
    * gcc.target/arm/pr64600_1.c: New test.

Added:
    trunk/gcc/testsuite/gcc.target/arm/pr64600_1.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/config/arm/arm.c
    trunk/gcc/testsuite/ChangeLog

[Bug target/64600] [5 regression] arm-rtems ICE on valid code (-mcpu=xscale)

[ktkachov at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64600

--- Comment #14 from ktkachov at gcc dot gnu.org ---
Should be fixed on trunk.
Joel, can you please confirm for you and close if appropriate?

[Bug target/64600] [5 regression] arm-rtems ICE on valid code (-mcpu=xscale)

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64600

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #15 from Richard Biener <rguenth at gcc dot gnu.org> ---
Assuming fixed.