[Bug go/64683] New: FAIL: runtime/pprof -- testing.go:278: The entry did not match

[Bug go/64683] New: FAIL: runtime/pprof -- testing.go:278: The entry did not match

[vries at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64683

            Bug ID: 64683
           Summary: FAIL: runtime/pprof -- testing.go:278: The entry did
                    not match
           Product: gcc
           Version: 5.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: go
          Assignee: ian at airs dot com
          Reporter: vries at gcc dot gnu.org
                CC: cmang at google dot com

--- FAIL: TestMemoryProfiler (0.67s)
        testing.go:278: The entry did not match:
                0: 0 \[1: 2097152\] @ 0x[0-9,a-f x]+
                #       0x[0-9,a-f]+   
pprof_test\.allocateTransient2M\+0x[0-9,a-f]+   .*/mprof_test.go:30
                #       0x[0-9,a-f]+   
runtime_pprof_test\.TestMemoryProfiler\+0x[0-9,a-f]+    .*/mprof_test.go:65

[Bug go/64683] FAIL: runtime/pprof -- testing.go:278: The entry did not match

[vries at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64683

--- Comment #1 from vries at gcc dot gnu.org ---
Created attachment 34494
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=34494&action=edit
libgo.log (nobootstrap build)

[Bug go/64683] FAIL: runtime/pprof -- testing.go:278: The entry did not match

[vries at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64683

--- Comment #2 from vries at gcc dot gnu.org ---
Created attachment 34495
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=34495&action=edit
libgo.log (bootstrap build)

[Bug go/64683] FAIL: runtime/pprof -- testing.go:278: The entry did not match

[vries at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64683

--- Comment #3 from vries at gcc dot gnu.org ---
configure line nobootstrap build:
...
$ ./nobootstrap/install/bin/gccgo -v
Using built-in specs.
COLLECT_GCC=./nobootstrap/install/bin/gccgo
COLLECT_LTO_WRAPPER=/data/vries/ref-master-15-01-19/nobootstrap/install/bin/../libexec/gcc/x86_64-unknown-linux-gnu/5.0.0/lto-wrapper
Target: x86_64-unknown-linux-gnu
Configured with:
/home/vries/gcc_versions/data/ref-master-15-01-19/src/configure
--prefix=/home/vries/gcc_versions/data/ref-master-15-01-19/nobootstrap/install
--with-cloog=/home/vries/gcc_versions/infra
--with-ppl=/home/vries/gcc_versions/infra
--with-gmp=/home/vries/gcc_versions/infra
--with-mpfr=/home/vries/gcc_versions/infra
--with-mpc=/home/vries/gcc_versions/infra
--with-isl=/home/vries/gcc_versions/infra --disable-bootstrap
--enable-checking=yes,rtl
--enable-languages=c,fortran,ada,java,objc,c++,go,obj-c++
Thread model: posix
gcc version 5.0.0 20150119 (experimental) (GCC) 
...

configure line bootstrap build (the same, but without --disable-bootstrap):
...
$ ./install/bin/gccgo -v
Using built-in specs.
COLLECT_GCC=./install/bin/gccgo
COLLECT_LTO_WRAPPER=/data/vries/ref-master-15-01-19/install/bin/../libexec/gcc/x86_64-unknown-linux-gnu/5.0.0/lto-wrapper
Target: x86_64-unknown-linux-gnu
Configured with:
/home/vries/gcc_versions/data/ref-master-15-01-19/src/configure
--prefix=/home/vries/gcc_versions/data/ref-master-15-01-19/install
--with-cloog=/home/vries/gcc_versions/infra
--with-ppl=/home/vries/gcc_versions/infra
--with-gmp=/home/vries/gcc_versions/infra
--with-mpfr=/home/vries/gcc_versions/infra
--with-mpc=/home/vries/gcc_versions/infra
--with-isl=/home/vries/gcc_versions/infra --enable-checking=yes,rtl
--enable-languages=c,fortran,ada,java,objc,c++,go,obj-c++
Thread model: posix
gcc version 5.0.0 20150119 (experimental) (GCC) 
...

[Bug go/64683] FAIL: runtime/pprof -- testing.go:278: The entry did not match

[vries at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64683

--- Comment #4 from vries at gcc dot gnu.org ---
Ran into this failure with r219832.

[Bug go/64683] FAIL: runtime/pprof -- testing.go:278: The entry did not match

[ian at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64683

--- Comment #5 from ian at gcc dot gnu.org <ian at gcc dot gnu.org> ---
Author: ian
Date: Tue Jan 20 16:11:36 2015
New Revision: 219900

URL: https://gcc.gnu.org/viewcvs?rev=219900&root=gcc&view=rev
Log:
    PR go/64683
runtime/pprof: Let memory profiler test pass if value not collected.

Since gccgo's GC is not precise, the transient value may not
be collected.  Let the regexp match that case as well.

Modified:
    trunk/libgo/go/runtime/pprof/mprof_test.go

[Bug go/64683] FAIL: runtime/pprof -- testing.go:278: The entry did not match

[ian at airs dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64683

--- Comment #6 from Ian Lance Taylor <ian at airs dot com> ---
Should be fixed now.  Thanks for reporting it.

[Bug go/64683] FAIL: runtime/pprof -- testing.go:278: The entry did not match

[vries at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64683

vries at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED

--- Comment #7 from vries at gcc dot gnu.org ---
Marking resolved, fixed

[Bug go/64683] FAIL: runtime/pprof -- testing.go:278: The entry did not match

[vries at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64683

vries at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |NEW
   Last reconfirmed|                            |2015-03-11
         Resolution|FIXED                       |---
     Ever confirmed|0                           |1

--- Comment #8 from vries at gcc dot gnu.org ---
Test fails again (for x86_64, but not with -m32), with similar message:
...
--- FAIL: TestMemoryProfiler (2.17s)
        testing.go:278: The entry did not match:
                (0|1): (0|2097152) \[1: 2097152\] @ 0x[0-9,a-f x]+
                #       0x[0-9,a-f]+   
pprof_test\.allocateTransient2M\+0x[0-9,a-f]+   .*/mprof_test.go:30
                #       0x[0-9,a-f]+   
runtime_pprof_test\.TestMemoryProfiler\+0x[0-9,a-f]+    .*/mprof_test.go:65
...

[Bug go/64683] FAIL: runtime/pprof -- testing.go:278: The entry did not match

[vries at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64683

--- Comment #9 from vries at gcc dot gnu.org ---
Created attachment 35010
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=35010&action=edit
libgo.log (nobootstrap build)

[Bug go/64683] FAIL: runtime/pprof -- testing.go:278: The entry did not match

[boger at us dot ibm.com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64683

boger at us dot ibm.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |boger at us dot ibm.com

--- Comment #10 from boger at us dot ibm.com ---
I see this same failure on ppc64le & ppc64.  

I found that this particular failure started with commit id 221230.  It passes
with commit id 220481.

[Bug go/64683] FAIL: runtime/pprof -- testing.go:278: The entry did not match

[ian at airs dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64683

--- Comment #11 from Ian Lance Taylor <ian at airs dot com> ---
This bug may have the same symptoms but it has a completely different cause. 
Next time, please do not reopen the bug unless you are certain it has the same
cause.  Please open a new bug instead.  Thanks.

The immediate cause of this problem is PR 65797.  That bug is causing
libbacktrace to fail to determine the name of the __go_make_slice1 function,
which causes the runtime/pprof package to fail to see that the stack frame is a
Go runtime stack frame which should not be reported, which causes the test to
fail because an extra unexpected stack frame is being reported.

[Bug go/64683] FAIL: runtime/pprof -- testing.go:278: The entry did not match

[boger at us dot ibm.com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64683

--- Comment #12 from boger at us dot ibm.com ---
Sorry I did not intend to reopen a closed bugzilla, I must not have looked
carefully enough and thought it was still open.  Just wanted to document what I
found since their log output was the same.  I will be more careful.

[Bug go/64683] FAIL: runtime/pprof -- testing.go:278: The entry did not match

[ian at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64683

--- Comment #14 from ian at gcc dot gnu.org <ian at gcc dot gnu.org> ---
Author: ian
Date: Fri Apr 17 21:29:20 2015
New Revision: 222200

URL: https://gcc.gnu.org/viewcvs?rev=222200&root=gcc&view=rev
Log:
    PR go/64683
runtime/pprof: Assume function with no name is in runtime.

GCC PR 65797 causes some of the runtime functions to be
compiled with no name in the debug info.  This in turn causes
the runtime/pprof test to fail as reported in GCC PR 64683.

There are no good choices when a function has no name in the
debug info, but here we assume that if we see such a function
while reading the runtime functions, we assume that it is also
a runtime function.

Modified:
    trunk/libgo/go/runtime/pprof/pprof.go

[Bug go/64683] FAIL: runtime/pprof -- testing.go:278: The entry did not match

[ian at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64683

--- Comment #13 from ian at gcc dot gnu.org <ian at gcc dot gnu.org> ---
Author: ian
Date: Fri Apr 17 21:29:08 2015
New Revision: 222199

URL: https://gcc.gnu.org/viewcvs?rev=222199&root=gcc&view=rev
Log:
    PR go/64683
runtime/pprof: Assume function with no name is in runtime.

GCC PR 65797 causes some of the runtime functions to be
compiled with no name in the debug info.  This in turn causes
the runtime/pprof test to fail as reported in GCC PR 64683.

There are no good choices when a function has no name in the
debug info, but here we assume that if we see such a function
while reading the runtime functions, we assume that it is also
a runtime function.

Modified:
    branches/gcc-5-branch/libgo/go/runtime/pprof/pprof.go

[Bug go/64683] FAIL: runtime/pprof -- testing.go:278: The entry did not match

[ian at airs dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64683

Ian Lance Taylor <ian at airs dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #15 from Ian Lance Taylor <ian at airs dot com> ---
Workaround committed.  This should no longer be a problem.