public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug libgomp/64707] FAIL: libgomp.c/target-9.c with -ftree-parallelize-loops=0
       [not found] <bug-64707-4@http.gcc.gnu.org/bugzilla/>
@ 2015-01-21 11:23 ` vries at gcc dot gnu.org
  2015-01-21 11:39 ` jakub at gcc dot gnu.org
                   ` (5 subsequent siblings)
  6 siblings, 0 replies; 7+ messages in thread
From: vries at gcc dot gnu.org @ 2015-01-21 11:23 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64707

--- Comment #1 from vries at gcc dot gnu.org ---
Created attachment 34512
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=34512&action=edit
tentative patch


^ permalink raw reply	[flat|nested] 7+ messages in thread

* [Bug libgomp/64707] FAIL: libgomp.c/target-9.c with -ftree-parallelize-loops=0
       [not found] <bug-64707-4@http.gcc.gnu.org/bugzilla/>
  2015-01-21 11:23 ` [Bug libgomp/64707] FAIL: libgomp.c/target-9.c with -ftree-parallelize-loops=0 vries at gcc dot gnu.org
@ 2015-01-21 11:39 ` jakub at gcc dot gnu.org
  2015-01-21 12:44 ` vries at gcc dot gnu.org
                   ` (4 subsequent siblings)
  6 siblings, 0 replies; 7+ messages in thread
From: jakub at gcc dot gnu.org @ 2015-01-21 11:39 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64707

--- Comment #2 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Wouldn't it be better to just add || flag_ltrans || flag_wpa to the GOMP/GOACC
builtin guard conditions?
I mean, relying on global flags here when they are combined from many sources,
where some may be compiled with that option and others with different option is
problematic.


^ permalink raw reply	[flat|nested] 7+ messages in thread

* [Bug libgomp/64707] FAIL: libgomp.c/target-9.c with -ftree-parallelize-loops=0
       [not found] <bug-64707-4@http.gcc.gnu.org/bugzilla/>
  2015-01-21 11:23 ` [Bug libgomp/64707] FAIL: libgomp.c/target-9.c with -ftree-parallelize-loops=0 vries at gcc dot gnu.org
  2015-01-21 11:39 ` jakub at gcc dot gnu.org
@ 2015-01-21 12:44 ` vries at gcc dot gnu.org
  2015-01-22 22:10 ` vries at gcc dot gnu.org
                   ` (3 subsequent siblings)
  6 siblings, 0 replies; 7+ messages in thread
From: vries at gcc dot gnu.org @ 2015-01-21 12:44 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64707

--- Comment #3 from vries at gcc dot gnu.org ---
Created attachment 34515
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=34515&action=edit
tentative patch, adding flag_ltrans || flag_wpa to the GOMP builtin guard
conditions

(In reply to Jakub Jelinek from comment #2)
> Wouldn't it be better to just add || flag_ltrans || flag_wpa to the
> GOMP/GOACC builtin guard conditions?
> I mean, relying on global flags here when they are combined from many
> sources, where some may be compiled with that option and others with
> different option is problematic.

Yes, that works as well, and I agree, it's better. Thanks.


^ permalink raw reply	[flat|nested] 7+ messages in thread

* [Bug libgomp/64707] FAIL: libgomp.c/target-9.c with -ftree-parallelize-loops=0
       [not found] <bug-64707-4@http.gcc.gnu.org/bugzilla/>
                   ` (2 preceding siblings ...)
  2015-01-21 12:44 ` vries at gcc dot gnu.org
@ 2015-01-22 22:10 ` vries at gcc dot gnu.org
  2015-01-23 10:12 ` vries at gcc dot gnu.org
                   ` (2 subsequent siblings)
  6 siblings, 0 replies; 7+ messages in thread
From: vries at gcc dot gnu.org @ 2015-01-22 22:10 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64707

--- Comment #4 from vries at gcc dot gnu.org ---
Created attachment 34535
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=34535&action=edit
tentative patch, makes fopenmp an LTO option, adds lto-wrapper handling


^ permalink raw reply	[flat|nested] 7+ messages in thread

* [Bug libgomp/64707] FAIL: libgomp.c/target-9.c with -ftree-parallelize-loops=0
       [not found] <bug-64707-4@http.gcc.gnu.org/bugzilla/>
                   ` (3 preceding siblings ...)
  2015-01-22 22:10 ` vries at gcc dot gnu.org
@ 2015-01-23 10:12 ` vries at gcc dot gnu.org
  2015-01-23 12:54 ` vries at gcc dot gnu.org
  2015-01-23 15:50 ` [Bug lto/64707] " vries at gcc dot gnu.org
  6 siblings, 0 replies; 7+ messages in thread
From: vries at gcc dot gnu.org @ 2015-01-23 10:12 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64707

vries at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
   Last reconfirmed|                            |2015-01-23
           Assignee|unassigned at gcc dot gnu.org      |vries at gcc dot gnu.org
     Ever confirmed|0                           |1


^ permalink raw reply	[flat|nested] 7+ messages in thread

* [Bug libgomp/64707] FAIL: libgomp.c/target-9.c with -ftree-parallelize-loops=0
       [not found] <bug-64707-4@http.gcc.gnu.org/bugzilla/>
                   ` (4 preceding siblings ...)
  2015-01-23 10:12 ` vries at gcc dot gnu.org
@ 2015-01-23 12:54 ` vries at gcc dot gnu.org
  2015-01-23 15:50 ` [Bug lto/64707] " vries at gcc dot gnu.org
  6 siblings, 0 replies; 7+ messages in thread
From: vries at gcc dot gnu.org @ 2015-01-23 12:54 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64707

--- Comment #5 from vries at gcc dot gnu.org ---
Author: vries
Date: Fri Jan 23 12:53:55 2015
New Revision: 220037

URL: https://gcc.gnu.org/viewcvs?rev=220037&root=gcc&view=rev
Log:
Make fopenmp an LTO option

2015-01-23  Tom de Vries  <tom@codesourcery.com>

    PR libgomp/64707
    * lto-opts.c (lto_write_options): Output non-explicit conservative
    -fno-openmp.
    * lto-wrapper.c (merge_and_complain): Handle merging -fopenmp.
    (append_compiler_options): Pass -fopenmp through.

    * c.opt (fopenmp): Mark as LTO option.

    * lang.opt (fopenmp): Mark as LTO option.

    * testsuite/libgomp.c/target-9.c: Add -ftree-parallelize-loops=0 to
    dg-options.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/c-family/ChangeLog
    trunk/gcc/c-family/c.opt
    trunk/gcc/fortran/ChangeLog
    trunk/gcc/fortran/lang.opt
    trunk/gcc/lto-opts.c
    trunk/gcc/lto-wrapper.c
    trunk/libgomp/ChangeLog
    trunk/libgomp/testsuite/libgomp.c/target-9.c


^ permalink raw reply	[flat|nested] 7+ messages in thread

* [Bug lto/64707] FAIL: libgomp.c/target-9.c with -ftree-parallelize-loops=0
       [not found] <bug-64707-4@http.gcc.gnu.org/bugzilla/>
                   ` (5 preceding siblings ...)
  2015-01-23 12:54 ` vries at gcc dot gnu.org
@ 2015-01-23 15:50 ` vries at gcc dot gnu.org
  6 siblings, 0 replies; 7+ messages in thread
From: vries at gcc dot gnu.org @ 2015-01-23 15:50 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64707

vries at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |ice-on-valid-code, lto,
                   |                            |openmp
             Status|ASSIGNED                    |RESOLVED
          Component|libgomp                     |lto
         Resolution|---                         |FIXED

--- Comment #6 from vries at gcc dot gnu.org ---
patch and test-case update committed. Marking resolved-fixed.


^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2015-01-23 15:50 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <bug-64707-4@http.gcc.gnu.org/bugzilla/>
2015-01-21 11:23 ` [Bug libgomp/64707] FAIL: libgomp.c/target-9.c with -ftree-parallelize-loops=0 vries at gcc dot gnu.org
2015-01-21 11:39 ` jakub at gcc dot gnu.org
2015-01-21 12:44 ` vries at gcc dot gnu.org
2015-01-22 22:10 ` vries at gcc dot gnu.org
2015-01-23 10:12 ` vries at gcc dot gnu.org
2015-01-23 12:54 ` vries at gcc dot gnu.org
2015-01-23 15:50 ` [Bug lto/64707] " vries at gcc dot gnu.org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).