public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug sanitizer/64906] New: -fsanitize=integer-divide-by-zero creates false -Wmaybe-uninitialized warning
@ 2015-02-02 18:25 sirl at gcc dot gnu.org
2015-09-21 13:52 ` [Bug sanitizer/64906] " mpolacek at gcc dot gnu.org
` (5 more replies)
0 siblings, 6 replies; 7+ messages in thread
From: sirl at gcc dot gnu.org @ 2015-02-02 18:25 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64906
Bug ID: 64906
Summary: -fsanitize=integer-divide-by-zero creates false
-Wmaybe-uninitialized warning
Product: gcc
Version: 5.0
Status: UNCONFIRMED
Severity: normal
Priority: P3
Component: sanitizer
Assignee: unassigned at gcc dot gnu.org
Reporter: sirl at gcc dot gnu.org
CC: dodji at gcc dot gnu.org, dvyukov at gcc dot gnu.org,
jakub at gcc dot gnu.org, kcc at gcc dot gnu.org
This testcase produces a false warning when compiled with -O2
-fsanitize=integer-divide-by-zero -Wmaybe-uninitialized:
struct s {
__SIZE_TYPE__ size;
unsigned int flags;
};
int testf(struct s * source)
{
__SIZE_TYPE__ msize = 0;
if ((source->flags & 88) ? (__SIZE_TYPE__) 43 * 8 : 0)
msize = source->size / ((source->flags & 88) ? (__SIZE_TYPE__) 43 * 8:
0);
return msize;
}
test.c: In function 'testf':
test.c:11:8: warning: 'iftmp.1' may be used uninitialized in this function
[-Wmaybe-uninitialized]
msize = source->size / ((source->flags & 88) ? (__SIZE_TYPE__) 43 * 8: 0);
^
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug sanitizer/64906] -fsanitize=integer-divide-by-zero creates false -Wmaybe-uninitialized warning
2015-02-02 18:25 [Bug sanitizer/64906] New: -fsanitize=integer-divide-by-zero creates false -Wmaybe-uninitialized warning sirl at gcc dot gnu.org
@ 2015-09-21 13:52 ` mpolacek at gcc dot gnu.org
2015-09-22 13:21 ` mpolacek at gcc dot gnu.org
` (4 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: mpolacek at gcc dot gnu.org @ 2015-09-21 13:52 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64906
Marek Polacek <mpolacek at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |ASSIGNED
Last reconfirmed| |2015-09-21
CC| |mpolacek at gcc dot gnu.org
Assignee|unassigned at gcc dot gnu.org |mpolacek at gcc dot gnu.org
Target Milestone|--- |5.3
Ever confirmed|0 |1
--- Comment #1 from Marek Polacek <mpolacek at gcc dot gnu.org> ---
I'll have a look.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug sanitizer/64906] -fsanitize=integer-divide-by-zero creates false -Wmaybe-uninitialized warning
2015-02-02 18:25 [Bug sanitizer/64906] New: -fsanitize=integer-divide-by-zero creates false -Wmaybe-uninitialized warning sirl at gcc dot gnu.org
2015-09-21 13:52 ` [Bug sanitizer/64906] " mpolacek at gcc dot gnu.org
@ 2015-09-22 13:21 ` mpolacek at gcc dot gnu.org
2015-09-22 14:06 ` mpolacek at gcc dot gnu.org
` (3 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: mpolacek at gcc dot gnu.org @ 2015-09-22 13:21 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64906
--- Comment #2 from Marek Polacek <mpolacek at gcc dot gnu.org> ---
int
testf (int f, int s)
{
int ret = 0;
if (f)
ret = s / (f ? (unsigned long) 8 : 0);
return ret;
}
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug sanitizer/64906] -fsanitize=integer-divide-by-zero creates false -Wmaybe-uninitialized warning
2015-02-02 18:25 [Bug sanitizer/64906] New: -fsanitize=integer-divide-by-zero creates false -Wmaybe-uninitialized warning sirl at gcc dot gnu.org
2015-09-21 13:52 ` [Bug sanitizer/64906] " mpolacek at gcc dot gnu.org
2015-09-22 13:21 ` mpolacek at gcc dot gnu.org
@ 2015-09-22 14:06 ` mpolacek at gcc dot gnu.org
2015-09-25 9:51 ` mpolacek at gcc dot gnu.org
` (2 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: mpolacek at gcc dot gnu.org @ 2015-09-22 14:06 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64906
--- Comment #3 from Marek Polacek <mpolacek at gcc dot gnu.org> ---
I'm testing a fix.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug sanitizer/64906] -fsanitize=integer-divide-by-zero creates false -Wmaybe-uninitialized warning
2015-02-02 18:25 [Bug sanitizer/64906] New: -fsanitize=integer-divide-by-zero creates false -Wmaybe-uninitialized warning sirl at gcc dot gnu.org
` (2 preceding siblings ...)
2015-09-22 14:06 ` mpolacek at gcc dot gnu.org
@ 2015-09-25 9:51 ` mpolacek at gcc dot gnu.org
2015-09-25 10:46 ` mpolacek at gcc dot gnu.org
2015-09-25 10:47 ` mpolacek at gcc dot gnu.org
5 siblings, 0 replies; 7+ messages in thread
From: mpolacek at gcc dot gnu.org @ 2015-09-25 9:51 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64906
--- Comment #4 from Marek Polacek <mpolacek at gcc dot gnu.org> ---
Author: mpolacek
Date: Fri Sep 25 09:50:29 2015
New Revision: 228112
URL: https://gcc.gnu.org/viewcvs?rev=228112&root=gcc&view=rev
Log:
PR sanitizer/64906
* c-ubsan.c (ubsan_instrument_division): Also pre-evaluate OP1.
* c-c++-common/ubsan/pr64906.c: New test.
Added:
trunk/gcc/testsuite/c-c++-common/ubsan/pr64906.c
Modified:
trunk/gcc/c-family/ChangeLog
trunk/gcc/c-family/c-ubsan.c
trunk/gcc/testsuite/ChangeLog
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug sanitizer/64906] -fsanitize=integer-divide-by-zero creates false -Wmaybe-uninitialized warning
2015-02-02 18:25 [Bug sanitizer/64906] New: -fsanitize=integer-divide-by-zero creates false -Wmaybe-uninitialized warning sirl at gcc dot gnu.org
` (3 preceding siblings ...)
2015-09-25 9:51 ` mpolacek at gcc dot gnu.org
@ 2015-09-25 10:46 ` mpolacek at gcc dot gnu.org
2015-09-25 10:47 ` mpolacek at gcc dot gnu.org
5 siblings, 0 replies; 7+ messages in thread
From: mpolacek at gcc dot gnu.org @ 2015-09-25 10:46 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64906
--- Comment #5 from Marek Polacek <mpolacek at gcc dot gnu.org> ---
Author: mpolacek
Date: Fri Sep 25 10:46:03 2015
New Revision: 228113
URL: https://gcc.gnu.org/viewcvs?rev=228113&root=gcc&view=rev
Log:
PR sanitizer/64906
* c-ubsan.c (ubsan_instrument_division): Also pre-evaluate OP1.
* c-c++-common/ubsan/pr64906.c: New test.
Added:
branches/gcc-5-branch/gcc/testsuite/c-c++-common/ubsan/pr64906.c
Modified:
branches/gcc-5-branch/gcc/c-family/ChangeLog
branches/gcc-5-branch/gcc/c-family/c-ubsan.c
branches/gcc-5-branch/gcc/testsuite/ChangeLog
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug sanitizer/64906] -fsanitize=integer-divide-by-zero creates false -Wmaybe-uninitialized warning
2015-02-02 18:25 [Bug sanitizer/64906] New: -fsanitize=integer-divide-by-zero creates false -Wmaybe-uninitialized warning sirl at gcc dot gnu.org
` (4 preceding siblings ...)
2015-09-25 10:46 ` mpolacek at gcc dot gnu.org
@ 2015-09-25 10:47 ` mpolacek at gcc dot gnu.org
5 siblings, 0 replies; 7+ messages in thread
From: mpolacek at gcc dot gnu.org @ 2015-09-25 10:47 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64906
Marek Polacek <mpolacek at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution|--- |FIXED
--- Comment #6 from Marek Polacek <mpolacek at gcc dot gnu.org> ---
Fixed.
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2015-09-25 10:47 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-02-02 18:25 [Bug sanitizer/64906] New: -fsanitize=integer-divide-by-zero creates false -Wmaybe-uninitialized warning sirl at gcc dot gnu.org
2015-09-21 13:52 ` [Bug sanitizer/64906] " mpolacek at gcc dot gnu.org
2015-09-22 13:21 ` mpolacek at gcc dot gnu.org
2015-09-22 14:06 ` mpolacek at gcc dot gnu.org
2015-09-25 9:51 ` mpolacek at gcc dot gnu.org
2015-09-25 10:46 ` mpolacek at gcc dot gnu.org
2015-09-25 10:47 ` mpolacek at gcc dot gnu.org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).