[Bug libgomp/65742] New: [5 Regression] Several libgomp.oacc-* failures after r221922.

[Bug libgomp/65742] New: [5 Regression] Several libgomp.oacc-* failures after r221922.

[dominiq at lps dot ens.fr]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65742

            Bug ID: 65742
           Summary: [5 Regression] Several libgomp.oacc-* failures after
                    r221922.
           Product: gcc
           Version: 5.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: libgomp
          Assignee: unassigned at gcc dot gnu.org
          Reporter: dominiq at lps dot ens.fr
                CC: jakub at gcc dot gnu.org, jules at gcc dot gnu.org

There are now several failures for libgomp.oacc-* tests after r221922 (see
https://gcc.gnu.org/ml/gcc-testresults/2015-04/msg00852.html, r221921 is OK,
see https://gcc.gnu.org/ml/gcc-testresults/2015-04/msg00837.html)

FAIL: libgomp.oacc-c/../libgomp.oacc-c-c++-common/acc_on_device-1.c
-DACC_DEVICE_TYPE_host_nonshm=1 -DACC_MEM_SHARED=0 execution test
FAIL: libgomp.oacc-c/../libgomp.oacc-c-c++-common/if-1.c
-DACC_DEVICE_TYPE_host_nonshm=1 -DACC_MEM_SHARED=0 execution test
FAIL: libgomp.oacc-c++/../libgomp.oacc-c-c++-common/acc_on_device-1.c
-DACC_DEVICE_TYPE_host_nonshm=1 -DACC_MEM_SHARED=0 execution test
FAIL: libgomp.oacc-c++/../libgomp.oacc-c-c++-common/if-1.c
-DACC_DEVICE_TYPE_host_nonshm=1 -DACC_MEM_SHARED=0 execution test
FAIL: libgomp.oacc-fortran/acc_on_device-1-1.f90
-DACC_DEVICE_TYPE_host_nonshm=1 -DACC_MEM_SHARED=0  -O  execution test
FAIL: libgomp.oacc-fortran/acc_on_device-1-2.f -DACC_DEVICE_TYPE_host_nonshm=1
-DACC_MEM_SHARED=0  -O  execution test
FAIL: libgomp.oacc-fortran/acc_on_device-1-3.f -DACC_DEVICE_TYPE_host_nonshm=1
-DACC_MEM_SHARED=0  -O  execution test

Note that these failures would have been easier to spot if the results were not
polluted by pages of useless guality failures.

[Bug libgomp/65742] [5 Regression] Several libgomp.oacc-* failures after r221922.

[dominiq at lps dot ens.fr]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65742

Dominique d'Humieres <dominiq at lps dot ens.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2015-04-11
     Ever confirmed|0                           |1

--- Comment #1 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
Confirmed on x86_64-apple-darwin1*.

[Bug libgomp/65742] [5/6 Regression] Several libgomp.oacc-* failures after r221922.

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65742

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |5.0

[Bug libgomp/65742] [5/6 Regression] Several libgomp.oacc-* failures after r221922.

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65742

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |danglin at gcc dot gnu.org

--- Comment #3 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
*** Bug 65814 has been marked as a duplicate of this bug. ***

[Bug libgomp/65742] [5/6 Regression] Several libgomp.oacc-* failures after r221922.

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65742

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|5.0                         |5.2

--- Comment #4 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
GCC 5.1 has been released.

[Bug libgomp/65742] [5/6 Regression] Several libgomp.oacc-* failures after r221922.

[jules at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65742

--- Comment #5 from jules at gcc dot gnu.org ---
Author: jules
Date: Thu May 28 09:29:19 2015
New Revision: 223801

URL: https://gcc.gnu.org/viewcvs?rev=223801&root=gcc&view=rev
Log:
    PR libgomp/65742

    gcc/
    * builtins.c (expand_builtin_acc_on_device): Don't use open-coded
    sequence for !ACCEL_COMPILER.

    libgomp/
    * oacc-init.c (plugin/plugin-host.h): Include.
    (acc_on_device): Check whether we're in an offloaded region for
    host_nonshm
    plugin. Don't use __builtin_acc_on_device.
    * plugin/plugin-host.c (GOMP_OFFLOAD_openacc_parallel): Set
    nonshm_exec flag in thread-local data.
    (GOMP_OFFLOAD_openacc_create_thread_data): Allocate thread-local
    data for host_nonshm plugin.
    (GOMP_OFFLOAD_openacc_destroy_thread_data): Free thread-local data
    for host_nonshm plugin.
    * plugin/plugin-host.h: New.


Added:
    trunk/libgomp/plugin/plugin-host.h
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/builtins.c
    trunk/libgomp/ChangeLog
    trunk/libgomp/oacc-init.c
    trunk/libgomp/plugin/plugin-host.c

[Bug libgomp/65742] [5/6 Regression] Several libgomp.oacc-* failures after r221922.

[jules at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65742

--- Comment #6 from jules at gcc dot gnu.org ---
Author: jules
Date: Thu May 28 09:38:40 2015
New Revision: 223802

URL: https://gcc.gnu.org/viewcvs?rev=223802&root=gcc&view=rev
Log:
    PR libgomp/65742

    gcc/
    * builtins.c (expand_builtin_acc_on_device): Don't use open-coded
    sequence for !ACCEL_COMPILER.

    libgomp/
    * oacc-init.c (plugin/plugin-host.h): Include.
    (acc_on_device): Check whether we're in an offloaded region for
    host_nonshm
    plugin. Don't use __builtin_acc_on_device.
    * plugin/plugin-host.c (GOMP_OFFLOAD_openacc_parallel): Set
    nonshm_exec flag in thread-local data.
    (GOMP_OFFLOAD_openacc_create_thread_data): Allocate thread-local
    data for host_nonshm plugin.
    (GOMP_OFFLOAD_openacc_destroy_thread_data): Free thread-local data
    for host_nonshm plugin.
    * plugin/plugin-host.h: New.


Added:
    branches/gomp-4_0-branch/libgomp/plugin/plugin-host.h
Modified:
    branches/gomp-4_0-branch/gcc/ChangeLog.gomp
    branches/gomp-4_0-branch/gcc/builtins.c
    branches/gomp-4_0-branch/libgomp/ChangeLog.gomp
    branches/gomp-4_0-branch/libgomp/oacc-init.c
    branches/gomp-4_0-branch/libgomp/plugin/plugin-host.c

[Bug libgomp/65742] [5/6 Regression] Several libgomp.oacc-* failures after r221922.

[tschwinge at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65742

--- Comment #7 from Thomas Schwinge <tschwinge at gcc dot gnu.org> ---
Author: tschwinge
Date: Tue Jun  2 11:48:56 2015
New Revision: 224028

URL: https://gcc.gnu.org/viewcvs?rev=224028&root=gcc&view=rev
Log:
[PR libgomp/65742, PR middle-end/66332] XFAIL acc_on_device compile-time
evaluation

The OpenACC 2.0a specification mandates differently, but we currently do get a
library call in the host code.

        PR libgomp/65742
        PR middle-end/66332

        gcc/testsuite/
        * c-c++-common/goacc/acc_on_device-2.c: XFAIL for C, too.

Modified:
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/testsuite/c-c++-common/goacc/acc_on_device-2.c

[Bug libgomp/65742] [5 Regression] Several libgomp.oacc-* failures after r221922.

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65742

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P2
             Status|NEW                         |ASSIGNED
            Summary|[5/6 Regression] Several    |[5 Regression] Several
                   |libgomp.oacc-* failures     |libgomp.oacc-* failures
                   |after r221922.              |after r221922.

--- Comment #8 from Richard Biener <rguenth at gcc dot gnu.org> ---
Fixed on trunk - can you please fix the gcc 5 branch as well?

[Bug libgomp/65742] [5 Regression] Several libgomp.oacc-* failures after r221922.

[tschwinge at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65742

--- Comment #9 from Thomas Schwinge <tschwinge at gcc dot gnu.org> ---
Author: tschwinge
Date: Wed Jul 15 11:55:00 2015
New Revision: 225822

URL: https://gcc.gnu.org/viewcvs?rev=225822&root=gcc&view=rev
Log:
[PR libgomp/65742, PR middle-end/66332] OpenACC acc_on_device fixes

Backport trunk r223801:

    PR libgomp/65742

    gcc/
    * builtins.c (expand_builtin_acc_on_device): Don't use open-coded
    sequence for !ACCEL_COMPILER.

    libgomp/
    * oacc-init.c (plugin/plugin-host.h): Include.
    (acc_on_device): Check whether we're in an offloaded region for
    host_nonshm
    plugin. Don't use __builtin_acc_on_device.
    * plugin/plugin-host.c (GOMP_OFFLOAD_openacc_parallel): Set
    nonshm_exec flag in thread-local data.
    (GOMP_OFFLOAD_openacc_create_thread_data): Allocate thread-local
    data for host_nonshm plugin.
    (GOMP_OFFLOAD_openacc_destroy_thread_data): Free thread-local data
    for host_nonshm plugin.
    * plugin/plugin-host.h: New.

Mark parameters with ATTRIBUTE_UNUSED

Backport trunk r223805:

        * builtins.c (expand_builtin_acc_on_device): Mark parameters
        with ATTRIBUTE_UNUSED.

[PR libgomp/65742, PR middle-end/66332] XFAIL acc_on_device compile-time
evaluation

The OpenACC 2.0a specification mandates differently, but we currently do get a
library call in the host code.

Backport trunk r224028:

        PR libgomp/65742
        PR middle-end/66332

        gcc/testsuite/
        * c-c++-common/goacc/acc_on_device-2.c: XFAIL for C, too.

Added:
    branches/gcc-5-branch/libgomp/plugin/plugin-host.h
Modified:
    branches/gcc-5-branch/gcc/ChangeLog
    branches/gcc-5-branch/gcc/builtins.c
    branches/gcc-5-branch/gcc/testsuite/ChangeLog
    branches/gcc-5-branch/gcc/testsuite/c-c++-common/goacc/acc_on_device-2.c
    branches/gcc-5-branch/libgomp/ChangeLog
    branches/gcc-5-branch/libgomp/oacc-init.c
    branches/gcc-5-branch/libgomp/plugin/plugin-host.c

[Bug libgomp/65742] [5 Regression] Several libgomp.oacc-* failures after r221922.

[tschwinge at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65742

Thomas Schwinge <tschwinge at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED
           Assignee|jules at gcc dot gnu.org           |tschwinge at gcc dot gnu.org

--- Comment #10 from Thomas Schwinge <tschwinge at gcc dot gnu.org> ---
Now also fixed on gcc-5-branch.