public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug libstdc++/67361] New: std::regex_error::what() should say something about the error_code
@ 2015-08-26 16:22 redi at gcc dot gnu.org
  2015-08-27  3:08 ` [Bug libstdc++/67361] " timshen at gcc dot gnu.org
  2015-09-19 20:57 ` timshen at gcc dot gnu.org
  0 siblings, 2 replies; 3+ messages in thread
From: redi at gcc dot gnu.org @ 2015-08-26 16:22 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67361

            Bug ID: 67361
           Summary: std::regex_error::what() should say something about
                    the error_code
           Product: gcc
           Version: 4.9.4
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: libstdc++
          Assignee: unassigned at gcc dot gnu.org
          Reporter: redi at gcc dot gnu.org
  Target Milestone: ---

This would be more helpful if it included a string representation of the
error_code such as regex_constants::error_paren:

terminate called after throwing an instance of 'std::regex_error'
  what():  regex_error


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Bug libstdc++/67361] std::regex_error::what() should say something about the error_code
  2015-08-26 16:22 [Bug libstdc++/67361] New: std::regex_error::what() should say something about the error_code redi at gcc dot gnu.org
@ 2015-08-27  3:08 ` timshen at gcc dot gnu.org
  2015-09-19 20:57 ` timshen at gcc dot gnu.org
  1 sibling, 0 replies; 3+ messages in thread
From: timshen at gcc dot gnu.org @ 2015-08-27  3:08 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67361

Tim Shen <timshen at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |timshen at gcc dot gnu.org

--- Comment #1 from Tim Shen <timshen at gcc dot gnu.org> ---
(In reply to Jonathan Wakely from comment #0)
> This would be more helpful if it included a string representation of the
> error_code such as regex_constants::error_paren:
> 
> terminate called after throwing an instance of 'std::regex_error'
>   what():  regex_error

Would it be Ok to provide more specific, human readable error string? For
example, "Unexpected end of regex after a backslash".


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Bug libstdc++/67361] std::regex_error::what() should say something about the error_code
  2015-08-26 16:22 [Bug libstdc++/67361] New: std::regex_error::what() should say something about the error_code redi at gcc dot gnu.org
  2015-08-27  3:08 ` [Bug libstdc++/67361] " timshen at gcc dot gnu.org
@ 2015-09-19 20:57 ` timshen at gcc dot gnu.org
  1 sibling, 0 replies; 3+ messages in thread
From: timshen at gcc dot gnu.org @ 2015-09-19 20:57 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67361

--- Comment #3 from Tim Shen <timshen at gcc dot gnu.org> ---
Author: timshen
Date: Sat Sep 19 20:56:27 2015
New Revision: 227936

URL: https://gcc.gnu.org/viewcvs?rev=227936&root=gcc&view=rev
Log:
        PR libstdc++/67361
        * include/bits/regex_error.h: Add __throw_regex_error that
        supports string.
        * include/bits/regex_automaton.h: Add more specific exception
        messages.
        * include/bits/regex_automaton.tcc: Likewise.
        * include/bits/regex_compiler.h: Likewise.
        * include/bits/regex_compiler.tcc: Likewise.
        * include/bits/regex_scanner.h: Likewise.
        * include/bits/regex_scanner.tcc: Likewise.

Modified:
    trunk/libstdc++-v3/ChangeLog
    trunk/libstdc++-v3/include/bits/regex_automaton.h
    trunk/libstdc++-v3/include/bits/regex_automaton.tcc
    trunk/libstdc++-v3/include/bits/regex_compiler.h
    trunk/libstdc++-v3/include/bits/regex_compiler.tcc
    trunk/libstdc++-v3/include/bits/regex_error.h
    trunk/libstdc++-v3/include/bits/regex_scanner.tcc


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-09-19 20:57 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-08-26 16:22 [Bug libstdc++/67361] New: std::regex_error::what() should say something about the error_code redi at gcc dot gnu.org
2015-08-27  3:08 ` [Bug libstdc++/67361] " timshen at gcc dot gnu.org
2015-09-19 20:57 ` timshen at gcc dot gnu.org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).