[Bug target/67506] New: [SH][5]: error: unrecognizable insn when compiling texlive-binaries

[Bug target/67506] New: [SH][5]: error: unrecognizable insn when compiling texlive-binaries

[glaubitz at physik dot fu-berlin.de]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67506

            Bug ID: 67506
           Summary: [SH][5]: error: unrecognizable insn when compiling
                    texlive-binaries
           Product: gcc
           Version: unknown
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: target
          Assignee: unassigned at gcc dot gnu.org
          Reporter: glaubitz at physik dot fu-berlin.de
                CC: kkojima at gcc dot gnu.org, olegendo at gcc dot gnu.org
  Target Milestone: ---
            Target: sh*-*-*

Created attachment 36307
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=36307&action=edit
Preprocessed source for tftopl.c

Hello!

I just noticed that we run into a new regression which seems to have been
introduced with gcc-5.

The compiler output is as follows:

gcc -DHAVE_CONFIG_H -I. -I../../../texk/web2c -I./w2c 
-I/«PKGBUILDDIR»/Work/texk -I/«PKGBUILDDIR»/texk  -Wimplicit -Wreturn-type -g
-O2 -c -o tftopl.o tftopl.c
tftopl.c: In function 'mainbody':
tftopl.c:1808:1: error: unrecognizable insn:
 } 
 ^
(insn 9938 541 9939 36 (set (reg:SI 147 t)
        (eq:SI (and:SI (reg:HI 1069 [ *_271 ])
                (const_int 128 [0x80]))
            (const_int 0 [0]))) tftopl.c:1542 -1
     (nil))
tftopl.c:1808:1: internal compiler error: in extract_insn, at recog.c:2343
0x83edf3 _fatal_insn(char const*, rtx_def const*, char const*, int, char
const*)
        ../../src/gcc/rtl-error.c:110
0x83ee2d _fatal_insn_not_found(rtx_def const*, char const*, int, char const*)
        ../../src/gcc/rtl-error.c:118
0x8139dd extract_insn(rtx_insn*)
        ../../src/gcc/recog.c:2343
0xba62f3 decompose_multiword_subregs
        ../../src/gcc/lower-subreg.c:1502
0xba731f execute
        ../../src/gcc/lower-subreg.c:1772
Please submit a full bug report,
with preprocessed source if appropriate.
Please include the complete backtrace with any bug report.
See <file:///usr/share/doc/gcc-5/README.Bugs> for instructions.
Preprocessed source stored into /tmp/ccRGajx7.out file, please attach this to
your bugreport.

A full build log can be found in [1]. The build log of a previous, successful
build with gcc-4.9 can be found in [2]. I am attaching the preprocessed source
which is mentioned in the build log.

Adrian

> [1] https://buildd.debian.org/status/fetch.php?pkg=texlive-bin&arch=sh4&ver=2015.20150524.37493-6&stamp=1440539292
> [2] https://buildd.debian.org/status/fetch.php?pkg=texlive-bin&arch=sh4&ver=2015.20150524.37493-5&stamp=1437123205
>From gcc-bugs-return-496684-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Tue Sep 08 21:16:08 2015
Return-Path: <gcc-bugs-return-496684-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 7746 invoked by alias); 8 Sep 2015 21:16:08 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 7703 invoked by uid 48); 8 Sep 2015 21:16:05 -0000
From: "mpolacek at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c/64249] Missing warning for if (A) else if (A)
Date: Tue, 08 Sep 2015 21:16:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: c
X-Bugzilla-Version: 5.0
X-Bugzilla-Keywords: diagnostic
X-Bugzilla-Severity: normal
X-Bugzilla-Who: mpolacek at gcc dot gnu.org
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Resolution:
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: mpolacek at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 6.0
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: bug_status assigned_to target_milestone
Message-ID: <bug-64249-4-hObfmfZbWL@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-64249-4@http.gcc.gnu.org/bugzilla/>
References: <bug-64249-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2015-09/txt/msg00662.txt.bz2
Content-length: 563

https://gcc.gnu.org/bugzilla/show_bug.cgi?idd249

Marek Polacek <mpolacek at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|unassigned at gcc dot gnu.org      |mpolacek at gcc dot gnu.org
   Target Milestone|---                         |6.0

--- Comment #2 from Marek Polacek <mpolacek at gcc dot gnu.org> ---
I seem to have something that seemingly works for the C FE.

[Bug target/67506] [5/6 Regression][SH]: error: unrecognizable insn when compiling texlive-binaries

[kkojima at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67506

Kazumoto Kojima <kkojima at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |ice-on-valid-code
      Known to work|                            |4.9.4
            Summary|[SH][5]: error:             |[5/6 Regression][SH]:
                   |unrecognizable insn when    |error: unrecognizable insn
                   |compiling texlive-binaries  |when compiling
                   |                            |texlive-binaries
      Known to fail|                            |5.2.1, 6.0

--- Comment #1 from Kazumoto Kojima <kkojima at gcc dot gnu.org> ---
Cross trunk compiler fails with the same ICE.

[Bug target/67506] [5/6 Regression][SH]: error: unrecognizable insn when compiling texlive-binaries

[kkojima at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67506

--- Comment #2 from Kazumoto Kojima <kkojima at gcc dot gnu.org> ---
Created attachment 36309
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=36309&action=edit
reduced test case

It looks that some problem happens in tstsi_t splitter.
The insns before splitting are:

(insn 124 123 125 13 (set (reg:HI 262 [ *_48 ])
        (zero_extend:HI (reg:QI 263 [ *_48 ]))) tfoo.c:41 223
{zero_extendqihi2}
     (expr_list:REG_DEAD (reg:QI 263 [ *_48 ])
        (nil)))
(note 125 124 126 13 NOTE_INSN_DELETED)
(insn 126 125 127 13 (set (reg:SI 197 [ *_48 ])
        (zero_extend:SI (reg:HI 262 [ *_48 ]))) tfoo.c:42 220
{*zero_extendhisi2_compact}
     (nil))
(insn 127 126 128 13 (set (reg:SI 147 t)
        (zero_extract:SI (subreg:SI (reg:HI 262 [ *_48 ]) 0)
            (const_int 1 [0x1])
            (const_int 7 [0x7]))) tfoo.c:42 516 {*zero_extract_0}
     (nil))

and the last insn is splitted into

(insn 478 126 479 16 (set (reg:SI 147 t)
        (eq:SI (and:SI (subreg:SI (reg:HI 262 [ *_48 ]) 0)
                (const_int 128 [0x80]))
            (const_int 0 [0]))) tfoo.c:42 -1
     (nil))

with *zero_extract_0 splitter.  Then it seems that tstsi_t splitter
replaces (subreg:SI (reg:HI 262 [ *_48 ]) 0) with (reg:HI 262 [ *_48 ])
as the result of eop0.use_as_extended_reg and we got

(insn 480 126 481 16 (set (reg:SI 147 t)
        (eq:SI (and:SI (reg:HI 262 [ *_48 ])
                (const_int 128 [0x80]))
            (const_int 0 [0]))) tfoo.c:42 -1
     (nil))

Oleg, could you please look at this?

[Bug target/67506] [5/6 Regression][SH]: error: unrecognizable insn when compiling texlive-binaries

[olegendo at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67506

Oleg Endo <olegendo at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2015-09-09
     Ever confirmed|0                           |1

--- Comment #4 from Oleg Endo <olegendo at gcc dot gnu.org> ---
The 'sh_extending_set_of_reg' thing seems to be working OK in this case. 
However, the expected resulting reg is assumed to be SImode.  But for this insn
...

(insn 124 123 125 13 (set (reg:HI 262 [ *_48 ])
        (zero_extend:HI (reg:QI 263 [ *_48 ]))) tfoo.c:41 223
{zero_extendqihi2}
     (expr_list:REG_DEAD (reg:QI 263 [ *_48 ])
        (nil)))

... this is not the case (obviously it's HImode).
In the other function 'use_as_unextended_reg' I used 'simplify_gen_subreg'.  In
'use_as_extended_reg' I assumed that the extension is always towards SImode and
forgot to handle it.  It seems the following fixes it:

diff --git a/gcc/config/sh/sh.c b/gcc/config/sh/sh.c
index 5813a77..d5e1a21 100644
--- a/gcc/config/sh/sh.c
+++ b/gcc/config/sh/sh.c
@@ -14332,6 +14332,11 @@ sh_extending_set_of_reg::use_as_extended_reg
(rtx_insn* use_at_insn) const
   else
     {
       rtx extension_dst = XEXP (set_rtx, 0);
+
+      if (GET_MODE (extension_dst) != SImode)
+       extension_dst = simplify_gen_subreg (SImode, extension_dst,
+                                            GET_MODE (extension_dst), 0);
+
       if (modified_between_p (extension_dst, insn, use_at_insn))
        {
          if (dump_file)

Could you please test it?

[Bug target/67506] [5/6 Regression][SH]: error: unrecognizable insn when compiling texlive-binaries

[olegendo at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67506

--- Comment #6 from Oleg Endo <olegendo at gcc dot gnu.org> ---
(In reply to Kazumoto Kojima from comment #5)
> (In reply to Oleg Endo from comment #4)
> > Could you please test it?
> 
> It fixes all test cases for the cross trunk sh4-unknown-linux-gnu compiler.
> There is no new failures with the top level "make -k check".

Thanks.  I will commit it and add attachment 36309 as a c-torture test.

[Bug target/67506] [5/6 Regression][SH]: error: unrecognizable insn when compiling texlive-binaries

[olegendo at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67506

--- Comment #7 from Oleg Endo <olegendo at gcc dot gnu.org> ---
Author: olegendo
Date: Thu Sep 10 14:53:48 2015
New Revision: 227646

URL: https://gcc.gnu.org/viewcvs?rev=227646&root=gcc&view=rev
Log:
gcc/
        PR target/67506
        * config/sh/sh.c (sh_extending_set_of_reg::use_as_extended_reg): Add
        missing simplify_gen_subreg.

gcc/testsuite/
        PR target/67506
        * gcc.c-torture/compile/pr67506.c: New test.

Added:
    trunk/gcc/testsuite/gcc.c-torture/compile/pr67506.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/config/sh/sh.c
    trunk/gcc/testsuite/ChangeLog

[Bug target/67506] [5/6 Regression][SH]: error: unrecognizable insn when compiling texlive-binaries

[olegendo at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67506

--- Comment #8 from Oleg Endo <olegendo at gcc dot gnu.org> ---
Author: olegendo
Date: Thu Sep 10 15:07:02 2015
New Revision: 227647

URL: https://gcc.gnu.org/viewcvs?rev=227647&root=gcc&view=rev
Log:
gcc/
        Backport from mainline
        2015-09-10  Oleg Endo  <olegendo@gcc.gnu.org>

        PR target/67506
        * config/sh/sh.c (sh_extending_set_of_reg::use_as_extended_reg): Add
        missing simplify_gen_subreg.

gcc/testsuite/
        Backport from mainline
        PR target/67506
        * gcc.c-torture/compile/pr67506.c: New test.

Added:
    branches/gcc-5-branch/gcc/testsuite/gcc.c-torture/compile/pr67506.c
Modified:
    branches/gcc-5-branch/gcc/ChangeLog
    branches/gcc-5-branch/gcc/config/sh/sh.c
    branches/gcc-5-branch/gcc/testsuite/ChangeLog

[Bug target/67506] [5/6 Regression][SH]: error: unrecognizable insn when compiling texlive-binaries

[glaubitz at physik dot fu-berlin.de]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67506

--- Comment #9 from John Paul Adrian Glaubitz <glaubitz at physik dot fu-berlin.de> ---
(In reply to Oleg Endo from comment #6)
> Thanks.  I will commit it and add attachment 36309 [details] as a c-torture
> test.

Thanks for the quick bug fix! Matthias already uploaded a new gcc-5 snapshot
today which contains the fix :).

Adrian

[Bug target/67506] [5/6 Regression][SH]: error: unrecognizable insn when compiling texlive-binaries

[olegendo at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67506

--- Comment #10 from Oleg Endo <olegendo at gcc dot gnu.org> ---
(In reply to John Paul Adrian Glaubitz from comment #9)
> 
> Thanks for the quick bug fix! Matthias already uploaded a new gcc-5 snapshot
> today which contains the fix :).

I guess it will take a while until you've got a new GCC build.  I think we can
close this as fixed?

[Bug target/67506] [5/6 Regression][SH]: error: unrecognizable insn when compiling texlive-binaries

[glaubitz at physik dot fu-berlin.de]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67506

--- Comment #11 from John Paul Adrian Glaubitz <glaubitz at physik dot fu-berlin.de> ---
(In reply to Oleg Endo from comment #10)
> I guess it will take a while until you've got a new GCC build.  I think we
> can close this as fixed?

texlive-bin builds fine with the new gcc-5 snapshot [1], thus this PR can be
closed as fixed.

Cheers,

Adrian

> [1] https://buildd.debian.org/status/fetch.php?pkg=texlive-bin&arch=sh4&ver=2015.20150524.37493-6&stamp=1442627466

[Bug target/67506] [5/6 Regression][SH]: error: unrecognizable insn when compiling texlive-binaries

[olegendo at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67506

Oleg Endo <olegendo at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #12 from Oleg Endo <olegendo at gcc dot gnu.org> ---
(In reply to John Paul Adrian Glaubitz from comment #11)
> 
> texlive-bin builds fine with the new gcc-5 snapshot [1], thus this PR can be
> closed as fixed.
>

Thanks for reporting back.