public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug c/70418] VM structure type specifier in list of parameter declarations within nested function definition ices.
[not found] <bug-70418-4@http.gcc.gnu.org/bugzilla/>
@ 2023-05-19 20:52 ` muecker at gwdg dot de
2023-05-19 20:55 ` muecker at gwdg dot de
` (2 subsequent siblings)
3 siblings, 0 replies; 4+ messages in thread
From: muecker at gwdg dot de @ 2023-05-19 20:52 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70418
Martin Uecker <muecker at gwdg dot de> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |muecker at gwdg dot de
--- Comment #7 from Martin Uecker <muecker at gwdg dot de> ---
*** Bug 106465 has been marked as a duplicate of this bug. ***
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Bug c/70418] VM structure type specifier in list of parameter declarations within nested function definition ices.
[not found] <bug-70418-4@http.gcc.gnu.org/bugzilla/>
2023-05-19 20:52 ` [Bug c/70418] VM structure type specifier in list of parameter declarations within nested function definition ices muecker at gwdg dot de
@ 2023-05-19 20:55 ` muecker at gwdg dot de
2023-05-23 20:05 ` cvs-commit at gcc dot gnu.org
2023-11-03 19:38 ` uecker at gcc dot gnu.org
3 siblings, 0 replies; 4+ messages in thread
From: muecker at gwdg dot de @ 2023-05-19 20:55 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70418
--- Comment #8 from Martin Uecker <muecker at gwdg dot de> ---
https://gcc.gnu.org/pipermail/gcc-patches/2023-May/618911.html
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Bug c/70418] VM structure type specifier in list of parameter declarations within nested function definition ices.
[not found] <bug-70418-4@http.gcc.gnu.org/bugzilla/>
2023-05-19 20:52 ` [Bug c/70418] VM structure type specifier in list of parameter declarations within nested function definition ices muecker at gwdg dot de
2023-05-19 20:55 ` muecker at gwdg dot de
@ 2023-05-23 20:05 ` cvs-commit at gcc dot gnu.org
2023-11-03 19:38 ` uecker at gcc dot gnu.org
3 siblings, 0 replies; 4+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2023-05-23 20:05 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70418
--- Comment #9 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Martin Uecker <uecker@gcc.gnu.org>:
https://gcc.gnu.org/g:f9b5be322358ee63798e02a9103b6bbe459e7aea
commit r14-1142-gf9b5be322358ee63798e02a9103b6bbe459e7aea
Author: Martin Uecker <uecker@tugraz.at>
Date: Thu Apr 13 19:37:12 2023 +0200
Fix ICEs related to VM types in C 1/2 [PR70418, PR107557, PR108423]
Size expressions were sometimes lost and not gimplified correctly, leading
to
ICEs and incorrect evaluation order. Fix this by 1) not recursing into
pointers when gimplifying parameters in the middle-end (the code is merged
with
gimplify_type_sizes), which is incorrect because it might access variables
declared later for incomplete structs, and 2) tracking size expressions for
struct/union members correctly, 3) emitting code to evaluate size
expressions
for missing cases (nested functions, empty declarations, and
structs/unions).
PR c/70418
PR c/106465
PR c/107557
PR c/108423
gcc/c/
* c-decl.cc (start_decl): Make sure size expression are
evaluated only in correct context.
(grokdeclarator): Size expression in fields may need a bind
expression, make sure DECL_EXPR is always created.
(grokfield, declspecs_add_type): Pass along size expressions.
(finish_struct): Remove unneeded DECL_EXPR.
(start_function): Evaluate size expressions for nested functions.
* c-parser.cc (c_parser_struct_declarations,
c_parser_struct_or_union_specifier): Pass along size expressions.
(c_parser_declaration_or_fndef): Evaluate size expression.
(c_parser_objc_at_property_declaration,
c_parser_objc_class_instance_variables): Adapt.
* c-tree.h (grokfield): Adapt declaration.
gcc/testsuite/
* gcc.dg/nested-vla-1.c: New test.
* gcc.dg/nested-vla-2.c: New test.
* gcc.dg/nested-vla-3.c: New test.
* gcc.dg/pr70418.c: New test.
* gcc.dg/pr106465.c: New test.
* gcc.dg/pr107557-1.c: New test.
* gcc.dg/pr107557-2.c: New test.
* gcc.dg/pr108423-1.c: New test.
* gcc.dg/pr108423-2.c: New test.
* gcc.dg/pr108423-3.c: New test.
* gcc.dg/pr108423-4.c: New test.
* gcc.dg/pr108423-5.c: New test.
* gcc.dg/pr108423-6.c: New test.
* gcc.dg/typename-vla-2.c: New test.
* gcc.dg/typename-vla-3.c: New test.
* gcc.dg/typename-vla-4.c: New test.
* gcc.misc-tests/gcov-pr85350.c: Adapt.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Bug c/70418] VM structure type specifier in list of parameter declarations within nested function definition ices.
[not found] <bug-70418-4@http.gcc.gnu.org/bugzilla/>
` (2 preceding siblings ...)
2023-05-23 20:05 ` cvs-commit at gcc dot gnu.org
@ 2023-11-03 19:38 ` uecker at gcc dot gnu.org
3 siblings, 0 replies; 4+ messages in thread
From: uecker at gcc dot gnu.org @ 2023-11-03 19:38 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70418
uecker at gcc dot gnu.org changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |uecker at gcc dot gnu.org
Resolution|--- |FIXED
Target Milestone|--- |14.0
Status|NEW |RESOLVED
Known to fail| |6.0
--- Comment #10 from uecker at gcc dot gnu.org ---
Fixed on trunk.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-11-03 19:38 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <bug-70418-4@http.gcc.gnu.org/bugzilla/>
2023-05-19 20:52 ` [Bug c/70418] VM structure type specifier in list of parameter declarations within nested function definition ices muecker at gwdg dot de
2023-05-19 20:55 ` muecker at gwdg dot de
2023-05-23 20:05 ` cvs-commit at gcc dot gnu.org
2023-11-03 19:38 ` uecker at gcc dot gnu.org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).