* [Bug libstdc++/71367] std::time_get does not implement 'r' or 'p'
[not found] <bug-71367-4@http.gcc.gnu.org/bugzilla/>
@ 2020-05-07 11:56 ` jakub at gcc dot gnu.org
2020-05-07 12:39 ` redi at gcc dot gnu.org
` (7 subsequent siblings)
8 siblings, 0 replies; 9+ messages in thread
From: jakub at gcc dot gnu.org @ 2020-05-07 11:56 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=71367
Jakub Jelinek <jakub at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|10.0 |10.2
--- Comment #5 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
GCC 10.1 has been released.
^ permalink raw reply [flat|nested] 9+ messages in thread* [Bug libstdc++/71367] std::time_get does not implement 'r' or 'p'
[not found] <bug-71367-4@http.gcc.gnu.org/bugzilla/>
2020-05-07 11:56 ` [Bug libstdc++/71367] std::time_get does not implement 'r' or 'p' jakub at gcc dot gnu.org
@ 2020-05-07 12:39 ` redi at gcc dot gnu.org
2021-04-19 10:40 ` redi at gcc dot gnu.org
` (6 subsequent siblings)
8 siblings, 0 replies; 9+ messages in thread
From: redi at gcc dot gnu.org @ 2020-05-07 12:39 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=71367
Jonathan Wakely <redi at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|10.2 |11.0
^ permalink raw reply [flat|nested] 9+ messages in thread* [Bug libstdc++/71367] std::time_get does not implement 'r' or 'p'
[not found] <bug-71367-4@http.gcc.gnu.org/bugzilla/>
2020-05-07 11:56 ` [Bug libstdc++/71367] std::time_get does not implement 'r' or 'p' jakub at gcc dot gnu.org
2020-05-07 12:39 ` redi at gcc dot gnu.org
@ 2021-04-19 10:40 ` redi at gcc dot gnu.org
2021-04-27 11:37 ` jakub at gcc dot gnu.org
` (5 subsequent siblings)
8 siblings, 0 replies; 9+ messages in thread
From: redi at gcc dot gnu.org @ 2021-04-19 10:40 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=71367
Jonathan Wakely <redi at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|redi at gcc dot gnu.org |unassigned at gcc dot gnu.org
Status|ASSIGNED |NEW
^ permalink raw reply [flat|nested] 9+ messages in thread* [Bug libstdc++/71367] std::time_get does not implement 'r' or 'p'
[not found] <bug-71367-4@http.gcc.gnu.org/bugzilla/>
` (2 preceding siblings ...)
2021-04-19 10:40 ` redi at gcc dot gnu.org
@ 2021-04-27 11:37 ` jakub at gcc dot gnu.org
2021-06-30 3:34 ` xry111 at mengyan1223 dot wang
` (4 subsequent siblings)
8 siblings, 0 replies; 9+ messages in thread
From: jakub at gcc dot gnu.org @ 2021-04-27 11:37 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=71367
Jakub Jelinek <jakub at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|11.0 |11.2
--- Comment #6 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
GCC 11.1 has been released, retargeting bugs to GCC 11.2.
^ permalink raw reply [flat|nested] 9+ messages in thread* [Bug libstdc++/71367] std::time_get does not implement 'r' or 'p'
[not found] <bug-71367-4@http.gcc.gnu.org/bugzilla/>
` (3 preceding siblings ...)
2021-04-27 11:37 ` jakub at gcc dot gnu.org
@ 2021-06-30 3:34 ` xry111 at mengyan1223 dot wang
2021-06-30 10:30 ` redi at gcc dot gnu.org
` (3 subsequent siblings)
8 siblings, 0 replies; 9+ messages in thread
From: xry111 at mengyan1223 dot wang @ 2021-06-30 3:34 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=71367
--- Comment #7 from Xi Ruoyao <xry111 at mengyan1223 dot wang> ---
Any progress on this (after two years? :)
^ permalink raw reply [flat|nested] 9+ messages in thread* [Bug libstdc++/71367] std::time_get does not implement 'r' or 'p'
[not found] <bug-71367-4@http.gcc.gnu.org/bugzilla/>
` (4 preceding siblings ...)
2021-06-30 3:34 ` xry111 at mengyan1223 dot wang
@ 2021-06-30 10:30 ` redi at gcc dot gnu.org
2021-12-10 16:05 ` cvs-commit at gcc dot gnu.org
` (2 subsequent siblings)
8 siblings, 0 replies; 9+ messages in thread
From: redi at gcc dot gnu.org @ 2021-06-30 10:30 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=71367
Jonathan Wakely <redi at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|11.2 |---
--- Comment #8 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Nope.
^ permalink raw reply [flat|nested] 9+ messages in thread* [Bug libstdc++/71367] std::time_get does not implement 'r' or 'p'
[not found] <bug-71367-4@http.gcc.gnu.org/bugzilla/>
` (5 preceding siblings ...)
2021-06-30 10:30 ` redi at gcc dot gnu.org
@ 2021-12-10 16:05 ` cvs-commit at gcc dot gnu.org
2021-12-10 16:16 ` jakub at gcc dot gnu.org
2021-12-15 0:44 ` redi at gcc dot gnu.org
8 siblings, 0 replies; 9+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2021-12-10 16:05 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=71367
--- Comment #9 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>:
https://gcc.gnu.org/g:982a2c9b7866558039df61b0596caad57c94c8c4
commit r12-5899-g982a2c9b7866558039df61b0596caad57c94c8c4
Author: Jakub Jelinek <jakub@redhat.com>
Date: Fri Dec 10 17:05:04 2021 +0100
libstdc++: Add std::time_get %r support [PR71367]
This incremental patch adds std::time_get %r support (%p was added already
in the previous patch). The _M_am_fm_format method previously in the
header
unfortunately had wrong arguments and so was useless, so the largest
complication in this patch is exporting a new symbol in the right symbol
version.
2021-12-10 Jakub Jelinek <jakub@redhat.com>
PR libstdc++/71367
* config/locale/dragonfly/time_members.cc
(_M_initialize_timepunct):
Initialize "C" _M_am_pm_format to %I:%M:%S %p rather than empty
string.
* config/locale/gnu/time_members.cc (_M_initialize_timepunct):
Likewise.
* config/locale/generic/time_members.cc (_M_initialize_timepunct):
Likewise.
* include/bits/locale_facets_nonio.h (_M_am_pm_format): New method.
* include/bits/locale_facets_nonio.tcc (_M_extract_via_format):
Handle
%r.
* config/abi/pre/gnu.ver (GLIBCXX_3.4.30): Export _M_am_pm_format
with const _CharT** argument, ensure it isn't exported in
GLIBCXX_3.4.
* testsuite/22_locale/time_get/get/char/71367.cc: New test.
* testsuite/22_locale/time_get/get/wchar_t/71367.cc: New test.
^ permalink raw reply [flat|nested] 9+ messages in thread* [Bug libstdc++/71367] std::time_get does not implement 'r' or 'p'
[not found] <bug-71367-4@http.gcc.gnu.org/bugzilla/>
` (6 preceding siblings ...)
2021-12-10 16:05 ` cvs-commit at gcc dot gnu.org
@ 2021-12-10 16:16 ` jakub at gcc dot gnu.org
2021-12-15 0:44 ` redi at gcc dot gnu.org
8 siblings, 0 replies; 9+ messages in thread
From: jakub at gcc dot gnu.org @ 2021-12-10 16:16 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=71367
Jakub Jelinek <jakub at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jakub at gcc dot gnu.org
--- Comment #10 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Together with the previous PR78714
r12-5898-gc82e492616e343b6d6db218d2b498267bac899de commit I think this is
partially fixed now, it will work fine if %I comes before %p, whether in user's
format or from %r, but it doesn't work right now if %p comes before %I e.g. as
in cmn_TW, en_HK, hak_TW, ja_JP, ko_KR, nan_TW, si_LK, ta_IN, te_IN, yue_HK,
zh_CN, zh_HK and zh_TW glibc locales. For those we need some state and
post-processing, mentioned as todo list in the r12-5898 commit message.
^ permalink raw reply [flat|nested] 9+ messages in thread* [Bug libstdc++/71367] std::time_get does not implement 'r' or 'p'
[not found] <bug-71367-4@http.gcc.gnu.org/bugzilla/>
` (7 preceding siblings ...)
2021-12-10 16:16 ` jakub at gcc dot gnu.org
@ 2021-12-15 0:44 ` redi at gcc dot gnu.org
8 siblings, 0 replies; 9+ messages in thread
From: redi at gcc dot gnu.org @ 2021-12-15 0:44 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=71367
--- Comment #11 from Jonathan Wakely <redi at gcc dot gnu.org> ---
(In reply to Jonathan Wakely from comment #1)
> We need this to fix some failing tests now, because glibc 2.29 changed T_FMT
> for some locales, including en_HK which we use in:
>
> testsuite/22_locale/time_get/get_time/char/2.cc
> testsuite/22_locale/time_get/get_time/wchar_t/2.cc
Those tests PASS again now.
^ permalink raw reply [flat|nested] 9+ messages in thread