public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug driver/77576] gcc-ar doesn't work if all options are read from file
       [not found] <bug-77576-4@http.gcc.gnu.org/bugzilla/>
@ 2022-01-01  7:29 ` pinskia at gcc dot gnu.org
  2022-11-19 23:35 ` pinskia at gcc dot gnu.org
                   ` (4 subsequent siblings)
  5 siblings, 0 replies; 6+ messages in thread
From: pinskia at gcc dot gnu.org @ 2022-01-01  7:29 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=77576

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|                            |2022-01-01
           See Also|                            |https://gcc.gnu.org/bugzill
                   |                            |a/show_bug.cgi?id=91244
             Status|UNCONFIRMED                 |ASSIGNED
           Assignee|unassigned at gcc dot gnu.org      |pinskia at gcc dot gnu.org
     Ever confirmed|0                           |1

--- Comment #4 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Let me see if I can fix this. Adding != '@' does not seem correct. I suspect we
should expand the @file and then put it in a temp file and do the correct
thing.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug driver/77576] gcc-ar doesn't work if all options are read from file
       [not found] <bug-77576-4@http.gcc.gnu.org/bugzilla/>
  2022-01-01  7:29 ` [Bug driver/77576] gcc-ar doesn't work if all options are read from file pinskia at gcc dot gnu.org
@ 2022-11-19 23:35 ` pinskia at gcc dot gnu.org
  2023-07-01 21:38 ` costas.argyris at gmail dot com
                   ` (3 subsequent siblings)
  5 siblings, 0 replies; 6+ messages in thread
From: pinskia at gcc dot gnu.org @ 2022-11-19 23:35 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=77576

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|pinskia at gcc dot gnu.org         |unassigned at gcc dot gnu.org
             Status|ASSIGNED                    |NEW

--- Comment #5 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
No longer working on this one.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug driver/77576] gcc-ar doesn't work if all options are read from file
       [not found] <bug-77576-4@http.gcc.gnu.org/bugzilla/>
  2022-01-01  7:29 ` [Bug driver/77576] gcc-ar doesn't work if all options are read from file pinskia at gcc dot gnu.org
  2022-11-19 23:35 ` pinskia at gcc dot gnu.org
@ 2023-07-01 21:38 ` costas.argyris at gmail dot com
  2023-07-01 21:40 ` costas.argyris at gmail dot com
                   ` (2 subsequent siblings)
  5 siblings, 0 replies; 6+ messages in thread
From: costas.argyris at gmail dot com @ 2023-07-01 21:38 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=77576

Costas Argyris <costas.argyris at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |costas.argyris at gmail dot com

--- Comment #6 from Costas Argyris <costas.argyris at gmail dot com> ---
Created attachment 55446
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=55446&action=edit
Expand at-file and use temporary response file.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug driver/77576] gcc-ar doesn't work if all options are read from file
       [not found] <bug-77576-4@http.gcc.gnu.org/bugzilla/>
                   ` (2 preceding siblings ...)
  2023-07-01 21:38 ` costas.argyris at gmail dot com
@ 2023-07-01 21:40 ` costas.argyris at gmail dot com
  2023-07-31 16:58 ` cvs-commit at gcc dot gnu.org
  2023-07-31 16:59 ` law at gcc dot gnu.org
  5 siblings, 0 replies; 6+ messages in thread
From: costas.argyris at gmail dot com @ 2023-07-01 21:40 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=77576

--- Comment #7 from Costas Argyris <costas.argyris at gmail dot com> ---
Implemented what Andrew said:

"I suspect we should expand the @file and then put it in a temp file and do the
correct thing."

Attached patch here but also sending to gcc-patches ML.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug driver/77576] gcc-ar doesn't work if all options are read from file
       [not found] <bug-77576-4@http.gcc.gnu.org/bugzilla/>
                   ` (3 preceding siblings ...)
  2023-07-01 21:40 ` costas.argyris at gmail dot com
@ 2023-07-31 16:58 ` cvs-commit at gcc dot gnu.org
  2023-07-31 16:59 ` law at gcc dot gnu.org
  5 siblings, 0 replies; 6+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2023-07-31 16:58 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=77576

--- Comment #8 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jeff Law <law@gcc.gnu.org>:

https://gcc.gnu.org/g:c6523ae786e36dccd64589682140e9221628bb5b

commit r14-2884-gc6523ae786e36dccd64589682140e9221628bb5b
Author: Costas Argyris <costas.argyris@gmail.com>
Date:   Mon Jul 31 10:56:20 2023 -0600

    Re: [PATCH] gcc-ar: Handle response files properly [PR77576]

    Problem: gcc-ar fails when a @file is passed to it:

    $ cat rsp
    --version
    $ gcc-ar @rsp
    /usr/bin/ar: invalid option -- '@'

    This is because a dash '-' is prepended to the first
    argument if it doesn't start with one, resulting in
    the wrong call 'ar -@rsp'.

    Fix: Expand argv to get rid of any @files and if any
    expansions were made, pass everything through a
    temporary response file.

    $ gcc-ar @rsp
    GNU ar (GNU Binutils for Debian) 2.35.2
    ...

    gcc/
            PR driver/77576
            * gcc-ar.cc (main): Expand argv and use
            temporary response file to call ar if any
            expansions were made.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug driver/77576] gcc-ar doesn't work if all options are read from file
       [not found] <bug-77576-4@http.gcc.gnu.org/bugzilla/>
                   ` (4 preceding siblings ...)
  2023-07-31 16:58 ` cvs-commit at gcc dot gnu.org
@ 2023-07-31 16:59 ` law at gcc dot gnu.org
  5 siblings, 0 replies; 6+ messages in thread
From: law at gcc dot gnu.org @ 2023-07-31 16:59 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=77576

Jeffrey A. Law <law at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |law at gcc dot gnu.org
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #9 from Jeffrey A. Law <law at gcc dot gnu.org> ---
Fixed on the trunk.

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2023-07-31 16:59 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <bug-77576-4@http.gcc.gnu.org/bugzilla/>
2022-01-01  7:29 ` [Bug driver/77576] gcc-ar doesn't work if all options are read from file pinskia at gcc dot gnu.org
2022-11-19 23:35 ` pinskia at gcc dot gnu.org
2023-07-01 21:38 ` costas.argyris at gmail dot com
2023-07-01 21:40 ` costas.argyris at gmail dot com
2023-07-31 16:58 ` cvs-commit at gcc dot gnu.org
2023-07-31 16:59 ` law at gcc dot gnu.org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).