public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug sanitizer/78204] ‘no_sanitize’ attribute directive ignored [-Wattributes]
       [not found] <bug-78204-4@http.gcc.gnu.org/bugzilla/>
@ 2022-12-04 22:59 ` i at maskray dot me
  2022-12-04 23:05 ` pinskia at gcc dot gnu.org
  1 sibling, 0 replies; 2+ messages in thread
From: i at maskray dot me @ 2022-12-04 22:59 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78204

Fangrui Song <i at maskray dot me> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |i at maskray dot me

--- Comment #8 from Fangrui Song <i at maskray dot me> ---
Note: Clang supports
__attribute__((no_sanitize("address","undefined")))
but not
__attribute__((no_sanitize("address,undefined")))

Possibly reject `__attribute__((no_sanitize("address,undefined")))` as well to
prevent users from writing non-portable code.

^ permalink raw reply	[flat|nested] 2+ messages in thread

* [Bug sanitizer/78204] ‘no_sanitize’ attribute directive ignored [-Wattributes]
       [not found] <bug-78204-4@http.gcc.gnu.org/bugzilla/>
  2022-12-04 22:59 ` [Bug sanitizer/78204] ‘no_sanitize’ attribute directive ignored [-Wattributes] i at maskray dot me
@ 2022-12-04 23:05 ` pinskia at gcc dot gnu.org
  1 sibling, 0 replies; 2+ messages in thread
From: pinskia at gcc dot gnu.org @ 2022-12-04 23:05 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78204

--- Comment #9 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
(In reply to Fangrui Song from comment #8)
> Note: Clang supports
> __attribute__((no_sanitize("address","undefined")))
> but not
> __attribute__((no_sanitize("address,undefined")))
> 
> Possibly reject `__attribute__((no_sanitize("address,undefined")))` as well
> to prevent users from writing non-portable code.

We document both ways already. 
https://gcc.gnu.org/onlinedocs/gcc-12.2.0/gcc/Common-Function-Attributes.html#index-no_005fsanitize-function-attribute

I would have said if we don't document both ways we should reject it but since
it is documented already, maybe add to the documentation that clang does not
accept the combined string way.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-12-04 23:05 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <bug-78204-4@http.gcc.gnu.org/bugzilla/>
2022-12-04 22:59 ` [Bug sanitizer/78204] ‘no_sanitize’ attribute directive ignored [-Wattributes] i at maskray dot me
2022-12-04 23:05 ` pinskia at gcc dot gnu.org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).