[Bug target/79754] ICE in type_natural_mode with vector for DFP type

[Bug target/79754] ICE in type_natural_mode with vector for DFP type

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=79754

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|error-recovery,             |ice-on-valid-code
                   |ice-on-invalid-code         |

--- Comment #2 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Actually the ICE can be on valid code:

typedef _Decimal32  V __attribute__ ((vector_size(16)));
int fn1 (V a) { }

[Bug target/79754] ICE in type_natural_mode with vector for DFP type

[zsojka at seznam dot cz]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=79754

--- Comment #3 from Zdenek Sojka <zsojka at seznam dot cz> ---
This still ICEs on r12-7199:
$ x86_64-pc-linux-gnu-gcc testcase.c 
testcase.c: In function 'foo':
testcase.c:2:1: internal compiler error: in type_natural_mode, at
config/i386/i386.cc:1978
    2 | V foo (V a) { return a * a; }
      | ^
0x81e1e7 type_natural_mode
        /repo/gcc-trunk/gcc/config/i386/i386.cc:1978
0x172382a ix86_return_in_memory
        /repo/gcc-trunk/gcc/config/i386/i386.cc:4230
0x101084d aggregate_value_p(tree_node const*, tree_node const*)
        /repo/gcc-trunk/gcc/function.cc:2119
0x10154ac allocate_struct_function(tree_node*, bool)
        /repo/gcc-trunk/gcc/function.cc:4845
0xd26104 store_parm_decls()
        /repo/gcc-trunk/gcc/c/c-decl.cc:10160
0xd855c7 c_parser_declaration_or_fndef
        /repo/gcc-trunk/gcc/c/c-parser.cc:2505
0xd8d8a3 c_parser_external_declaration
        /repo/gcc-trunk/gcc/c/c-parser.cc:1779
0xd8e2eb c_parser_translation_unit
        /repo/gcc-trunk/gcc/c/c-parser.cc:1652
0xd8e2eb c_parse_file()
        /repo/gcc-trunk/gcc/c/c-parser.cc:23348
0xdef9fd c_common_parse_file()
        /repo/gcc-trunk/gcc/c-family/c-opts.cc:1238
Please submit a full bug report, with preprocessed source (by using
-freport-bug).
Please include the complete backtrace with any bug report.
See <https://gcc.gnu.org/bugs/> for instructions.

but works on powerpc64le (at least, doesn't ICE; I didn't check if the code is
correct):
$ powerpc64le-unknown-linux-gnu-gcc testcase.c -c
(no output)

[Bug target/79754] ICE in type_natural_mode with vector for DFP type

[ubizjak at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=79754

Uroš Bizjak <ubizjak at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|unassigned at gcc dot gnu.org      |ubizjak at gmail dot com

--- Comment #4 from Uroš Bizjak <ubizjak at gmail dot com> ---
Created attachment 52422
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=52422&action=edit
Patch in testing.

[Bug target/79754] ICE in type_natural_mode with vector for DFP type

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=79754

--- Comment #5 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Uros Bizjak <uros@gcc.gnu.org>:

https://gcc.gnu.org/g:edadc7e0510b703d9727cf5ff68d55d84bb95def

commit r12-7211-gedadc7e0510b703d9727cf5ff68d55d84bb95def
Author: Uros Bizjak <ubizjak@gmail.com>
Date:   Sat Feb 12 10:53:49 2022 +0100

    i386: Skip decimal float vector modes in type_natural_mode [PR79754]

    2022-02-12  Uroš Bizjak  <ubizjak@gmail.com>

    gcc/ChangeLog:

            PR target/79754
            * config/i386/i386.cc (type_natural_mode):
            Skip decimal float vector modes.

    gcc/testsuite/ChangeLog:

            PR target/79754
            * gcc.target/i386/pr79754.c: New test.

[Bug target/79754] ICE in type_natural_mode with vector for DFP type

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=79754

--- Comment #6 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-11 branch has been updated by Uros Bizjak <uros@gcc.gnu.org>:

https://gcc.gnu.org/g:e89144e8a3984608da2d31f18776df51d9e0f352

commit r11-9564-ge89144e8a3984608da2d31f18776df51d9e0f352
Author: Uros Bizjak <ubizjak@gmail.com>
Date:   Sat Feb 12 10:53:49 2022 +0100

    i386: Skip decimal float vector modes in type_natural_mode [PR79754]

    2022-02-12  Uroš Bizjak  <ubizjak@gmail.com>

    gcc/ChangeLog:

            PR target/79754
            * config/i386/i386.c (type_natural_mode):
            Skip decimal float vector modes.

    gcc/testsuite/ChangeLog:

            PR target/79754
            * gcc.target/i386/pr79754.c: New test.

    (cherry picked from commit edadc7e0510b703d9727cf5ff68d55d84bb95def)

[Bug target/79754] ICE in type_natural_mode with vector for DFP type

[ubizjak at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=79754

Uroš Bizjak <ubizjak at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED
   Target Milestone|---                         |11.3

--- Comment #7 from Uroš Bizjak <ubizjak at gmail dot com> ---
Fixed for 11.3+.

[Bug target/79754] ICE in type_natural_mode with vector for DFP type

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=79754

--- Comment #8 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Eric Botcazou <ebotcazou@gcc.gnu.org>:

https://gcc.gnu.org/g:bc6d2f460a4c12e89c02525abdb182828ae8a27e

commit r12-7281-gbc6d2f460a4c12e89c02525abdb182828ae8a27e
Author: Eric Botcazou <ebotcazou@adacore.com>
Date:   Thu Feb 17 18:34:06 2022 +0100

    Add missing target selector

    gcc/testsuite/
            PR target/79754
            * gcc.target/i386/pr79754.c: Add target dfp.

[Bug target/79754] ICE in type_natural_mode with vector for DFP type

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=79754

--- Comment #9 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-11 branch has been updated by Eric Botcazou
<ebotcazou@gcc.gnu.org>:

https://gcc.gnu.org/g:d5b9b6f31d22539b7e85bea966f48ad84ebb2e8c

commit r11-9589-gd5b9b6f31d22539b7e85bea966f48ad84ebb2e8c
Author: Eric Botcazou <ebotcazou@adacore.com>
Date:   Thu Feb 17 18:34:06 2022 +0100

    Add missing target selector

    gcc/testsuite/
            PR target/79754
            * gcc.target/i386/pr79754.c: Add target dfp.

[Bug target/79754] ICE in type_natural_mode with vector for DFP type

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=79754

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ujszhangc at gmail dot com

--- Comment #10 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
*** Bug 113992 has been marked as a duplicate of this bug. ***