[Bug fortran/80012] FIXME in diagnostic "%s procedure at %L is already declared as %s procedure" from symbol.c

[Bug fortran/80012] FIXME in diagnostic "%s procedure at %L is already declared as %s procedure" from symbol.c

[anujmohite001 at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80012

Anuj Mohite <anujmohite001 at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |anujmohite001 at gmail dot com

--- Comment #4 from Anuj Mohite <anujmohite001 at gmail dot com> ---
can we split the original error message into two separate calls to gfc_error()
fuction. file: fortran/symbol.cc

Before changes:

gfc_error ("%s procedure at %L is already declared as %s "
           "procedure. \nF2008: A pointer function assignment "
           "is ambiguous if it is the first executable statement "
           "after the specification block. Please add any other "
           "kind of executable statement before it. FIXME",

After changes:

// Main error message
gfc_error ("%s procedure at %L is already declared as %s procedure",
           gfc_code2string(procedures, t), where,
           gfc_code2string(procedures, attr->proc));

// Additional information for F2008 standard
gfc_error("A pointer function assignment is ambiguous if it is the first "
           "executable statement after the specification block. Please add "
           "any other kind of executable statement before it.");

[Bug fortran/80012] FIXME in diagnostic "%s procedure at %L is already declared as %s procedure" from symbol.c

[jvdelisle at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80012

Jerry DeLisle <jvdelisle at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jvdelisle at gcc dot gnu.org

--- Comment #5 from Jerry DeLisle <jvdelisle at gcc dot gnu.org> ---
I have not looked at this in detail. Generally, you can do conditional errors
depending on what -std=fxxxx a user specifies at compile time. So theoretically
you can do two different errors depending on these options.

Also look in the codes for examples of 'notify' or 'notification' to see ways
to do these things.

Another way is to build an error message with snprintf for example and use that
string in the error message.

[Bug fortran/80012] FIXME in diagnostic "%s procedure at %L is already declared as %s procedure" from symbol.c

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80012

--- Comment #6 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
At least in the middle-end or C/C++ FEs such diagnostics is done with
error{,_at}/warning{,_at} etc. followed by inform, for warning inform only
called if warning* returned true, and wrapped with auto_diagnostic_group d;
because it is really just one error (or warning) with extra explanation, not
two separate errors.

[Bug fortran/80012] FIXME in diagnostic "%s procedure at %L is already declared as %s procedure" from symbol.c

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80012

--- Comment #7 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
(In reply to Jerry DeLisle from comment #5)
> Another way is to build an error message with snprintf for example and use
> that string in the error message.

That is translation unfriendly.

[Bug fortran/80012] FIXME in diagnostic "%s procedure at %L is already declared as %s procedure" from symbol.c

[roland.illig at gmx dot de]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80012

--- Comment #8 from Roland Illig <roland.illig at gmx dot de> ---
(In reply to Jakub Jelinek from comment #7)
> (In reply to Jerry DeLisle from comment #5)
> > Another way is to build an error message with snprintf for example and use
> > that string in the error message.
> 
> That is translation unfriendly.

And the German translator (me) is particularly picky about these topics, so
whenever you assemble diagnostics using snprintf, you'll get a new bug report
from me; see #114364 for an example.

[Bug fortran/80012] FIXME in diagnostic "%s procedure at %L is already declared as %s procedure" from symbol.c

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80012

anlauf at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |anlauf at gcc dot gnu.org

--- Comment #9 from anlauf at gcc dot gnu.org ---
This is all quite confusing.

First, who is the addressee of the FIXME?  gfortran developers or users?

And can someone explain this special distinguishment is made (F2008 or not)?

Other compilers tested seem to be "uncomfortable" with Dominique's example
in comment#2, as they are unable to recognize that two() is not a
statement function.  Even with an added statement in front.

Can anyone point to the exact formulation in the standard that clarifies
the situation?

The first part of the error message seems to be emitted in any case.
Thus, the second part appears to be aiming to help the user to fix
his/her code.  But is it the right recommendation?