public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug tree-optimization/83247] simplify (int)a_long < 0 when we know a_long fits in int
       [not found] <bug-83247-4@http.gcc.gnu.org/bugzilla/>
@ 2021-08-19 17:45 ` pinskia at gcc dot gnu.org
  2023-08-09 22:21 ` pinskia at gcc dot gnu.org
                   ` (4 subsequent siblings)
  5 siblings, 0 replies; 6+ messages in thread
From: pinskia at gcc dot gnu.org @ 2021-08-19 17:45 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=83247

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever confirmed|0                           |1
   Last reconfirmed|                            |2021-08-19

--- Comment #1 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
  # RANGE [-1000, 1000]
  _1 = (intD.9) l_3(D);
  _4 = _1 < 0;

It should not be too hard to do this.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug tree-optimization/83247] simplify (int)a_long < 0 when we know a_long fits in int
       [not found] <bug-83247-4@http.gcc.gnu.org/bugzilla/>
  2021-08-19 17:45 ` [Bug tree-optimization/83247] simplify (int)a_long < 0 when we know a_long fits in int pinskia at gcc dot gnu.org
@ 2023-08-09 22:21 ` pinskia at gcc dot gnu.org
  2023-08-10  1:55 ` pinskia at gcc dot gnu.org
                   ` (3 subsequent siblings)
  5 siblings, 0 replies; 6+ messages in thread
From: pinskia at gcc dot gnu.org @ 2023-08-09 22:21 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=83247

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|unassigned at gcc dot gnu.org      |pinskia at gcc dot gnu.org
                 CC|                            |pinskia at gcc dot gnu.org

--- Comment #2 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
I thought simplify_casted_compare in vr-values.cc was supposed to do that but
it looks like it is not.

Let me try to see how to fix simplify_casted_compare .

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug tree-optimization/83247] simplify (int)a_long < 0 when we know a_long fits in int
       [not found] <bug-83247-4@http.gcc.gnu.org/bugzilla/>
  2021-08-19 17:45 ` [Bug tree-optimization/83247] simplify (int)a_long < 0 when we know a_long fits in int pinskia at gcc dot gnu.org
  2023-08-09 22:21 ` pinskia at gcc dot gnu.org
@ 2023-08-10  1:55 ` pinskia at gcc dot gnu.org
  2023-08-10  2:38 ` pinskia at gcc dot gnu.org
                   ` (2 subsequent siblings)
  5 siblings, 0 replies; 6+ messages in thread
From: pinskia at gcc dot gnu.org @ 2023-08-10  1:55 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=83247

--- Comment #3 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
This was literally 4 lines which needed to change now.
The use of range_of_expr inside simplify_casted_compare just needed to be
passed the statement and that fixed it ....

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug tree-optimization/83247] simplify (int)a_long < 0 when we know a_long fits in int
       [not found] <bug-83247-4@http.gcc.gnu.org/bugzilla/>
                   ` (2 preceding siblings ...)
  2023-08-10  1:55 ` pinskia at gcc dot gnu.org
@ 2023-08-10  2:38 ` pinskia at gcc dot gnu.org
  2023-08-10  5:55 ` pinskia at gcc dot gnu.org
  2023-08-10  6:18 ` pinskia at gcc dot gnu.org
  5 siblings, 0 replies; 6+ messages in thread
From: pinskia at gcc dot gnu.org @ 2023-08-10  2:38 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=83247

--- Comment #4 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Created attachment 55714
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=55714&action=edit
Patch which I am testing

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug tree-optimization/83247] simplify (int)a_long < 0 when we know a_long fits in int
       [not found] <bug-83247-4@http.gcc.gnu.org/bugzilla/>
                   ` (3 preceding siblings ...)
  2023-08-10  2:38 ` pinskia at gcc dot gnu.org
@ 2023-08-10  5:55 ` pinskia at gcc dot gnu.org
  2023-08-10  6:18 ` pinskia at gcc dot gnu.org
  5 siblings, 0 replies; 6+ messages in thread
From: pinskia at gcc dot gnu.org @ 2023-08-10  5:55 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=83247

--- Comment #5 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Some failures ...

gnat.dg/opt86a.adb: pattern found 1 times
FAIL: gnat.dg/opt86a.adb scan-tree-dump-times optimized ">>" 4



+FAIL: gnat.dg/opt86b.adb scan-tree-dump-not optimized "> 13"
+FAIL: gnat.dg/opt86c.adb scan-tree-dump-not optimized "> 26"
+FAIL: gnat.dg/opt86c.adb scan-tree-dump-not optimized "> 29"

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug tree-optimization/83247] simplify (int)a_long < 0 when we know a_long fits in int
       [not found] <bug-83247-4@http.gcc.gnu.org/bugzilla/>
                   ` (4 preceding siblings ...)
  2023-08-10  5:55 ` pinskia at gcc dot gnu.org
@ 2023-08-10  6:18 ` pinskia at gcc dot gnu.org
  5 siblings, 0 replies; 6+ messages in thread
From: pinskia at gcc dot gnu.org @ 2023-08-10  6:18 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=83247

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |110965

--- Comment #6 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
(In reply to Andrew Pinski from comment #5)
> Some failures ...
> 
> gnat.dg/opt86a.adb: pattern found 1 times
> FAIL: gnat.dg/opt86a.adb scan-tree-dump-times optimized ">>" 4

Ok, this is PR 110965 .


I have not looked into the rest yet.


Referenced Bugs:

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110965
[Bug 110965] missing combining if ranges due to cast differences

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2023-08-10  6:18 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <bug-83247-4@http.gcc.gnu.org/bugzilla/>
2021-08-19 17:45 ` [Bug tree-optimization/83247] simplify (int)a_long < 0 when we know a_long fits in int pinskia at gcc dot gnu.org
2023-08-09 22:21 ` pinskia at gcc dot gnu.org
2023-08-10  1:55 ` pinskia at gcc dot gnu.org
2023-08-10  2:38 ` pinskia at gcc dot gnu.org
2023-08-10  5:55 ` pinskia at gcc dot gnu.org
2023-08-10  6:18 ` pinskia at gcc dot gnu.org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).