public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "rsandifo at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c/85487] Support '#pragma region' and '#pragma endregion' to allow code folding with Visual Studio
Date: Fri, 25 Feb 2022 13:01:52 +0000 [thread overview]
Message-ID: <bug-85487-4-0BE4LvQvlT@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-85487-4@http.gcc.gnu.org/bugzilla/>
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85487
rsandifo at gcc dot gnu.org <rsandifo at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |rsandifo at gcc dot gnu.org
--- Comment #12 from rsandifo at gcc dot gnu.org <rsandifo at gcc dot gnu.org> ---
(In reply to Jonathan Wakely from comment #9)
> (In reply to Jakub Jelinek from comment #7)
> > I would say that is a terrible design...
>
> Yes, I completely agree, but I don't see why GCC should be in the business
> of diagnosing other people's junk :-)
>
> Maybe Visual Studio's editor and VScode do have checks, just not the VC++
> compiler. And if so, then that's even more reason that we don't need GCC to
> do its own checking.
Agreed. And if people with strict linting requirements want
a warning about pragmas that are recognised but have no effect
on the compiler, we could still provide an option to do that
(but it shouldn't be in -Wall or even -Wextra).
That shouldn't be a requirement for this PR though, unless anyone
can show that someone somewhere really does want these pragmas to
generate a warning.
Jeff said at the end of the thread that he wouldn't mind
if someone else approves it, so it's probably worth posting
again. The patch LGTM FWIW: only (very) minor comment is that
the unused argument name in handle_pragma_region can be dropped.
I think the patch would need to wait for GCC 13 now though.
next prev parent reply other threads:[~2022-02-25 13:01 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <bug-85487-4@http.gcc.gnu.org/bugzilla/>
2020-08-27 20:46 ` bmburstein at gmail dot com
2022-02-15 13:17 ` redi at gcc dot gnu.org
2022-02-15 13:31 ` jakub at gcc dot gnu.org
2022-02-15 14:02 ` austinpmorton at gmail dot com
2022-02-15 15:23 ` redi at gcc dot gnu.org
2022-02-15 15:26 ` jakub at gcc dot gnu.org
2022-02-15 15:32 ` redi at gcc dot gnu.org
2022-02-15 15:34 ` redi at gcc dot gnu.org
2022-02-17 11:45 ` egallager at gcc dot gnu.org
2022-02-21 17:11 ` fw at gcc dot gnu.org
2022-02-25 13:01 ` rsandifo at gcc dot gnu.org [this message]
2022-02-25 14:46 ` redi at gcc dot gnu.org
2022-02-25 14:49 ` redi at gcc dot gnu.org
2022-05-30 15:43 ` bmburstein at gmail dot com
2022-11-11 4:28 ` cvs-commit at gcc dot gnu.org
2022-11-11 4:28 ` redi at gcc dot gnu.org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-85487-4-0BE4LvQvlT@http.gcc.gnu.org/bugzilla/ \
--to=gcc-bugzilla@gcc.gnu.org \
--cc=gcc-bugs@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).