public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug fortran/87851] [9/10/11/12 Regression] Wrong return type for len_trim
       [not found] <bug-87851-4@http.gcc.gnu.org/bugzilla/>
@ 2021-05-14  9:50 ` jakub at gcc dot gnu.org
  2021-06-01  8:12 ` rguenth at gcc dot gnu.org
                   ` (9 subsequent siblings)
  10 siblings, 0 replies; 11+ messages in thread
From: jakub at gcc dot gnu.org @ 2021-05-14  9:50 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=87851

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|8.5                         |9.4

--- Comment #12 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
GCC 8 branch is being closed.

^ permalink raw reply	[flat|nested] 11+ messages in thread

* [Bug fortran/87851] [9/10/11/12 Regression] Wrong return type for len_trim
       [not found] <bug-87851-4@http.gcc.gnu.org/bugzilla/>
  2021-05-14  9:50 ` [Bug fortran/87851] [9/10/11/12 Regression] Wrong return type for len_trim jakub at gcc dot gnu.org
@ 2021-06-01  8:12 ` rguenth at gcc dot gnu.org
  2021-11-18 22:35 ` anlauf at gcc dot gnu.org
                   ` (8 subsequent siblings)
  10 siblings, 0 replies; 11+ messages in thread
From: rguenth at gcc dot gnu.org @ 2021-06-01  8:12 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=87851

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|9.4                         |9.5

--- Comment #13 from Richard Biener <rguenth at gcc dot gnu.org> ---
GCC 9.4 is being released, retargeting bugs to GCC 9.5.

^ permalink raw reply	[flat|nested] 11+ messages in thread

* [Bug fortran/87851] [9/10/11/12 Regression] Wrong return type for len_trim
       [not found] <bug-87851-4@http.gcc.gnu.org/bugzilla/>
  2021-05-14  9:50 ` [Bug fortran/87851] [9/10/11/12 Regression] Wrong return type for len_trim jakub at gcc dot gnu.org
  2021-06-01  8:12 ` rguenth at gcc dot gnu.org
@ 2021-11-18 22:35 ` anlauf at gcc dot gnu.org
  2021-11-19 19:48 ` anlauf at gcc dot gnu.org
                   ` (7 subsequent siblings)
  10 siblings, 0 replies; 11+ messages in thread
From: anlauf at gcc dot gnu.org @ 2021-11-18 22:35 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=87851

anlauf at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |anlauf at gcc dot gnu.org

--- Comment #14 from anlauf at gcc dot gnu.org ---
Potential fix:

diff --git a/gcc/fortran/trans-array.c b/gcc/fortran/trans-array.c
index 2090adf01e7..238b1b72385 100644
--- a/gcc/fortran/trans-array.c
+++ b/gcc/fortran/trans-array.c
@@ -11499,6 +11499,7 @@ arg_evaluated_for_scalarization (gfc_intrinsic_sym
*function,
       switch (function->id)
        {
          case GFC_ISYM_INDEX:
+         case GFC_ISYM_LEN_TRIM:
            if (strcmp ("kind", gfc_dummy_arg_get_name (*dummy_arg)) == 0)
              return false;
          /* Fallthrough.  */

This depends on Mikael's fix for PR97896 and is likely the cleanest solution.

^ permalink raw reply	[flat|nested] 11+ messages in thread

* [Bug fortran/87851] [9/10/11/12 Regression] Wrong return type for len_trim
       [not found] <bug-87851-4@http.gcc.gnu.org/bugzilla/>
                   ` (2 preceding siblings ...)
  2021-11-18 22:35 ` anlauf at gcc dot gnu.org
@ 2021-11-19 19:48 ` anlauf at gcc dot gnu.org
  2021-11-23 16:52 ` cvs-commit at gcc dot gnu.org
                   ` (6 subsequent siblings)
  10 siblings, 0 replies; 11+ messages in thread
From: anlauf at gcc dot gnu.org @ 2021-11-19 19:48 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=87851

anlauf at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |ice-on-valid-code

--- Comment #15 from anlauf at gcc dot gnu.org ---
Submitted: https://gcc.gnu.org/pipermail/fortran/2021-November/057038.html

^ permalink raw reply	[flat|nested] 11+ messages in thread

* [Bug fortran/87851] [9/10/11/12 Regression] Wrong return type for len_trim
       [not found] <bug-87851-4@http.gcc.gnu.org/bugzilla/>
                   ` (3 preceding siblings ...)
  2021-11-19 19:48 ` anlauf at gcc dot gnu.org
@ 2021-11-23 16:52 ` cvs-commit at gcc dot gnu.org
  2021-11-24 19:51 ` cvs-commit at gcc dot gnu.org
                   ` (5 subsequent siblings)
  10 siblings, 0 replies; 11+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2021-11-23 16:52 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=87851

--- Comment #16 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Harald Anlauf <anlauf@gcc.gnu.org>:

https://gcc.gnu.org/g:721d8b9e26bf8205c1f2125c2626919a408cdbe4

commit r12-5473-g721d8b9e26bf8205c1f2125c2626919a408cdbe4
Author: Harald Anlauf <anlauf@gmx.de>
Date:   Tue Nov 23 17:51:38 2021 +0100

    Fortran: fix scalarization for intrinsic LEN_TRIM with present KIND
argument

    gcc/fortran/ChangeLog:

            PR fortran/87711
            PR fortran/87851
            * trans-array.c (arg_evaluated_for_scalarization): Add LEN_TRIM to
            list of intrinsics for which an optional KIND argument needs to be
            removed before scalarization.

    gcc/testsuite/ChangeLog:

            PR fortran/87711
            PR fortran/87851
            * gfortran.dg/len_trim.f90: New test.

^ permalink raw reply	[flat|nested] 11+ messages in thread

* [Bug fortran/87851] [9/10/11/12 Regression] Wrong return type for len_trim
       [not found] <bug-87851-4@http.gcc.gnu.org/bugzilla/>
                   ` (4 preceding siblings ...)
  2021-11-23 16:52 ` cvs-commit at gcc dot gnu.org
@ 2021-11-24 19:51 ` cvs-commit at gcc dot gnu.org
  2021-11-24 19:58 ` anlauf at gcc dot gnu.org
                   ` (4 subsequent siblings)
  10 siblings, 0 replies; 11+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2021-11-24 19:51 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=87851

--- Comment #17 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-11 branch has been updated by Harald Anlauf
<anlauf@gcc.gnu.org>:

https://gcc.gnu.org/g:3e6b9910e8e23d690fa1026b2879d37745ddd740

commit r11-9307-g3e6b9910e8e23d690fa1026b2879d37745ddd740
Author: Harald Anlauf <anlauf@gmx.de>
Date:   Tue Nov 23 17:51:38 2021 +0100

    Fortran: fix scalarization for intrinsic LEN_TRIM with present KIND
argument

    gcc/fortran/ChangeLog:

            PR fortran/87711
            PR fortran/87851
            * trans-array.c (arg_evaluated_for_scalarization): Add LEN_TRIM to
            list of intrinsics for which an optional KIND argument needs to be
            removed before scalarization.

    gcc/testsuite/ChangeLog:

            PR fortran/87711
            PR fortran/87851
            * gfortran.dg/len_trim.f90: New test.

    (cherry picked from commit 721d8b9e26bf8205c1f2125c2626919a408cdbe4)

^ permalink raw reply	[flat|nested] 11+ messages in thread

* [Bug fortran/87851] [9/10/11/12 Regression] Wrong return type for len_trim
       [not found] <bug-87851-4@http.gcc.gnu.org/bugzilla/>
                   ` (5 preceding siblings ...)
  2021-11-24 19:51 ` cvs-commit at gcc dot gnu.org
@ 2021-11-24 19:58 ` anlauf at gcc dot gnu.org
  2022-05-27  9:39 ` [Bug fortran/87851] [10/11/12/13 " rguenth at gcc dot gnu.org
                   ` (3 subsequent siblings)
  10 siblings, 0 replies; 11+ messages in thread
From: anlauf at gcc dot gnu.org @ 2021-11-24 19:58 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=87851

anlauf at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |WAITING

--- Comment #18 from anlauf at gcc dot gnu.org ---
The scalarization issue from PR87711 mentioned in comment#0 should be fixed
on mainline and on 11-branch.

As explained by Janne in comment#5, typecasts should get inserted properly.

And when looking at the dump-tree of the committed testcase and playing
with -m32/-m64 and -fdefault-integer-8, I did not see anything suspicious.

@Thomas: do you see anything left to do?

^ permalink raw reply	[flat|nested] 11+ messages in thread

* [Bug fortran/87851] [10/11/12/13 Regression] Wrong return type for len_trim
       [not found] <bug-87851-4@http.gcc.gnu.org/bugzilla/>
                   ` (6 preceding siblings ...)
  2021-11-24 19:58 ` anlauf at gcc dot gnu.org
@ 2022-05-27  9:39 ` rguenth at gcc dot gnu.org
  2022-06-28 10:36 ` jakub at gcc dot gnu.org
                   ` (2 subsequent siblings)
  10 siblings, 0 replies; 11+ messages in thread
From: rguenth at gcc dot gnu.org @ 2022-05-27  9:39 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=87851

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|9.5                         |10.4

--- Comment #19 from Richard Biener <rguenth at gcc dot gnu.org> ---
GCC 9 branch is being closed

^ permalink raw reply	[flat|nested] 11+ messages in thread

* [Bug fortran/87851] [10/11/12/13 Regression] Wrong return type for len_trim
       [not found] <bug-87851-4@http.gcc.gnu.org/bugzilla/>
                   ` (7 preceding siblings ...)
  2022-05-27  9:39 ` [Bug fortran/87851] [10/11/12/13 " rguenth at gcc dot gnu.org
@ 2022-06-28 10:36 ` jakub at gcc dot gnu.org
  2023-05-09 18:56 ` [Bug fortran/87851] [10 " anlauf at gcc dot gnu.org
  2023-07-07  8:17 ` rguenth at gcc dot gnu.org
  10 siblings, 0 replies; 11+ messages in thread
From: jakub at gcc dot gnu.org @ 2022-06-28 10:36 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=87851

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|10.4                        |10.5

--- Comment #20 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
GCC 10.4 is being released, retargeting bugs to GCC 10.5.

^ permalink raw reply	[flat|nested] 11+ messages in thread

* [Bug fortran/87851] [10 Regression] Wrong return type for len_trim
       [not found] <bug-87851-4@http.gcc.gnu.org/bugzilla/>
                   ` (8 preceding siblings ...)
  2022-06-28 10:36 ` jakub at gcc dot gnu.org
@ 2023-05-09 18:56 ` anlauf at gcc dot gnu.org
  2023-07-07  8:17 ` rguenth at gcc dot gnu.org
  10 siblings, 0 replies; 11+ messages in thread
From: anlauf at gcc dot gnu.org @ 2023-05-09 18:56 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=87851

anlauf at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Known to work|                            |11.3.0, 12.2.0, 13.1.0,
                   |                            |14.0
            Summary|[10/11/12/13/14 Regression] |[10 Regression] Wrong
                   |Wrong return type for       |return type for len_trim
                   |len_trim                    |
      Known to fail|                            |10.4.0

--- Comment #21 from anlauf at gcc dot gnu.org ---
Adjusting known-to-work.

A backport to 10-branch would be a major effort, so likely wont-fix in 10.5.

^ permalink raw reply	[flat|nested] 11+ messages in thread

* [Bug fortran/87851] [10 Regression] Wrong return type for len_trim
       [not found] <bug-87851-4@http.gcc.gnu.org/bugzilla/>
                   ` (9 preceding siblings ...)
  2023-05-09 18:56 ` [Bug fortran/87851] [10 " anlauf at gcc dot gnu.org
@ 2023-07-07  8:17 ` rguenth at gcc dot gnu.org
  10 siblings, 0 replies; 11+ messages in thread
From: rguenth at gcc dot gnu.org @ 2023-07-07  8:17 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=87851

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|10.5                        |11.3
             Status|WAITING                     |RESOLVED
         Resolution|---                         |FIXED

--- Comment #22 from Richard Biener <rguenth at gcc dot gnu.org> ---
Fixed.

^ permalink raw reply	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2023-07-07  8:17 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <bug-87851-4@http.gcc.gnu.org/bugzilla/>
2021-05-14  9:50 ` [Bug fortran/87851] [9/10/11/12 Regression] Wrong return type for len_trim jakub at gcc dot gnu.org
2021-06-01  8:12 ` rguenth at gcc dot gnu.org
2021-11-18 22:35 ` anlauf at gcc dot gnu.org
2021-11-19 19:48 ` anlauf at gcc dot gnu.org
2021-11-23 16:52 ` cvs-commit at gcc dot gnu.org
2021-11-24 19:51 ` cvs-commit at gcc dot gnu.org
2021-11-24 19:58 ` anlauf at gcc dot gnu.org
2022-05-27  9:39 ` [Bug fortran/87851] [10/11/12/13 " rguenth at gcc dot gnu.org
2022-06-28 10:36 ` jakub at gcc dot gnu.org
2023-05-09 18:56 ` [Bug fortran/87851] [10 " anlauf at gcc dot gnu.org
2023-07-07  8:17 ` rguenth at gcc dot gnu.org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).