public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug tree-optimization/88240] [8/9/10/11 Regression] Potential optimization bug: invalid pre-load of floating-point value could cause SIGFPE-underflow if value is integer
       [not found] <bug-88240-4@http.gcc.gnu.org/bugzilla/>
@ 2020-08-04  9:29 ` rguenth at gcc dot gnu.org
  2020-08-04 13:29 ` cvs-commit at gcc dot gnu.org
                   ` (6 subsequent siblings)
  7 siblings, 0 replies; 8+ messages in thread
From: rguenth at gcc dot gnu.org @ 2020-08-04  9:29 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88240

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |drh at sqlite dot org

--- Comment #16 from Richard Biener <rguenth at gcc dot gnu.org> ---
*** Bug 96270 has been marked as a duplicate of this bug. ***

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [Bug tree-optimization/88240] [8/9/10/11 Regression] Potential optimization bug: invalid pre-load of floating-point value could cause SIGFPE-underflow if value is integer
       [not found] <bug-88240-4@http.gcc.gnu.org/bugzilla/>
  2020-08-04  9:29 ` [Bug tree-optimization/88240] [8/9/10/11 Regression] Potential optimization bug: invalid pre-load of floating-point value could cause SIGFPE-underflow if value is integer rguenth at gcc dot gnu.org
@ 2020-08-04 13:29 ` cvs-commit at gcc dot gnu.org
  2020-08-04 13:30 ` [Bug tree-optimization/88240] [8/9/10 " rguenth at gcc dot gnu.org
                   ` (5 subsequent siblings)
  7 siblings, 0 replies; 8+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2020-08-04 13:29 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88240

--- Comment #17 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Richard Biener <rguenth@gcc.gnu.org>:

https://gcc.gnu.org/g:1af5cdd77985daf76130f527deac425c43df9f49

commit r11-2545-g1af5cdd77985daf76130f527deac425c43df9f49
Author: Richard Biener <rguenther@suse.de>
Date:   Tue Aug 4 14:10:45 2020 +0200

    tree-optimization/88240 - stopgap for floating point code-hoisting issues

    This adds a stopgap measure to avoid performing code-hoisting
    on mixed type loads when the load we'd insert in the hoisting
    position would be a floating point one.  This is because certain
    targets (hello x87) cannot perform floating point loads without
    possibly altering the bit representation and thus cannot be used
    in place of integral loads.

    2020-08-04  Richard Biener  <rguenther@suse.de>

            PR tree-optimization/88240
            * tree-ssa-sccvn.h (vn_reference_s::punned): New flag.
            * tree-ssa-sccvn.c (vn_reference_insert): Initialize punned.
            (vn_reference_insert_pieces): Likewise.
            (visit_reference_op_call): Likewise.
            (visit_reference_op_load): Track whether a ref was punned.
            * tree-ssa-pre.c (do_hoist_insertion): Refuse to perform hoist
            insertion on punned floating point loads.

            * gcc.target/i386/pr88240.c: New testcase.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [Bug tree-optimization/88240] [8/9/10 Regression] Potential optimization bug: invalid pre-load of floating-point value could cause SIGFPE-underflow if value is integer
       [not found] <bug-88240-4@http.gcc.gnu.org/bugzilla/>
  2020-08-04  9:29 ` [Bug tree-optimization/88240] [8/9/10/11 Regression] Potential optimization bug: invalid pre-load of floating-point value could cause SIGFPE-underflow if value is integer rguenth at gcc dot gnu.org
  2020-08-04 13:29 ` cvs-commit at gcc dot gnu.org
@ 2020-08-04 13:30 ` rguenth at gcc dot gnu.org
  2020-09-01  9:26 ` cvs-commit at gcc dot gnu.org
                   ` (4 subsequent siblings)
  7 siblings, 0 replies; 8+ messages in thread
From: rguenth at gcc dot gnu.org @ 2020-08-04 13:30 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88240

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[8/9/10/11 Regression]      |[8/9/10 Regression]
                   |Potential optimization bug: |Potential optimization bug:
                   |invalid pre-load of         |invalid pre-load of
                   |floating-point value could  |floating-point value could
                   |cause SIGFPE-underflow if   |cause SIGFPE-underflow if
                   |value is integer            |value is integer
             Blocks|96457                       |

--- Comment #18 from Richard Biener <rguenth at gcc dot gnu.org> ---
So this is a reasonable stop-gap solution for branches, now also pushed to
trunk.  I'll see if I can come up with something more sensible for trunk.


Referenced Bugs:

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96457
[Bug 96457] PRE gets confused by punned load handling

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [Bug tree-optimization/88240] [8/9/10 Regression] Potential optimization bug: invalid pre-load of floating-point value could cause SIGFPE-underflow if value is integer
       [not found] <bug-88240-4@http.gcc.gnu.org/bugzilla/>
                   ` (2 preceding siblings ...)
  2020-08-04 13:30 ` [Bug tree-optimization/88240] [8/9/10 " rguenth at gcc dot gnu.org
@ 2020-09-01  9:26 ` cvs-commit at gcc dot gnu.org
  2021-05-14  9:50 ` [Bug tree-optimization/88240] [9 " jakub at gcc dot gnu.org
                   ` (3 subsequent siblings)
  7 siblings, 0 replies; 8+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2020-09-01  9:26 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88240

--- Comment #19 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-10 branch has been updated by Richard Biener
<rguenth@gcc.gnu.org>:

https://gcc.gnu.org/g:7442a775817db6065b8eed4d9d9f57611c7d09aa

commit r10-8695-g7442a775817db6065b8eed4d9d9f57611c7d09aa
Author: Richard Biener <rguenther@suse.de>
Date:   Tue Aug 4 14:10:45 2020 +0200

    tree-optimization/88240 - stopgap for floating point code-hoisting issues

    This adds a stopgap measure to avoid performing code-hoisting
    on mixed type loads when the load we'd insert in the hoisting
    position would be a floating point one.  This is because certain
    targets (hello x87) cannot perform floating point loads without
    possibly altering the bit representation and thus cannot be used
    in place of integral loads.

    2020-08-04  Richard Biener  <rguenther@suse.de>

            PR tree-optimization/88240
            * tree-ssa-sccvn.h (vn_reference_s::punned): New flag.
            * tree-ssa-sccvn.c (vn_reference_insert): Initialize punned.
            (vn_reference_insert_pieces): Likewise.
            (visit_reference_op_call): Likewise.
            (visit_reference_op_load): Track whether a ref was punned.
            * tree-ssa-pre.c (do_hoist_insertion): Refuse to perform hoist
            insertion on punned floating point loads.

            * gcc.target/i386/pr88240.c: New testcase.

    (cherry picked from commit 1af5cdd77985daf76130f527deac425c43df9f49)

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [Bug tree-optimization/88240] [9 Regression] Potential optimization bug: invalid pre-load of floating-point value could cause SIGFPE-underflow if value is integer
       [not found] <bug-88240-4@http.gcc.gnu.org/bugzilla/>
                   ` (3 preceding siblings ...)
  2020-09-01  9:26 ` cvs-commit at gcc dot gnu.org
@ 2021-05-14  9:50 ` jakub at gcc dot gnu.org
  2021-05-18  7:05 ` cvs-commit at gcc dot gnu.org
                   ` (2 subsequent siblings)
  7 siblings, 0 replies; 8+ messages in thread
From: jakub at gcc dot gnu.org @ 2021-05-14  9:50 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88240

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|8.5                         |9.4

--- Comment #20 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
GCC 8 branch is being closed.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [Bug tree-optimization/88240] [9 Regression] Potential optimization bug: invalid pre-load of floating-point value could cause SIGFPE-underflow if value is integer
       [not found] <bug-88240-4@http.gcc.gnu.org/bugzilla/>
                   ` (4 preceding siblings ...)
  2021-05-14  9:50 ` [Bug tree-optimization/88240] [9 " jakub at gcc dot gnu.org
@ 2021-05-18  7:05 ` cvs-commit at gcc dot gnu.org
  2021-05-18  7:06 ` rguenth at gcc dot gnu.org
  2021-05-20 18:44 ` patrickdepinguin at gmail dot com
  7 siblings, 0 replies; 8+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2021-05-18  7:05 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88240

--- Comment #21 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-9 branch has been updated by Richard Biener
<rguenth@gcc.gnu.org>:

https://gcc.gnu.org/g:009a8566d8ac5cc6ab1604716ba43d3c0bd99b64

commit r9-9537-g009a8566d8ac5cc6ab1604716ba43d3c0bd99b64
Author: Richard Biener <rguenther@suse.de>
Date:   Tue Aug 4 14:10:45 2020 +0200

    tree-optimization/88240 - stopgap for floating point code-hoisting issues

    This adds a stopgap measure to avoid performing code-hoisting
    on mixed type loads when the load we'd insert in the hoisting
    position would be a floating point one.  This is because certain
    targets (hello x87) cannot perform floating point loads without
    possibly altering the bit representation and thus cannot be used
    in place of integral loads.

    2020-08-04  Richard Biener  <rguenther@suse.de>

            PR tree-optimization/88240
            * tree-ssa-sccvn.h (vn_reference_s::punned): New flag.
            * tree-ssa-sccvn.c (vn_reference_insert): Initialize punned.
            (vn_reference_insert_pieces): Likewise.
            (visit_reference_op_call): Likewise.
            (visit_reference_op_load): Track whether a ref was punned.
            * tree-ssa-pre.c (do_hoist_insertion): Refuse to perform hoist
            insertion on punned floating point loads.

            * gcc.target/i386/pr88240.c: New testcase.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [Bug tree-optimization/88240] [9 Regression] Potential optimization bug: invalid pre-load of floating-point value could cause SIGFPE-underflow if value is integer
       [not found] <bug-88240-4@http.gcc.gnu.org/bugzilla/>
                   ` (5 preceding siblings ...)
  2021-05-18  7:05 ` cvs-commit at gcc dot gnu.org
@ 2021-05-18  7:06 ` rguenth at gcc dot gnu.org
  2021-05-20 18:44 ` patrickdepinguin at gmail dot com
  7 siblings, 0 replies; 8+ messages in thread
From: rguenth at gcc dot gnu.org @ 2021-05-18  7:06 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88240

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED
      Known to fail|                            |9.3.0
      Known to work|                            |9.3.1

--- Comment #22 from Richard Biener <rguenth at gcc dot gnu.org> ---
Fixed.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [Bug tree-optimization/88240] [9 Regression] Potential optimization bug: invalid pre-load of floating-point value could cause SIGFPE-underflow if value is integer
       [not found] <bug-88240-4@http.gcc.gnu.org/bugzilla/>
                   ` (6 preceding siblings ...)
  2021-05-18  7:06 ` rguenth at gcc dot gnu.org
@ 2021-05-20 18:44 ` patrickdepinguin at gmail dot com
  7 siblings, 0 replies; 8+ messages in thread
From: patrickdepinguin at gmail dot com @ 2021-05-20 18:44 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88240

--- Comment #23 from Thomas De Schampheleire <patrickdepinguin at gmail dot com> ---
Thanks a lot!

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2021-05-20 18:44 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <bug-88240-4@http.gcc.gnu.org/bugzilla/>
2020-08-04  9:29 ` [Bug tree-optimization/88240] [8/9/10/11 Regression] Potential optimization bug: invalid pre-load of floating-point value could cause SIGFPE-underflow if value is integer rguenth at gcc dot gnu.org
2020-08-04 13:29 ` cvs-commit at gcc dot gnu.org
2020-08-04 13:30 ` [Bug tree-optimization/88240] [8/9/10 " rguenth at gcc dot gnu.org
2020-09-01  9:26 ` cvs-commit at gcc dot gnu.org
2021-05-14  9:50 ` [Bug tree-optimization/88240] [9 " jakub at gcc dot gnu.org
2021-05-18  7:05 ` cvs-commit at gcc dot gnu.org
2021-05-18  7:06 ` rguenth at gcc dot gnu.org
2021-05-20 18:44 ` patrickdepinguin at gmail dot com

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).