* [Bug libstdc++/88881] std::filesystem::status gives bad results on mingw32
[not found] <bug-88881-4@http.gcc.gnu.org/bugzilla/>
@ 2020-11-27 13:55 ` redi at gcc dot gnu.org
2020-11-27 14:00 ` redi at gcc dot gnu.org
` (14 subsequent siblings)
15 siblings, 0 replies; 16+ messages in thread
From: redi at gcc dot gnu.org @ 2020-11-27 13:55 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88881
--- Comment #12 from Jonathan Wakely <redi at gcc dot gnu.org> ---
*** Bug 98035 has been marked as a duplicate of this bug. ***
^ permalink raw reply [flat|nested] 16+ messages in thread* [Bug libstdc++/88881] std::filesystem::status gives bad results on mingw32
[not found] <bug-88881-4@http.gcc.gnu.org/bugzilla/>
2020-11-27 13:55 ` [Bug libstdc++/88881] std::filesystem::status gives bad results on mingw32 redi at gcc dot gnu.org
@ 2020-11-27 14:00 ` redi at gcc dot gnu.org
2020-11-27 14:01 ` redi at gcc dot gnu.org
` (13 subsequent siblings)
15 siblings, 0 replies; 16+ messages in thread
From: redi at gcc dot gnu.org @ 2020-11-27 14:00 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88881
Jonathan Wakely <redi at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |REOPENED
Resolution|FIXED |---
--- Comment #13 from Jonathan Wakely <redi at gcc dot gnu.org> ---
My fix for the trailing slash does:
#if _GLIBCXX_FILESYSTEM_IS_WINDOWS
#if ! defined __MINGW64_VERSION_MAJOR || __MINGW64_VERSION_MAJOR < 6
// stat() fails if there's a trailing slash (PR 88881)
I'm seeing status("./") fail with mingw64 6.0.0 so apparently the workaround is
still needed.
^ permalink raw reply [flat|nested] 16+ messages in thread* [Bug libstdc++/88881] std::filesystem::status gives bad results on mingw32
[not found] <bug-88881-4@http.gcc.gnu.org/bugzilla/>
2020-11-27 13:55 ` [Bug libstdc++/88881] std::filesystem::status gives bad results on mingw32 redi at gcc dot gnu.org
2020-11-27 14:00 ` redi at gcc dot gnu.org
@ 2020-11-27 14:01 ` redi at gcc dot gnu.org
2020-11-27 14:32 ` redi at gcc dot gnu.org
` (12 subsequent siblings)
15 siblings, 0 replies; 16+ messages in thread
From: redi at gcc dot gnu.org @ 2020-11-27 14:01 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88881
Jonathan Wakely <redi at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|tree-ssa |9.4
^ permalink raw reply [flat|nested] 16+ messages in thread* [Bug libstdc++/88881] std::filesystem::status gives bad results on mingw32
[not found] <bug-88881-4@http.gcc.gnu.org/bugzilla/>
` (2 preceding siblings ...)
2020-11-27 14:01 ` redi at gcc dot gnu.org
@ 2020-11-27 14:32 ` redi at gcc dot gnu.org
2021-02-10 16:57 ` cvs-commit at gcc dot gnu.org
` (11 subsequent siblings)
15 siblings, 0 replies; 16+ messages in thread
From: redi at gcc dot gnu.org @ 2020-11-27 14:32 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88881
--- Comment #14 from Jonathan Wakely <redi at gcc dot gnu.org> ---
It looks like _stat and _wstat were fixed, but not _wstat64 which is what we
use.
^ permalink raw reply [flat|nested] 16+ messages in thread* [Bug libstdc++/88881] std::filesystem::status gives bad results on mingw32
[not found] <bug-88881-4@http.gcc.gnu.org/bugzilla/>
` (3 preceding siblings ...)
2020-11-27 14:32 ` redi at gcc dot gnu.org
@ 2021-02-10 16:57 ` cvs-commit at gcc dot gnu.org
2021-02-12 15:50 ` cvs-commit at gcc dot gnu.org
` (10 subsequent siblings)
15 siblings, 0 replies; 16+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2021-02-10 16:57 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88881
--- Comment #15 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jonathan Wakely <redi@gcc.gnu.org>:
https://gcc.gnu.org/g:3df5b249b3c81e95cdcb293a388155ae5b168f9e
commit r11-7174-g3df5b249b3c81e95cdcb293a388155ae5b168f9e
Author: Jonathan Wakely <jwakely@redhat.com>
Date: Wed Feb 10 16:51:34 2021 +0000
libstdc++: Re-enable workaround for _wstat64 bug [PR 88881]
This wasn't fixed upstream for mingw-w64 so we still need the
workaround.
libstdc++-v3/ChangeLog:
PR libstdc++/88881
* src/c++17/fs_ops.cc (fs::status): Re-enable workaround.
^ permalink raw reply [flat|nested] 16+ messages in thread* [Bug libstdc++/88881] std::filesystem::status gives bad results on mingw32
[not found] <bug-88881-4@http.gcc.gnu.org/bugzilla/>
` (4 preceding siblings ...)
2021-02-10 16:57 ` cvs-commit at gcc dot gnu.org
@ 2021-02-12 15:50 ` cvs-commit at gcc dot gnu.org
2021-03-29 20:02 ` cvs-commit at gcc dot gnu.org
` (9 subsequent siblings)
15 siblings, 0 replies; 16+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2021-02-12 15:50 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88881
--- Comment #16 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jonathan Wakely <redi@gcc.gnu.org>:
https://gcc.gnu.org/g:b7210405ed8eb5fd723b2c99960dcc5f0aec89b4
commit r11-7222-gb7210405ed8eb5fd723b2c99960dcc5f0aec89b4
Author: Jonathan Wakely <jwakely@redhat.com>
Date: Wed Feb 10 16:51:34 2021 +0000
libstdc++: Re-enable workaround for _wstat64 bug, again [PR 88881]
I forgot that the workaround is present in both filesystem::status and
filesystem::symlink_status. This restores it in the latter.
libstdc++-v3/ChangeLog:
PR libstdc++/88881
* src/c++17/fs_ops.cc (fs::symlink_status): Re-enable workaround.
^ permalink raw reply [flat|nested] 16+ messages in thread* [Bug libstdc++/88881] std::filesystem::status gives bad results on mingw32
[not found] <bug-88881-4@http.gcc.gnu.org/bugzilla/>
` (5 preceding siblings ...)
2021-02-12 15:50 ` cvs-commit at gcc dot gnu.org
@ 2021-03-29 20:02 ` cvs-commit at gcc dot gnu.org
2021-03-29 20:02 ` cvs-commit at gcc dot gnu.org
` (8 subsequent siblings)
15 siblings, 0 replies; 16+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2021-03-29 20:02 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88881
--- Comment #17 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-10 branch has been updated by Jonathan Wakely
<redi@gcc.gnu.org>:
https://gcc.gnu.org/g:8455158044503a25ebb044428be2ddc83d2b0473
commit r10-9582-g8455158044503a25ebb044428be2ddc83d2b0473
Author: Jonathan Wakely <jwakely@redhat.com>
Date: Wed Feb 10 16:51:34 2021 +0000
libstdc++: Re-enable workaround for _wstat64 bug [PR 88881]
This wasn't fixed upstream for mingw-w64 so we still need the
workaround.
libstdc++-v3/ChangeLog:
PR libstdc++/88881
* src/c++17/fs_ops.cc (fs::status): Re-enable workaround.
(cherry picked from commit 3df5b249b3c81e95cdcb293a388155ae5b168f9e)
^ permalink raw reply [flat|nested] 16+ messages in thread* [Bug libstdc++/88881] std::filesystem::status gives bad results on mingw32
[not found] <bug-88881-4@http.gcc.gnu.org/bugzilla/>
` (6 preceding siblings ...)
2021-03-29 20:02 ` cvs-commit at gcc dot gnu.org
@ 2021-03-29 20:02 ` cvs-commit at gcc dot gnu.org
2021-03-29 20:05 ` redi at gcc dot gnu.org
` (7 subsequent siblings)
15 siblings, 0 replies; 16+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2021-03-29 20:02 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88881
--- Comment #18 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-10 branch has been updated by Jonathan Wakely
<redi@gcc.gnu.org>:
https://gcc.gnu.org/g:bad3463f257019946d8b17d6956ca058aef88eae
commit r10-9583-gbad3463f257019946d8b17d6956ca058aef88eae
Author: Jonathan Wakely <jwakely@redhat.com>
Date: Wed Feb 10 16:51:34 2021 +0000
libstdc++: Re-enable workaround for _wstat64 bug, again [PR 88881]
I forgot that the workaround is present in both filesystem::status and
filesystem::symlink_status. This restores it in the latter.
libstdc++-v3/ChangeLog:
PR libstdc++/88881
* src/c++17/fs_ops.cc (fs::symlink_status): Re-enable workaround.
(cherry picked from commit b7210405ed8eb5fd723b2c99960dcc5f0aec89b4)
^ permalink raw reply [flat|nested] 16+ messages in thread* [Bug libstdc++/88881] std::filesystem::status gives bad results on mingw32
[not found] <bug-88881-4@http.gcc.gnu.org/bugzilla/>
` (7 preceding siblings ...)
2021-03-29 20:02 ` cvs-commit at gcc dot gnu.org
@ 2021-03-29 20:05 ` redi at gcc dot gnu.org
2021-06-01 8:12 ` rguenth at gcc dot gnu.org
` (6 subsequent siblings)
15 siblings, 0 replies; 16+ messages in thread
From: redi at gcc dot gnu.org @ 2021-03-29 20:05 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88881
--- Comment #19 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Re-fixed for 10.3 as well
^ permalink raw reply [flat|nested] 16+ messages in thread* [Bug libstdc++/88881] std::filesystem::status gives bad results on mingw32
[not found] <bug-88881-4@http.gcc.gnu.org/bugzilla/>
` (8 preceding siblings ...)
2021-03-29 20:05 ` redi at gcc dot gnu.org
@ 2021-06-01 8:12 ` rguenth at gcc dot gnu.org
2021-08-02 15:58 ` cvs-commit at gcc dot gnu.org
` (5 subsequent siblings)
15 siblings, 0 replies; 16+ messages in thread
From: rguenth at gcc dot gnu.org @ 2021-06-01 8:12 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88881
Richard Biener <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|9.4 |9.5
--- Comment #20 from Richard Biener <rguenth at gcc dot gnu.org> ---
GCC 9.4 is being released, retargeting bugs to GCC 9.5.
^ permalink raw reply [flat|nested] 16+ messages in thread* [Bug libstdc++/88881] std::filesystem::status gives bad results on mingw32
[not found] <bug-88881-4@http.gcc.gnu.org/bugzilla/>
` (9 preceding siblings ...)
2021-06-01 8:12 ` rguenth at gcc dot gnu.org
@ 2021-08-02 15:58 ` cvs-commit at gcc dot gnu.org
2021-08-02 15:58 ` cvs-commit at gcc dot gnu.org
` (4 subsequent siblings)
15 siblings, 0 replies; 16+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2021-08-02 15:58 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88881
--- Comment #21 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-9 branch has been updated by Jonathan Wakely
<redi@gcc.gnu.org>:
https://gcc.gnu.org/g:1a96bfe35fec4c425d6f5fbb9c539386e39ff3e4
commit r9-9656-g1a96bfe35fec4c425d6f5fbb9c539386e39ff3e4
Author: Jonathan Wakely <jwakely@redhat.com>
Date: Wed Feb 10 16:51:34 2021 +0000
libstdc++: Re-enable workaround for _wstat64 bug [PR 88881]
This wasn't fixed upstream for mingw-w64 so we still need the
workaround.
libstdc++-v3/ChangeLog:
PR libstdc++/88881
* src/c++17/fs_ops.cc (fs::status): Re-enable workaround.
(cherry picked from commit 3df5b249b3c81e95cdcb293a388155ae5b168f9e)
^ permalink raw reply [flat|nested] 16+ messages in thread* [Bug libstdc++/88881] std::filesystem::status gives bad results on mingw32
[not found] <bug-88881-4@http.gcc.gnu.org/bugzilla/>
` (10 preceding siblings ...)
2021-08-02 15:58 ` cvs-commit at gcc dot gnu.org
@ 2021-08-02 15:58 ` cvs-commit at gcc dot gnu.org
2021-08-02 15:58 ` redi at gcc dot gnu.org
` (3 subsequent siblings)
15 siblings, 0 replies; 16+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2021-08-02 15:58 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88881
--- Comment #22 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-9 branch has been updated by Jonathan Wakely
<redi@gcc.gnu.org>:
https://gcc.gnu.org/g:4178e8c049e4ef366335b661197e53b3efbed877
commit r9-9657-g4178e8c049e4ef366335b661197e53b3efbed877
Author: Jonathan Wakely <jwakely@redhat.com>
Date: Wed Feb 10 16:51:34 2021 +0000
libstdc++: Re-enable workaround for _wstat64 bug, again [PR 88881]
I forgot that the workaround is present in both filesystem::status and
filesystem::symlink_status. This restores it in the latter.
libstdc++-v3/ChangeLog:
PR libstdc++/88881
* src/c++17/fs_ops.cc (fs::symlink_status): Re-enable workaround.
(cherry picked from commit b7210405ed8eb5fd723b2c99960dcc5f0aec89b4)
^ permalink raw reply [flat|nested] 16+ messages in thread* [Bug libstdc++/88881] std::filesystem::status gives bad results on mingw32
[not found] <bug-88881-4@http.gcc.gnu.org/bugzilla/>
` (11 preceding siblings ...)
2021-08-02 15:58 ` cvs-commit at gcc dot gnu.org
@ 2021-08-02 15:58 ` redi at gcc dot gnu.org
2022-06-30 13:16 ` cvs-commit at gcc dot gnu.org
` (2 subsequent siblings)
15 siblings, 0 replies; 16+ messages in thread
From: redi at gcc dot gnu.org @ 2021-08-02 15:58 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88881
Jonathan Wakely <redi at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|REOPENED |RESOLVED
Resolution|--- |FIXED
--- Comment #23 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Fixed for 9.5 too.
^ permalink raw reply [flat|nested] 16+ messages in thread* [Bug libstdc++/88881] std::filesystem::status gives bad results on mingw32
[not found] <bug-88881-4@http.gcc.gnu.org/bugzilla/>
` (12 preceding siblings ...)
2021-08-02 15:58 ` redi at gcc dot gnu.org
@ 2022-06-30 13:16 ` cvs-commit at gcc dot gnu.org
2022-07-21 11:16 ` cvs-commit at gcc dot gnu.org
2022-07-22 7:07 ` cvs-commit at gcc dot gnu.org
15 siblings, 0 replies; 16+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2022-06-30 13:16 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88881
--- Comment #24 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jonathan Wakely <redi@gcc.gnu.org>:
https://gcc.gnu.org/g:6c96b14a19a9e6c365eacc59868a866b99f9786d
commit r13-1365-g6c96b14a19a9e6c365eacc59868a866b99f9786d
Author: Jonathan Wakely <jwakely@redhat.com>
Date: Tue Jun 28 15:56:30 2022 +0100
libstdc++: Fix experimental::filesystem::status on Windows [PR88881]
Although the Filesystem TS isn't properly supported on Windows (unlike
the C++17 Filesystem lib), most tests do pass. Two of the failures are
due to PR 88881 which was only fixed for std::filesystem not the TS.
This applies the fix to the TS implementation too.
libstdc++-v3/ChangeLog:
PR libstdc++/88881
* src/filesystem/ops.cc (has_trailing_slash): New helper
function.
(fs::status): Strip trailing slashes.
(fs::symlink_status): Likewise.
*
testsuite/experimental/filesystem/operations/temp_directory_path.cc:
Clean the environment before each test and use TMP instead of
TMPDIR so the test passes on Windows.
^ permalink raw reply [flat|nested] 16+ messages in thread* [Bug libstdc++/88881] std::filesystem::status gives bad results on mingw32
[not found] <bug-88881-4@http.gcc.gnu.org/bugzilla/>
` (13 preceding siblings ...)
2022-06-30 13:16 ` cvs-commit at gcc dot gnu.org
@ 2022-07-21 11:16 ` cvs-commit at gcc dot gnu.org
2022-07-22 7:07 ` cvs-commit at gcc dot gnu.org
15 siblings, 0 replies; 16+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2022-07-21 11:16 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88881
--- Comment #25 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-12 branch has been updated by Jonathan Wakely
<redi@gcc.gnu.org>:
https://gcc.gnu.org/g:f3ff78e3db0fc18127dac4fe3eaf113d0c5ddd01
commit r12-8590-gf3ff78e3db0fc18127dac4fe3eaf113d0c5ddd01
Author: Jonathan Wakely <jwakely@redhat.com>
Date: Tue Jun 28 15:56:30 2022 +0100
libstdc++: Fix experimental::filesystem::status on Windows [PR88881]
Although the Filesystem TS isn't properly supported on Windows (unlike
the C++17 Filesystem lib), most tests do pass. Two of the failures are
due to PR 88881 which was only fixed for std::filesystem not the TS.
This applies the fix to the TS implementation too.
libstdc++-v3/ChangeLog:
PR libstdc++/88881
* src/filesystem/ops.cc (has_trailing_slash): New helper
function.
(fs::status): Strip trailing slashes.
(fs::symlink_status): Likewise.
*
testsuite/experimental/filesystem/operations/temp_directory_path.cc:
Clean the environment before each test and use TMP instead of
TMPDIR so the test passes on Windows.
(cherry picked from commit 6c96b14a19a9e6c365eacc59868a866b99f9786d)
^ permalink raw reply [flat|nested] 16+ messages in thread* [Bug libstdc++/88881] std::filesystem::status gives bad results on mingw32
[not found] <bug-88881-4@http.gcc.gnu.org/bugzilla/>
` (14 preceding siblings ...)
2022-07-21 11:16 ` cvs-commit at gcc dot gnu.org
@ 2022-07-22 7:07 ` cvs-commit at gcc dot gnu.org
15 siblings, 0 replies; 16+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2022-07-22 7:07 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88881
--- Comment #26 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-11 branch has been updated by Jonathan Wakely
<redi@gcc.gnu.org>:
https://gcc.gnu.org/g:66e876a91b5d5c1a0c5067f2d8f1d531da3a81f8
commit r11-10161-g66e876a91b5d5c1a0c5067f2d8f1d531da3a81f8
Author: Jonathan Wakely <jwakely@redhat.com>
Date: Tue Jun 28 15:56:30 2022 +0100
libstdc++: Fix experimental::filesystem::status on Windows [PR88881]
Although the Filesystem TS isn't properly supported on Windows (unlike
the C++17 Filesystem lib), most tests do pass. Two of the failures are
due to PR 88881 which was only fixed for std::filesystem not the TS.
This applies the fix to the TS implementation too.
libstdc++-v3/ChangeLog:
PR libstdc++/88881
* src/filesystem/ops.cc (has_trailing_slash): New helper
function.
(fs::status): Strip trailing slashes.
(fs::symlink_status): Likewise.
*
testsuite/experimental/filesystem/operations/temp_directory_path.cc:
Clean the environment before each test and use TMP instead of
TMPDIR so the test passes on Windows.
(cherry picked from commit 6c96b14a19a9e6c365eacc59868a866b99f9786d)
^ permalink raw reply [flat|nested] 16+ messages in thread