[Bug c++/89224] subscript of const vector is considered a rvalue

[Bug c++/89224] subscript of const vector is considered a rvalue

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=89224

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |88670
      Known to fail|                            |7.1.0
           Keywords|                            |accepts-invalid
            Summary|subscript of NEON intrinsic |subscript of const vector
                   |discards const              |is considered a rvalue
          Component|target                      |c++

--- Comment #1 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Actually this is a generic vector C++ issue:

typedef __attribute__((vector_size(16))) unsigned char  __Int8x8_t;

template <class T>
void g(T &x) {
  x = 1;
}
void f(const __Int8x8_t &x) {
  g(x[0]);
}


Referenced Bugs:

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88670
[Bug 88670] [meta-bug] generic vector extension issues

[Bug c++/89224] [9/10/11/12 Regregression] subscript of const vector is considered a rvalue

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=89224

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |9.5
            Summary|subscript of const vector   |[9/10/11/12 Regregression]
                   |is considered a rvalue      |subscript of const vector
                   |                            |is considered a rvalue
      Known to work|                            |5.1.0

[Bug c++/89224] [9/10/11/12 Regregression] subscript of const vector is considered a rvalue

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=89224

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2021-08-16
     Ever confirmed|0                           |1

--- Comment #2 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
And it was rejected correctly in GCC 6.4.0:
<source>: In instantiation of 'void g(T&) [with T = const unsigned char]':
<source>:8:9:   required from here
<source>:5:5: error: assignment of read-only reference 'x'
   x = 1;
   ~~^~~

[Bug c++/89224] [9/10/11/12 Regregression] subscript of const vector has the wrong type

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=89224

--- Comment #3 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Refence in the f function is not needed:
typedef __attribute__((vector_size(16))) unsigned char  __Int8x8_t;

template <class T>
void g(T &x) {
  x = 1;
}
void f(const __Int8x8_t x) {
  g(x[0]);
}

[Bug c++/89224] [9/10/11/12 Regregression] subscript of const vector has the wrong type

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=89224

--- Comment #4 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Most likely caused by r7-987.

[Bug c++/89224] [9/10/11/12 Regregression] subscript of const vector has the wrong type

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=89224

--- Comment #5 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Here is another testcase which should be rejected, this time C++11 (rather than
C++98).
typedef __attribute__((vector_size(16))) unsigned char  __Int8x8_t;

void f(const __Int8x8_t x) {
  decltype(x[0]) a = x[0];
  a = 1;
}

[Bug c++/89224] [9/10/11/12 Regregression] subscript of const vector has the wrong type

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=89224

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |wrong-code

--- Comment #6 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
And here is a runtime test:
typedef __attribute__((vector_size(16))) unsigned char  __Int8x8_t;

template <class T>
void g(T &x) {
    __builtin_abort();
}
template <class T>
void g(const T &x) {
  __builtin_exit(0);
}
void f(const __Int8x8_t x) {
  g(x[0]);
}
int main(void)
{
    __Int8x8_t x ={};
    f(x);
}

[Bug c++/89224] [10/11/12 Regression] subscript of const vector has the wrong type

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=89224

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|9.5                         |10.4
            Summary|[9/10/11/12 Regregression]  |[10/11/12 Regression]
                   |subscript of const vector   |subscript of const vector
                   |has the wrong type          |has the wrong type

--- Comment #7 from Richard Biener <rguenth at gcc dot gnu.org> ---
GCC 9 branch is being closed.

[Bug c++/89224] [10/11/12 Regression] subscript of const vector has the wrong type

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=89224

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|10.4                        |10.5

--- Comment #8 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
GCC 10.4 is being released, retargeting bugs to GCC 10.5.

[Bug c++/89224] [10/11/12 Regression] subscript of const vector has the wrong type

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=89224

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|2022-01-29 00:00:00         |2022-7-26

--- Comment #9 from Richard Biener <rguenth at gcc dot gnu.org> ---
Reconfirmed.

[Bug c++/89224] [10/11/12/13 Regression] subscript of const vector has the wrong type

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=89224

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jason at gcc dot gnu.org,
                   |                            |rguenth at gcc dot gnu.org
           Priority|P3                          |P2

--- Comment #10 from Richard Biener <rguenth at gcc dot gnu.org> ---
The issue is likely that lvalue_kind of

 <parm_decl 0x7ffff7ff3180 x
    type <vector_type 0x7ffff6684bd0 __Int8x8_t
        type <integer_type 0x7ffff653b348 unsigned char public unsigned QI
            size <integer_cst 0x7ffff653d090 constant 8>
            unit-size <integer_cst 0x7ffff653d0a8 constant 1>
            align:8 warn_if_not_align:0 symtab:0 alias-set -1 canonical-type
0x7ffff653b348 precision:8 min <integer_cst 0x7ffff653d0c0 0> max <integer_cst
0x7ffff653d060 255>>
        readonly unsigned V16QI
        size <integer_cst 0x7ffff6517fd8 constant 128>
        unit-size <integer_cst 0x7ffff653d000 constant 16>
        align:128 warn_if_not_align:0 symtab:0 alias-set -1 canonical-type
0x7ffff6684c78 nunits:16>
    readonly used unsigned V16QI t.ii:7:25 size <integer_cst 0x7ffff6517fd8
128> unit-size <integer_cst 0x7ffff653d000 16>
    align:128 warn_if_not_align:0 context <function_decl 0x7ffff6687a00 f>
arg-type <vector_type 0x7ffff6684bd0 __Int8x8_t>>

returns clk_ordinary and thus convert_vector_to_array_for_subscript returns
false.

And that's because

214         case PARM_DECL:
215         case RESULT_DECL:
216         case PLACEHOLDER_EXPR:
217           return clk_ordinary;

we wrap the PARM_DECL in a VIEW_CONVERT_EXPR but that just gets stripped
here.

So maybe convert_vector_to_array_for_subscript is wrong in just using
lvalue_p?

I've went here just tracing cp_build_array_ref, otherwise I know nothing
about C++ or how the c-c++-common lvalue_p should behave here.

[Bug c++/89224] [11/12/13/14 Regression] subscript of const vector has the wrong type

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=89224

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|10.5                        |11.5

--- Comment #11 from Richard Biener <rguenth at gcc dot gnu.org> ---
GCC 10 branch is being closed.

[Bug c++/89224] [11/12/13/14 Regression] subscript of const vector has the wrong type

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=89224

--- Comment #12 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
>-      type = build_qualified_type (TREE_TYPE (type), TYPE_QUALS (type));

That part is missing it seems.
Let me see if I can fix this.

[Bug c++/89224] [11/12/13/14 Regression] subscript of const vector has the wrong type

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=89224

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|unassigned at gcc dot gnu.org      |pinskia at gcc dot gnu.org

--- Comment #13 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Ok, I have a simple fix:
```
diff --git a/gcc/c-family/c-common.cc b/gcc/c-family/c-common.cc
index e15eff698df..9d0e1ae574d 100644
--- a/gcc/c-family/c-common.cc
+++ b/gcc/c-family/c-common.cc
@@ -8949,9 +8949,10 @@ convert_vector_to_array_for_subscript (location_t loc,
          to not run into the gimplifiers premature setting of
DECL_GIMPLE_REG_P
         for function parameters.  */
       c_common_mark_addressable_vec (*vecp);
+      tree newinnertype = build_qualified_type (TREE_TYPE (type), TYPE_QUALS
(type));

       *vecp = build1 (VIEW_CONVERT_EXPR,
-                     build_array_type_nelts (TREE_TYPE (type),
+                     build_array_type_nelts (newinnertype,
                                              TYPE_VECTOR_SUBPARTS (type)),
                      *vecp);
     }
```

[Bug c++/89224] [11/12/13/14 Regression] subscript of const vector has the wrong type

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=89224

--- Comment #14 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Causes a few regressions though:
FAIL: g++.dg/cpp0x/constexpr-53094-1.C  -std=c++14 (internal compiler error: in
cxx_eval_array_reference, at cp/constexpr.cc:4458)

[Bug c++/89224] [11/12/13/14 Regression] subscript of const vector has the wrong type

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=89224

--- Comment #15 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
(In reply to Andrew Pinski from comment #14)
> Causes a few regressions though:
> FAIL: g++.dg/cpp0x/constexpr-53094-1.C  -std=c++14 (internal compiler error:
> in cxx_eval_array_reference, at cp/constexpr.cc:4458)

But the fix is simple, instead of just comparing the type itself, need to
compare TYPE_MAIN_VARIANT of those types.

[Bug c++/89224] [11/12/13/14 Regression] subscript of const vector has the wrong type

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=89224

--- Comment #16 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Patch posted:
https://gcc.gnu.org/pipermail/gcc-patches/2024-February/646115.html

[Bug c++/89224] [11/12/13/14/15 Regression] subscript of const vector has the wrong type

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=89224

--- Comment #17 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The trunk branch has been updated by Andrew Pinski <pinskia@gcc.gnu.org>:

https://gcc.gnu.org/g:4421d35167b3083e0f2e4c84c91fded09a30cf22

commit r15-309-g4421d35167b3083e0f2e4c84c91fded09a30cf22
Author: Andrew Pinski <quic_apinski@quicinc.com>
Date:   Tue Feb 20 13:38:28 2024 -0800

    c++/c-common: Fix convert_vector_to_array_for_subscript for qualified
vector types [PR89224]

    After r7-987-gf17a223de829cb, the access for the elements of a vector type
would lose the qualifiers.
    So if we had `constvector[0]`, the type of the element of the array would
not have const on it.
    This was due to a missing build_qualified_type for the inner type of the
vector when building the array type.
    We need to add back the call to build_qualified_type and now the access has
the correct qualifiers. So the
    overloads and even if it is a lvalue or rvalue is correctly done.

    Note we correctly now reject the testcase gcc.dg/pr83415.c which was
incorrectly accepted after r7-987-gf17a223de829cb.

    Built and tested for aarch64-linux-gnu.

            PR c++/89224

    gcc/c-family/ChangeLog:

            * c-common.cc (convert_vector_to_array_for_subscript): Call
build_qualified_type
            for the inner type.

    gcc/cp/ChangeLog:

            * constexpr.cc (cxx_eval_array_reference): Compare main variants
            for the vector/array types instead of the types directly.

    gcc/testsuite/ChangeLog:

            * g++.dg/torture/vector-subaccess-1.C: New test.
            * gcc.dg/pr83415.c: Change warning to error.

    Signed-off-by: Andrew Pinski <quic_apinski@quicinc.com>

[Bug c++/89224] [11/12/13/14/15 Regression] subscript of const vector has the wrong type

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=89224

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Known to work|                            |15.0

--- Comment #18 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Fixed on the trunk, backporting as approved right now.

[Bug c++/89224] [11/12/13/14/15 Regression] subscript of const vector has the wrong type

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=89224

--- Comment #19 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-14 branch has been updated by Andrew Pinski
<pinskia@gcc.gnu.org>:

https://gcc.gnu.org/g:cacc48014c7fdb888b4449830b567e5375dfb4e3

commit r14-10183-gcacc48014c7fdb888b4449830b567e5375dfb4e3
Author: Andrew Pinski <quic_apinski@quicinc.com>
Date:   Tue Feb 20 13:38:28 2024 -0800

    c++/c-common: Fix convert_vector_to_array_for_subscript for qualified
vector types [PR89224]

    After r7-987-gf17a223de829cb, the access for the elements of a vector type
would lose the qualifiers.
    So if we had `constvector[0]`, the type of the element of the array would
not have const on it.
    This was due to a missing build_qualified_type for the inner type of the
vector when building the array type.
    We need to add back the call to build_qualified_type and now the access has
the correct qualifiers. So the
    overloads and even if it is a lvalue or rvalue is correctly done.

    Note we correctly now reject the testcase gcc.dg/pr83415.c which was
incorrectly accepted after r7-987-gf17a223de829cb.

    Built and tested for aarch64-linux-gnu.

            PR c++/89224

    gcc/c-family/ChangeLog:

            * c-common.cc (convert_vector_to_array_for_subscript): Call
build_qualified_type
            for the inner type.

    gcc/cp/ChangeLog:

            * constexpr.cc (cxx_eval_array_reference): Compare main variants
            for the vector/array types instead of the types directly.

    gcc/testsuite/ChangeLog:

            * g++.dg/torture/vector-subaccess-1.C: New test.
            * gcc.dg/pr83415.c: Change warning to error.

    Signed-off-by: Andrew Pinski <quic_apinski@quicinc.com>
    (cherry picked from commit 4421d35167b3083e0f2e4c84c91fded09a30cf22)

[Bug c++/89224] [11/12/13/14/15 Regression] subscript of const vector has the wrong type

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=89224

--- Comment #20 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-13 branch has been updated by Andrew Pinski
<pinskia@gcc.gnu.org>:

https://gcc.gnu.org/g:f5d9eef6507f36692066c0934d9f8c9d462e698f

commit r13-8713-gf5d9eef6507f36692066c0934d9f8c9d462e698f
Author: Andrew Pinski <quic_apinski@quicinc.com>
Date:   Tue Feb 20 13:38:28 2024 -0800

    c++/c-common: Fix convert_vector_to_array_for_subscript for qualified
vector types [PR89224]

    After r7-987-gf17a223de829cb, the access for the elements of a vector type
would lose the qualifiers.
    So if we had `constvector[0]`, the type of the element of the array would
not have const on it.
    This was due to a missing build_qualified_type for the inner type of the
vector when building the array type.
    We need to add back the call to build_qualified_type and now the access has
the correct qualifiers. So the
    overloads and even if it is a lvalue or rvalue is correctly done.

    Note we correctly now reject the testcase gcc.dg/pr83415.c which was
incorrectly accepted after r7-987-gf17a223de829cb.

    Built and tested for aarch64-linux-gnu.

            PR c++/89224

    gcc/c-family/ChangeLog:

            * c-common.cc (convert_vector_to_array_for_subscript): Call
build_qualified_type
            for the inner type.

    gcc/cp/ChangeLog:

            * constexpr.cc (cxx_eval_array_reference): Compare main variants
            for the vector/array types instead of the types directly.

    gcc/testsuite/ChangeLog:

            * g++.dg/torture/vector-subaccess-1.C: New test.
            * gcc.dg/pr83415.c: Change warning to error.

    Signed-off-by: Andrew Pinski <quic_apinski@quicinc.com>
    (cherry picked from commit 4421d35167b3083e0f2e4c84c91fded09a30cf22)

[Bug c++/89224] [11/12/13/14/15 Regression] subscript of const vector has the wrong type

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=89224

--- Comment #21 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-12 branch has been updated by Andrew Pinski
<pinskia@gcc.gnu.org>:

https://gcc.gnu.org/g:315f8a474eb1a9b2d213aa650bdb132c78546264

commit r12-10420-g315f8a474eb1a9b2d213aa650bdb132c78546264
Author: Andrew Pinski <quic_apinski@quicinc.com>
Date:   Tue Feb 20 13:38:28 2024 -0800

    c++/c-common: Fix convert_vector_to_array_for_subscript for qualified
vector types [PR89224]

    After r7-987-gf17a223de829cb, the access for the elements of a vector type
would lose the qualifiers.
    So if we had `constvector[0]`, the type of the element of the array would
not have const on it.
    This was due to a missing build_qualified_type for the inner type of the
vector when building the array type.
    We need to add back the call to build_qualified_type and now the access has
the correct qualifiers. So the
    overloads and even if it is a lvalue or rvalue is correctly done.

    Note we correctly now reject the testcase gcc.dg/pr83415.c which was
incorrectly accepted after r7-987-gf17a223de829cb.

    Built and tested for aarch64-linux-gnu.

            PR c++/89224

    gcc/c-family/ChangeLog:

            * c-common.cc (convert_vector_to_array_for_subscript): Call
build_qualified_type
            for the inner type.

    gcc/cp/ChangeLog:

            * constexpr.cc (cxx_eval_array_reference): Compare main variants
            for the vector/array types instead of the types directly.

    gcc/testsuite/ChangeLog:

            * g++.dg/torture/vector-subaccess-1.C: New test.
            * gcc.dg/pr83415.c: Change warning to error.

    Signed-off-by: Andrew Pinski <quic_apinski@quicinc.com>
    (cherry picked from commit 4421d35167b3083e0f2e4c84c91fded09a30cf22)

[Bug c++/89224] [11/12/13/14/15 Regression] subscript of const vector has the wrong type

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=89224

--- Comment #22 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-11 branch has been updated by Andrew Pinski
<pinskia@gcc.gnu.org>:

https://gcc.gnu.org/g:046aeffba336295fbdaf0e1ecf64b582d08f0aa6

commit r11-11419-g046aeffba336295fbdaf0e1ecf64b582d08f0aa6
Author: Andrew Pinski <quic_apinski@quicinc.com>
Date:   Tue Feb 20 13:38:28 2024 -0800

    c++/c-common: Fix convert_vector_to_array_for_subscript for qualified
vector types [PR89224]

    After r7-987-gf17a223de829cb, the access for the elements of a vector type
would lose the qualifiers.
    So if we had `constvector[0]`, the type of the element of the array would
not have const on it.
    This was due to a missing build_qualified_type for the inner type of the
vector when building the array type.
    We need to add back the call to build_qualified_type and now the access has
the correct qualifiers. So the
    overloads and even if it is a lvalue or rvalue is correctly done.

    Note we correctly now reject the testcase gcc.dg/pr83415.c which was
incorrectly accepted after r7-987-gf17a223de829cb.

    Built and tested for aarch64-linux-gnu.

            PR c++/89224

    gcc/c-family/ChangeLog:

            * c-common.c (convert_vector_to_array_for_subscript): Call
build_qualified_type
            for the inner type.

    gcc/cp/ChangeLog:

            * constexpr.c (cxx_eval_array_reference): Compare main variants
            for the vector/array types instead of the types directly.

    gcc/testsuite/ChangeLog:

            * g++.dg/torture/vector-subaccess-1.C: New test.
            * gcc.dg/pr83415.c: Change warning to error.

    Signed-off-by: Andrew Pinski <quic_apinski@quicinc.com>
    (cherry picked from commit 4421d35167b3083e0f2e4c84c91fded09a30cf22)

[Bug c++/89224] [11/12/13/14/15 Regression] subscript of const vector has the wrong type

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=89224

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Known to work|                            |11.4.1
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #23 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Fixed everywhere.

[Bug c++/89224] [11/12/13/14/15 Regression] subscript of const vector has the wrong type

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=89224

--- Comment #24 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:8fb65ec816ff8f0d529b6d30821abace4328c9a2

commit r15-340-g8fb65ec816ff8f0d529b6d30821abace4328c9a2
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Thu May 9 11:18:21 2024 +0200

    testsuite: Fix up vector-subaccess-1.C test for ia32 [PR89224]

    The test FAILs on i686-linux due to
    .../gcc/testsuite/g++.dg/torture/vector-subaccess-1.C:16:6: warning: SSE
vector argument without SSE enabled changes the ABI [-Wpsabi]
    excess warnings.

    This fixes it by adding -Wno-psabi, like commonly done in other tests.

    2024-05-09  Jakub Jelinek  <jakub@redhat.com>

            PR c++/89224
            * g++.dg/torture/vector-subaccess-1.C: Add -Wno-psabi as additional
            options.

[Bug c++/89224] [11/12/13/14/15 Regression] subscript of const vector has the wrong type

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=89224

--- Comment #25 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-14 branch has been updated by Jakub Jelinek
<jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:726e7a64edc22a33a5f495698722ba797793edca

commit r14-10189-g726e7a64edc22a33a5f495698722ba797793edca
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Thu May 9 11:18:21 2024 +0200

    testsuite: Fix up vector-subaccess-1.C test for ia32 [PR89224]

    The test FAILs on i686-linux due to
    .../gcc/testsuite/g++.dg/torture/vector-subaccess-1.C:16:6: warning: SSE
vector argument without SSE enabled changes the ABI [-Wpsabi]
    excess warnings.

    This fixes it by adding -Wno-psabi, like commonly done in other tests.

    2024-05-09  Jakub Jelinek  <jakub@redhat.com>

            PR c++/89224
            * g++.dg/torture/vector-subaccess-1.C: Add -Wno-psabi as additional
            options.

    (cherry picked from commit 8fb65ec816ff8f0d529b6d30821abace4328c9a2)

[Bug c++/89224] [11/12/13/14/15 Regression] subscript of const vector has the wrong type

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=89224

--- Comment #26 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-13 branch has been updated by Jakub Jelinek
<jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:6f7674a558aaa0c7b16657c35666ad9b12e1c219

commit r13-8737-g6f7674a558aaa0c7b16657c35666ad9b12e1c219
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Thu May 9 11:18:21 2024 +0200

    testsuite: Fix up vector-subaccess-1.C test for ia32 [PR89224]

    The test FAILs on i686-linux due to
    .../gcc/testsuite/g++.dg/torture/vector-subaccess-1.C:16:6: warning: SSE
vector argument without SSE enabled changes the ABI [-Wpsabi]
    excess warnings.

    This fixes it by adding -Wno-psabi, like commonly done in other tests.

    2024-05-09  Jakub Jelinek  <jakub@redhat.com>

            PR c++/89224
            * g++.dg/torture/vector-subaccess-1.C: Add -Wno-psabi as additional
            options.

    (cherry picked from commit 8fb65ec816ff8f0d529b6d30821abace4328c9a2)

[Bug c++/89224] [11/12/13/14/15 Regression] subscript of const vector has the wrong type

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=89224

--- Comment #27 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-12 branch has been updated by Jakub Jelinek
<jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:ffa41c65a375746fd26c2d620e634fb162726dfc

commit r12-10435-gffa41c65a375746fd26c2d620e634fb162726dfc
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Thu May 9 11:18:21 2024 +0200

    testsuite: Fix up vector-subaccess-1.C test for ia32 [PR89224]

    The test FAILs on i686-linux due to
    .../gcc/testsuite/g++.dg/torture/vector-subaccess-1.C:16:6: warning: SSE
vector argument without SSE enabled changes the ABI [-Wpsabi]
    excess warnings.

    This fixes it by adding -Wno-psabi, like commonly done in other tests.

    2024-05-09  Jakub Jelinek  <jakub@redhat.com>

            PR c++/89224
            * g++.dg/torture/vector-subaccess-1.C: Add -Wno-psabi as additional
            options.

    (cherry picked from commit 8fb65ec816ff8f0d529b6d30821abace4328c9a2)

[Bug c++/89224] [11/12/13/14/15 Regression] subscript of const vector has the wrong type

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=89224

--- Comment #28 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-11 branch has been updated by Jakub Jelinek
<jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:e6c869372f0ca8b28ac63c7eb26fde35b53aba37

commit r11-11423-ge6c869372f0ca8b28ac63c7eb26fde35b53aba37
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Thu May 9 11:18:21 2024 +0200

    testsuite: Fix up vector-subaccess-1.C test for ia32 [PR89224]

    The test FAILs on i686-linux due to
    .../gcc/testsuite/g++.dg/torture/vector-subaccess-1.C:16:6: warning: SSE
vector argument without SSE enabled changes the ABI [-Wpsabi]
    excess warnings.

    This fixes it by adding -Wno-psabi, like commonly done in other tests.

    2024-05-09  Jakub Jelinek  <jakub@redhat.com>

            PR c++/89224
            * g++.dg/torture/vector-subaccess-1.C: Add -Wno-psabi as additional
            options.

    (cherry picked from commit 8fb65ec816ff8f0d529b6d30821abace4328c9a2)