[Bug tree-optimization/89263] Simplify bool expression to OR

[Bug tree-optimization/89263] Simplify bool expression to OR

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=89263

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sergey.ignatchenko at ithare dot c
                   |                            |om

--- Comment #4 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
*** Bug 85605 has been marked as a duplicate of this bug. ***

[Bug tree-optimization/89263] Simplify bool expression to OR

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=89263

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |25290
             Status|NEW                         |ASSIGNED

--- Comment #5 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Mine.  Depends on work for PR 25290 though.


Referenced Bugs:

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=25290
[Bug 25290] PHI-OPT could be rewritten so that is uses match

[Bug tree-optimization/89263] Simplify bool expression to OR

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=89263

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gabravier at gmail dot com

--- Comment #6 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
*** Bug 99069 has been marked as a duplicate of this bug. ***

[Bug tree-optimization/89263] Simplify bool expression to OR

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=89263

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |enhancement

[Bug tree-optimization/89263] Simplify bool expression to OR

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=89263

--- Comment #7 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
*** Bug 96923 has been marked as a duplicate of this bug. ***

[Bug tree-optimization/89263] Simplify bool expression to OR

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=89263

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ubizjak at gmail dot com

--- Comment #8 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
*** Bug 110087 has been marked as a duplicate of this bug. ***

[Bug tree-optimization/89263] Simplify bool expression to OR

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=89263

--- Comment #9 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Created attachment 55245
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=55245&action=edit
Patch where I need to add some more testcases

[Bug tree-optimization/89263] Simplify bool expression to OR

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=89263

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |https://gcc.gnu.org/piperma
                   |                            |il/gcc-patches/2023-June/62
                   |                            |0829.html

--- Comment #10 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Patch submitted:
https://gcc.gnu.org/pipermail/gcc-patches/2023-June/620829.html

[Bug tree-optimization/89263] Simplify bool expression to OR

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=89263

--- Comment #11 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The trunk branch has been updated by Andrew Pinski <pinskia@gcc.gnu.org>:

https://gcc.gnu.org/g:64d90d06d2db43538c8a45adbb3d74842f7868ae

commit r14-1597-g64d90d06d2db43538c8a45adbb3d74842f7868ae
Author: Andrew Pinski <apinski@marvell.com>
Date:   Wed May 24 07:08:45 2023 +0000

    Add match patterns for `a ? onezero : onezero` where one of the two
operands are constant

    This adds a match pattern that are for boolean values
    that optimizes `a ? onezero : 0` to `a & onezero` and
    `a ? 1 : onezero` to `a | onezero`.

    This was reported a few times and I thought I would finally
    add the match pattern for this.

    This hits a few times in GCC itself too.

    Notes on the testcases:
    * phi-opt-2.c: This now is optimized to `a & b` in phiopt rather than
ifcombine
    * phi-opt-25b.c: The test part that was failing was parity which now gets
`x & y` treatment.
    * ssa-thread-21.c: there is no longer a threading opportunity, so need to
disable phiopt.
      Note PR 109957 is filed for the now missing optimization in that testcase
too.

    gcc/ChangeLog:

            PR tree-optimization/89263
            PR tree-optimization/99069
            PR tree-optimization/20083
            PR tree-optimization/94898
            * match.pd: Add patterns to optimize `a ? onezero : onezero` with
            one of the operands are constant.

    gcc/testsuite/ChangeLog:

            * gcc.dg/tree-ssa/phi-opt-2.c: Adjust the testcase.
            * gcc.dg/tree-ssa/phi-opt-25b.c: Adjust the testcase.
            * gcc.dg/tree-ssa/ssa-thread-21.c: Disable phiopt.
            * gcc.dg/tree-ssa/phi-opt-27.c: New test.
            * gcc.dg/tree-ssa/phi-opt-28.c: New test.
            * gcc.dg/tree-ssa/phi-opt-29.c: New test.
            * gcc.dg/tree-ssa/phi-opt-30.c: New test.
            * gcc.dg/tree-ssa/phi-opt-31.c: New test.
            * gcc.dg/tree-ssa/phi-opt-32.c: New test.

[Bug tree-optimization/89263] Simplify bool expression to OR

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=89263

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED
   Target Milestone|---                         |14.0

--- Comment #12 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Fixed.