public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug other/90142] contrib/download_prerequisites uses test ==
[not found] <bug-90142-4@http.gcc.gnu.org/bugzilla/>
@ 2021-08-24 6:13 ` pinskia at gcc dot gnu.org
2021-08-30 20:54 ` cvs-commit at gcc dot gnu.org
2021-08-30 20:55 ` pinskia at gcc dot gnu.org
2 siblings, 0 replies; 3+ messages in thread
From: pinskia at gcc dot gnu.org @ 2021-08-24 6:13 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90142
Andrew Pinski <pinskia at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
Assignee|unassigned at gcc dot gnu.org |pinskia at gcc dot gnu.org
CC| |pinskia at gcc dot gnu.org
--- Comment #5 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
md5_check function right now is darwin specific but does not mean this should
not be fixed. If I get some time I will try to test the change.
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Bug other/90142] contrib/download_prerequisites uses test ==
[not found] <bug-90142-4@http.gcc.gnu.org/bugzilla/>
2021-08-24 6:13 ` [Bug other/90142] contrib/download_prerequisites uses test == pinskia at gcc dot gnu.org
@ 2021-08-30 20:54 ` cvs-commit at gcc dot gnu.org
2021-08-30 20:55 ` pinskia at gcc dot gnu.org
2 siblings, 0 replies; 3+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2021-08-30 20:54 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90142
--- Comment #6 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The trunk branch has been updated by Andrew Pinski <pinskia@gcc.gnu.org>:
https://gcc.gnu.org/g:79a017c412b412f26ec39e0ada75e247fcff5611
commit r12-3232-g79a017c412b412f26ec39e0ada75e247fcff5611
Author: Andrew Pinski <apinski@marvell.com>
Date: Mon Aug 30 20:30:41 2021 +0000
Fix PR 90142: contrib/download_prerequisites uses test ==
Since == is not portable, it is better to use = in contrib/
download_prerequisites. The only place == was used is inside
the function md5_check which is used only on Mac OS X.
Tested on Mac OS X as:
./contrib/download_prerequisites --md5
Both with all files having the correct checksum and one with a broken one.
contrib/ChangeLog:
* download_prerequisites (md5_check): Replace == inside
test with = to be more portable.
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Bug other/90142] contrib/download_prerequisites uses test ==
[not found] <bug-90142-4@http.gcc.gnu.org/bugzilla/>
2021-08-24 6:13 ` [Bug other/90142] contrib/download_prerequisites uses test == pinskia at gcc dot gnu.org
2021-08-30 20:54 ` cvs-commit at gcc dot gnu.org
@ 2021-08-30 20:55 ` pinskia at gcc dot gnu.org
2 siblings, 0 replies; 3+ messages in thread
From: pinskia at gcc dot gnu.org @ 2021-08-30 20:55 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90142
Andrew Pinski <pinskia at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|--- |12.0
Resolution|--- |FIXED
Status|ASSIGNED |RESOLVED
--- Comment #7 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Fixed by r12-3232-g79a017c412b412f26ec39e0ada75e247fcff5611 .
I forgot to put the PR # in the changelog part of the message. oh well.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-08-30 20:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <bug-90142-4@http.gcc.gnu.org/bugzilla/>
2021-08-24 6:13 ` [Bug other/90142] contrib/download_prerequisites uses test == pinskia at gcc dot gnu.org
2021-08-30 20:54 ` cvs-commit at gcc dot gnu.org
2021-08-30 20:55 ` pinskia at gcc dot gnu.org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).