[Bug c++/90451] [8/9/10/11 Regression] "static" function which added "deprecated" print deprecated warning >1 times (twice or even 3 times)

[Bug c++/90451] [8/9/10/11 Regression] "static" function which added "deprecated" print deprecated warning >1 times (twice or even 3 times)

[jason at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90451

Jason Merrill <jason at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|unassigned at gcc dot gnu.org      |jason at gcc dot gnu.org

[Bug c++/90451] [8/9/10/11 Regression] "static" function which added "deprecated" print deprecated warning >1 times (twice or even 3 times)

[jason at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90451

--- Comment #8 from Jason Merrill <jason at gcc dot gnu.org> ---
Created attachment 50537
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=50537&action=edit
WIP Fix

Here's an approach that moves the mark_used calls closer to where the functions
are actually used.  We might also try moving the calls the other way, to as
soon as we have a unique result.  Either way, this is too risky for a
diagnostic issue at this point in the release cycle, so deferring.

[Bug c++/90451] [9/10/11/12 Regression] "static" function which added "deprecated" print deprecated warning >1 times (twice or even 3 times)

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90451

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|8.5                         |9.4

--- Comment #9 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
GCC 8 branch is being closed.

[Bug c++/90451] [9/10/11/12 Regression] "static" function which added "deprecated" print deprecated warning >1 times (twice or even 3 times)

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90451

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|9.4                         |9.5

--- Comment #10 from Richard Biener <rguenth at gcc dot gnu.org> ---
GCC 9.4 is being released, retargeting bugs to GCC 9.5.

[Bug c++/90451] [9/10/11/12 Regression] "static" function which added "deprecated" print deprecated warning >1 times (twice or even 3 times)

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90451

--- Comment #11 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jason Merrill <jason@gcc.gnu.org>:

https://gcc.gnu.org/g:c352ef0ed90cfc07d494dfec111121bc683e337b

commit r12-7285-gc352ef0ed90cfc07d494dfec111121bc683e337b
Author: Jason Merrill <jason@redhat.com>
Date:   Wed Feb 16 14:05:39 2022 -0500

    c++: avoid duplicate deprecated warning [PR90451]

    We were getting the deprecated warning twice for the same call because we
    called mark_used first in finish_qualified_id_expr and then again in
    build_over_call.  Let's not call it the first time; C++17 clarified that a
    function is used only when it is selected from an overload set, which
    happens later.

    Then I had to add a few more uses in places that don't do anything further
    with the expression (convert_to_void, finish_decltype_type), and places
that
    use the expression more unusually (cp_build_addr_expr_1,
    convert_nontype_argument).  The new mark_single_function is mostly so
    that I only have to put the comment in one place.

            PR c++/90451

    gcc/cp/ChangeLog:

            * decl2.cc (mark_single_function): New.
            * cp-tree.h: Declare it.
            * typeck.cc (cp_build_addr_expr_1): mark_used when making a PMF.
            * semantics.cc (finish_qualified_id_expr): Not here.
            (finish_id_expression_1): Or here.
            (finish_decltype_type): Call mark_single_function.
            * cvt.cc (convert_to_void): And here.
            * pt.cc (convert_nontype_argument): And here.
            * init.cc (build_offset_ref): Adjust assert.

    gcc/testsuite/ChangeLog:

            * g++.dg/warn/deprecated-14.C: New test.
            * g++.dg/warn/deprecated-15.C: New test.

[Bug c++/90451] [9/10/11/12 Regression] "static" function which added "deprecated" print deprecated warning >1 times (twice or even 3 times)

[jason at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90451

Jason Merrill <jason at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #12 from Jason Merrill <jason at gcc dot gnu.org> ---
Fixed for GCC 12, not backporting.

[Bug c++/90451] [9/10/11/12 Regression] "static" function which added "deprecated" print deprecated warning >1 times (twice or even 3 times)

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90451

--- Comment #13 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jason Merrill <jason@gcc.gnu.org>:

https://gcc.gnu.org/g:03381beccb52c0e2c15da3b8b8dfa3bb6eb71df9

commit r13-2632-g03381beccb52c0e2c15da3b8b8dfa3bb6eb71df9
Author: Jason Merrill <jason@redhat.com>
Date:   Mon Sep 12 13:47:34 2022 -0400

    c++: auto member function and auto variable [PR106893]

    As with PR105623, we need to call mark_single_function sooner to
    resolve the type of a BASELINK.

            PR c++/106893
            PR c++/90451

    gcc/cp/ChangeLog:

            * decl.cc (cp_finish_decl): Call mark_single_function.

    gcc/testsuite/ChangeLog:

            * g++.dg/cpp1y/auto-fn65.C: New test.

[Bug c++/90451] [9/10/11/12 Regression] "static" function which added "deprecated" print deprecated warning >1 times (twice or even 3 times)

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90451

--- Comment #14 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-12 branch has been updated by Jason Merrill
<jason@gcc.gnu.org>:

https://gcc.gnu.org/g:999638cb7b126d33d1ea6548c69ba387b7d7a270

commit r12-8758-g999638cb7b126d33d1ea6548c69ba387b7d7a270
Author: Jason Merrill <jason@redhat.com>
Date:   Mon Sep 12 13:47:34 2022 -0400

    c++: auto member function and auto variable [PR106893]

    As with PR105623, we need to call mark_single_function sooner to
    resolve the type of a BASELINK.

            PR c++/106893
            PR c++/90451

    gcc/cp/ChangeLog:

            * decl.cc (cp_finish_decl): Call mark_single_function.

    gcc/testsuite/ChangeLog:

            * g++.dg/cpp1y/auto-fn65.C: New test.