public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug libgomp/90596] 'GOACC_parallel_keyed' should use 'GOMP_MAP_VARS_TARGET'
[not found] <bug-90596-4@http.gcc.gnu.org/bugzilla/>
@ 2023-03-10 17:07 ` cvs-commit at gcc dot gnu.org
2023-03-11 9:26 ` tschwinge at gcc dot gnu.org
1 sibling, 0 replies; 2+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2023-03-10 17:07 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90596
--- Comment #1 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Thomas Schwinge <tschwinge@gcc.gnu.org>:
https://gcc.gnu.org/g:f8332e52a498df480f72303de32ad0751ad899fe
commit r13-6590-gf8332e52a498df480f72303de32ad0751ad899fe
Author: Thomas Schwinge <thomas@codesourcery.com>
Date: Mon Feb 27 15:56:18 2023 +0100
Use 'GOMP_MAP_VARS_TARGET' for OpenACC compute constructs [PR90596]
Thereby considerably simplify the device plugins'
'GOMP_OFFLOAD_openacc_exec',
'GOMP_OFFLOAD_openacc_async_exec' functions: in terms of lines of code, but
in
particular conceptually: no more device memory allocation, host to device
data
copying, device memory deallocation -- 'GOMP_MAP_VARS_TARGET' does all that
for
us.
This depends on commit 2b2340e236c0bba8aaca358ea25a5accd8249fbd
"Allow libgomp 'cbuf' buffering with OpenACC 'async' for 'ephemeral' data",
where I said that "a use will emerge later", which is this one here.
PR libgomp/90596
libgomp/
* target.c (gomp_map_vars_internal): Allow for
'param_kind == GOMP_MAP_VARS_OPENACC | GOMP_MAP_VARS_TARGET'.
* oacc-parallel.c (GOACC_parallel_keyed): Pass
'GOMP_MAP_VARS_TARGET' to 'goacc_map_vars'.
* plugin/plugin-gcn.c (alloc_by_agent, gcn_exec)
(GOMP_OFFLOAD_openacc_exec, GOMP_OFFLOAD_openacc_async_exec):
Adjust, simplify.
(gomp_offload_free): Remove.
* plugin/plugin-nvptx.c (nvptx_exec, GOMP_OFFLOAD_openacc_exec)
(GOMP_OFFLOAD_openacc_async_exec): Adjust, simplify.
(cuda_free_argmem): Remove.
* testsuite/libgomp.oacc-c-c++-common/acc_prof-parallel-1.c:
Adjust.
^ permalink raw reply [flat|nested] 2+ messages in thread
* [Bug libgomp/90596] 'GOACC_parallel_keyed' should use 'GOMP_MAP_VARS_TARGET'
[not found] <bug-90596-4@http.gcc.gnu.org/bugzilla/>
2023-03-10 17:07 ` [Bug libgomp/90596] 'GOACC_parallel_keyed' should use 'GOMP_MAP_VARS_TARGET' cvs-commit at gcc dot gnu.org
@ 2023-03-11 9:26 ` tschwinge at gcc dot gnu.org
1 sibling, 0 replies; 2+ messages in thread
From: tschwinge at gcc dot gnu.org @ 2023-03-11 9:26 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90596
Thomas Schwinge <tschwinge at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|--- |13.0
Status|UNCONFIRMED |RESOLVED
Resolution|--- |FIXED
Assignee|unassigned at gcc dot gnu.org |tschwinge at gcc dot gnu.org
--- Comment #2 from Thomas Schwinge <tschwinge at gcc dot gnu.org> ---
.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-03-11 9:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <bug-90596-4@http.gcc.gnu.org/bugzilla/>
2023-03-10 17:07 ` [Bug libgomp/90596] 'GOACC_parallel_keyed' should use 'GOMP_MAP_VARS_TARGET' cvs-commit at gcc dot gnu.org
2023-03-11 9:26 ` tschwinge at gcc dot gnu.org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).