[Bug target/90932] [nvptx] internal compiler error: in tree_to_shwi, at tree.c

[Bug target/90932] [nvptx] internal compiler error: in tree_to_shwi, at tree.c

[vries at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90932

Tom de Vries <vries at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |roger at nextmovesoftware dot com

--- Comment #4 from Tom de Vries <vries at gcc dot gnu.org> ---
Patch submitted:
https://gcc.gnu.org/pipermail/gcc-patches/2020-June/549100.html

[Bug target/90932] [nvptx] internal compiler error: in tree_to_shwi, at tree.c

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90932

--- Comment #5 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tom de Vries <vries@gcc.gnu.org>:

https://gcc.gnu.org/g:26b538cd81b9692eaf519fa1743ca8c282048793

commit r11-1800-g26b538cd81b9692eaf519fa1743ca8c282048793
Author: Roger Sayle <roger@nextmovesoftware.com>
Date:   Fri Jul 3 10:57:39 2020 +0200

    nvptx: Fix ICE in nvptx_vector_alignment on gcc.dg/attr-vector_size.c

    This patch addresses the ICE in gcc.dg/attr-vector_size.c during
    make -k check on nvptx-none.  The actual ICE looks like:

    testsuite/gcc.dg/attr-vector_size.c:29:1: internal compiler error: \
      in tree_to_shwi, at tree.c:7321
    0xf53bf2 tree_to_shwi(tree_node const*)
    ../../gcc/gcc/tree.c:7321
    0xff1969 nvptx_vector_alignment
    ../../gcc/gcc/config/nvptx/nvptx.c:5105^M

    The problem is that the caller has ensured that TYPE_SIZE(type) is
    representable as an unsigned HOST_WIDE_INT, but nvptx_vector_alignment is
    accessing it as a signed HOST_WIDE_INT which overflows in pathological
    conditions.  Amongst those pathological conditions is that a TYPE_SIZE of
    zero can sometimes reach this function, prior to an error being emitted.
    Making sure the result is not less than the mode's alignment and not
greater
    than BIGGEST_ALIGNMENT fixes the ICEs, and generates the expected
    compile-time error messages.

    Tested on --target=nvptx-none, with a "make" and "make check" which results
    in four fewer unexpected failures and three more expected passes.

    2020-07-03  Roger Sayle  <roger@nextmovesoftware.com>
                Tom de Vries  <tdevries@suse.de>

    gcc/ChangeLog:

            PR target/90932
            * config/nvptx/nvptx.c (nvptx_vector_alignment): Use tree_to_uhwi
            to access TYPE_SIZE (type).  Return at least the mode's alignment.

[Bug target/90932] [nvptx] internal compiler error: in tree_to_shwi, at tree.c

[vries at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90932

Tom de Vries <vries at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |11.0
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #6 from Tom de Vries <vries at gcc dot gnu.org> ---
Patch committed, marking resolved-fixed.