public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug libstdc++/90943] Visiting inherited variants no longer works in 9.1
       [not found] <bug-90943-4@http.gcc.gnu.org/bugzilla/>
@ 2020-03-12 11:59 ` jakub at gcc dot gnu.org
  2020-05-03 12:32 ` redi at gcc dot gnu.org
                   ` (7 subsequent siblings)
  8 siblings, 0 replies; 9+ messages in thread
From: jakub at gcc dot gnu.org @ 2020-03-12 11:59 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90943

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|9.3                         |9.4

--- Comment #5 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
GCC 9.3.0 has been released, adjusting target milestone.

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [Bug libstdc++/90943] Visiting inherited variants no longer works in 9.1
       [not found] <bug-90943-4@http.gcc.gnu.org/bugzilla/>
  2020-03-12 11:59 ` [Bug libstdc++/90943] Visiting inherited variants no longer works in 9.1 jakub at gcc dot gnu.org
@ 2020-05-03 12:32 ` redi at gcc dot gnu.org
  2021-02-23 11:46 ` redi at gcc dot gnu.org
                   ` (6 subsequent siblings)
  8 siblings, 0 replies; 9+ messages in thread
From: redi at gcc dot gnu.org @ 2020-05-03 12:32 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90943

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|9.4                         |---

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [Bug libstdc++/90943] Visiting inherited variants no longer works in 9.1
       [not found] <bug-90943-4@http.gcc.gnu.org/bugzilla/>
  2020-03-12 11:59 ` [Bug libstdc++/90943] Visiting inherited variants no longer works in 9.1 jakub at gcc dot gnu.org
  2020-05-03 12:32 ` redi at gcc dot gnu.org
@ 2021-02-23 11:46 ` redi at gcc dot gnu.org
  2021-04-19 14:11 ` redi at gcc dot gnu.org
                   ` (5 subsequent siblings)
  8 siblings, 0 replies; 9+ messages in thread
From: redi at gcc dot gnu.org @ 2021-02-23 11:46 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90943

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|SUSPENDED                   |NEW

--- Comment #6 from Jonathan Wakely <redi at gcc dot gnu.org> ---
http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2021/p2162r2.html says we
should support inherited variants.

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [Bug libstdc++/90943] Visiting inherited variants no longer works in 9.1
       [not found] <bug-90943-4@http.gcc.gnu.org/bugzilla/>
                   ` (2 preceding siblings ...)
  2021-02-23 11:46 ` redi at gcc dot gnu.org
@ 2021-04-19 14:11 ` redi at gcc dot gnu.org
  2021-05-12  9:54 ` redi at gcc dot gnu.org
                   ` (4 subsequent siblings)
  8 siblings, 0 replies; 9+ messages in thread
From: redi at gcc dot gnu.org @ 2021-04-19 14:11 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90943

--- Comment #7 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Implemented downstream:
https://gitlab.com/jonathan-wakely/gcc/-/commit/484308ad163862632ae7e710c5d909be385450aa

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [Bug libstdc++/90943] Visiting inherited variants no longer works in 9.1
       [not found] <bug-90943-4@http.gcc.gnu.org/bugzilla/>
                   ` (3 preceding siblings ...)
  2021-04-19 14:11 ` redi at gcc dot gnu.org
@ 2021-05-12  9:54 ` redi at gcc dot gnu.org
  2021-10-01 19:38 ` cvs-commit at gcc dot gnu.org
                   ` (3 subsequent siblings)
  8 siblings, 0 replies; 9+ messages in thread
From: redi at gcc dot gnu.org @ 2021-05-12  9:54 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90943

--- Comment #8 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Corrected URL for downstream fix:
https://gitlab.com/jonathan-wakely/gcc/-/commit/486d89e403a18ef78f05f2efb1bc86bbd396899c

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [Bug libstdc++/90943] Visiting inherited variants no longer works in 9.1
       [not found] <bug-90943-4@http.gcc.gnu.org/bugzilla/>
                   ` (4 preceding siblings ...)
  2021-05-12  9:54 ` redi at gcc dot gnu.org
@ 2021-10-01 19:38 ` cvs-commit at gcc dot gnu.org
  2021-10-01 19:53 ` redi at gcc dot gnu.org
                   ` (2 subsequent siblings)
  8 siblings, 0 replies; 9+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2021-10-01 19:38 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90943

--- Comment #9 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jonathan Wakely <redi@gcc.gnu.org>:

https://gcc.gnu.org/g:c46ecb0112e91c80ee111439e79a58a953e4479d

commit r12-4067-gc46ecb0112e91c80ee111439e79a58a953e4479d
Author: Jonathan Wakely <jwakely@redhat.com>
Date:   Mon Apr 19 14:49:12 2021 +0100

    libstdc++: Allow visiting inherited variants [PR 90943]

    Implement the changes from P2162R2 (as a DR for C++17).

    Signed-off-by: Jonathan Wakely <jwakely@redhat.com>

    libstdc++-v3/ChangeLog:

            PR libstdc++/90943
            * include/std/variant (__cpp_lib_variant): Update value.
            (__detail::__variant::__as): New helpers implementing the
            as-variant exposition-only function templates.
            (visit, visit<R>): Use __as to upcast the variant parameters.
            * include/std/version (__cpp_lib_variant): Update value.
            * testsuite/20_util/variant/visit_inherited.cc: New test.

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [Bug libstdc++/90943] Visiting inherited variants no longer works in 9.1
       [not found] <bug-90943-4@http.gcc.gnu.org/bugzilla/>
                   ` (5 preceding siblings ...)
  2021-10-01 19:38 ` cvs-commit at gcc dot gnu.org
@ 2021-10-01 19:53 ` redi at gcc dot gnu.org
  2022-04-12 20:17 ` cvs-commit at gcc dot gnu.org
  2022-04-12 20:18 ` redi at gcc dot gnu.org
  8 siblings, 0 replies; 9+ messages in thread
From: redi at gcc dot gnu.org @ 2021-10-01 19:53 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90943

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |11.3

--- Comment #10 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Done for GCC 12, but I intend to backport it.

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [Bug libstdc++/90943] Visiting inherited variants no longer works in 9.1
       [not found] <bug-90943-4@http.gcc.gnu.org/bugzilla/>
                   ` (6 preceding siblings ...)
  2021-10-01 19:53 ` redi at gcc dot gnu.org
@ 2022-04-12 20:17 ` cvs-commit at gcc dot gnu.org
  2022-04-12 20:18 ` redi at gcc dot gnu.org
  8 siblings, 0 replies; 9+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2022-04-12 20:17 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90943

--- Comment #11 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-11 branch has been updated by Jonathan Wakely
<redi@gcc.gnu.org>:

https://gcc.gnu.org/g:90b94ca5a2ddd7834afff9ad5e1afff5554e0752

commit r11-9831-g90b94ca5a2ddd7834afff9ad5e1afff5554e0752
Author: Jonathan Wakely <jwakely@redhat.com>
Date:   Mon Apr 19 14:49:12 2021 +0100

    libstdc++: Allow visiting inherited variants [PR 90943]

    Implement the changes from P2162R2 (as a DR for C++17).

    Signed-off-by: Jonathan Wakely <jwakely@redhat.com>

    libstdc++-v3/ChangeLog:

            PR libstdc++/90943
            * include/std/variant (__cpp_lib_variant): Update value.
            (__detail::__variant::__as): New helpers implementing the
            as-variant exposition-only function templates.
            (visit, visit<R>): Use __as to upcast the variant parameters.
            * include/std/version (__cpp_lib_variant): Update value.
            * testsuite/20_util/variant/visit_inherited.cc: New test.

    (cherry picked from commit c46ecb0112e91c80ee111439e79a58a953e4479d)

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [Bug libstdc++/90943] Visiting inherited variants no longer works in 9.1
       [not found] <bug-90943-4@http.gcc.gnu.org/bugzilla/>
                   ` (7 preceding siblings ...)
  2022-04-12 20:17 ` cvs-commit at gcc dot gnu.org
@ 2022-04-12 20:18 ` redi at gcc dot gnu.org
  8 siblings, 0 replies; 9+ messages in thread
From: redi at gcc dot gnu.org @ 2022-04-12 20:18 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90943

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #12 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Fixed for 11.3

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2022-04-12 20:18 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <bug-90943-4@http.gcc.gnu.org/bugzilla/>
2020-03-12 11:59 ` [Bug libstdc++/90943] Visiting inherited variants no longer works in 9.1 jakub at gcc dot gnu.org
2020-05-03 12:32 ` redi at gcc dot gnu.org
2021-02-23 11:46 ` redi at gcc dot gnu.org
2021-04-19 14:11 ` redi at gcc dot gnu.org
2021-05-12  9:54 ` redi at gcc dot gnu.org
2021-10-01 19:38 ` cvs-commit at gcc dot gnu.org
2021-10-01 19:53 ` redi at gcc dot gnu.org
2022-04-12 20:17 ` cvs-commit at gcc dot gnu.org
2022-04-12 20:18 ` redi at gcc dot gnu.org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).