[Bug fortran/91497] -Wconversion warns when doing explicit type conversion

[Bug fortran/91497] -Wconversion warns when doing explicit type conversion

[sandra at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91497

sandra at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sandra at gcc dot gnu.org

--- Comment #23 from sandra at gcc dot gnu.org ---
Created attachment 51686
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=51686&action=edit
add dg-require-effective-target to testcase

The new testcase is FAILing on x86 targets configured without REAL*16 support,
like so:

/path/to/gcc/testsuite/gfortran.dg/pr91497.f90:14:14: Error: Old-style type
declaration REAL*16 not supported at (1)
/path/to/gcc/testsuite/gfortran.dg/pr91497.f90:21:31: Error: Invalid real kind
16 at (1)
compiler exited with status 1

I've got this patch to add some dg-require-effective-target tests, but maybe it
would be better to fix the testcase so that it does not depend on
target-specific floating-point types?  Or add a second testcase that doesn't
require all the target restrictions, for broader test coverage on more
platforms?

[Bug fortran/91497] -Wconversion warns when doing explicit type conversion

[manfred99 at gmx dot ch]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91497

--- Comment #24 from Manfred Schwarb <manfred99 at gmx dot ch> ---
Sandra,
I will look into this. Probably streamlining the patch to only use *4 and *8
is appropriate.

[Bug fortran/91497] -Wconversion warns when doing explicit type conversion

[manfred99 at gmx dot ch]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91497

--- Comment #25 from Manfred Schwarb <manfred99 at gmx dot ch> ---
Same issue for MAX1 and MIN1:

   88 |       ff=MAX1(a, a)
      |              1
Warning: Change of value in conversion from 'REAL(4)' to 'INTEGER(4)' at (1)
[-Wconversion]


Surprisingly, I could not provoke a warning for AMAX0 and AMIN0.

I will prepare a patch.

[Bug fortran/91497] -Wconversion warns when doing explicit type conversion

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91497

--- Comment #26 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Martin Liska <marxin@gcc.gnu.org>:

https://gcc.gnu.org/g:f1215db08126fbd2d69d971d65611508cf83b4ae

commit r12-5958-gf1215db08126fbd2d69d971d65611508cf83b4ae
Author: Manfred Schwarb <manfred99@gmx.ch>
Date:   Tue Dec 14 16:28:58 2021 +0100

    fortran: Silence conversion warnings for MIN1 and MAX1

    gcc/fortran/ChangeLog:

            PR fortran/91497
            * simplify.c (simplify_min_max): Disable conversion warnings for
            MIN1 and MAX1.

[Bug fortran/91497] -Wconversion warns when doing explicit type conversion

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91497

--- Comment #27 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Martin Liska <marxin@gcc.gnu.org>:

https://gcc.gnu.org/g:44aa890d8fb4afa843cf6cb7452fd5d6f3dd61fe

commit r12-5959-g44aa890d8fb4afa843cf6cb7452fd5d6f3dd61fe
Author: Manfred Schwarb <manfred99@gmx.ch>
Date:   Tue Dec 14 16:30:27 2021 +0100

    testsuite: Silence conversion warnings for MIN1 and MAX1

    gcc/testsuite/ChangeLog:

            PR fortran/91497
            * gfortran.dg/pr91497.f90: Adjust test to use
            dg-require-effective-target directive.
            * gfortran.dg/pr91497_2.f90: New test to cover all targets.
            Cover MAX1 and MIN1 intrinsics.