public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "jakub at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/91645] Missed optimization with sqrt(x*x)
Date: Thu, 30 Mar 2023 13:30:01 +0000	[thread overview]
Message-ID: <bug-91645-4-QwKibu2He0@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-91645-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91645

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at gcc dot gnu.org      |jakub at gcc dot gnu.org
             Status|NEW                         |ASSIGNED

--- Comment #13 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Created attachment 54789
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=54789&action=edit
gcc13-pr91645.patch

This seems to work right on the testcase I've been trying:
float sqrtf (float);
float foo (float x) { return sqrtf (x); }
float bar (float x) { if (__builtin_isless (x, 0)) __builtin_unreachable ();
return sqrtf (x); }
float baz (float x) { if (!__builtin_isless (x, 0)) __builtin_unreachable ();
return sqrtf (x); }
float qux (float x) { x = x * x; return sqrtf (x); }

Do we want this for GCC 13, or at least parts of it like the range-op-float.cc
fixes and/or the value-range.cc change, or defer everything for GCC 14?

  parent reply	other threads:[~2023-03-30 13:30 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <bug-91645-4@http.gcc.gnu.org/bugzilla/>
2022-09-03 16:08 ` aldyh at gcc dot gnu.org
2022-09-03 17:33 ` law at gcc dot gnu.org
2023-03-29 17:40 ` aldyh at gcc dot gnu.org
2023-03-29 17:46 ` aldyh at gcc dot gnu.org
2023-03-30 11:50 ` jakub at gcc dot gnu.org
2023-03-30 13:03 ` jakub at gcc dot gnu.org
2023-03-30 13:30 ` jakub at gcc dot gnu.org [this message]
2023-03-31 11:43 ` cvs-commit at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-91645-4-QwKibu2He0@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).