public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "aldyh at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/91645] Missed optimization with sqrt(x*x)
Date: Sat, 03 Sep 2022 16:08:48 +0000 [thread overview]
Message-ID: <bug-91645-4-R6zaNRdV2q@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-91645-4@http.gcc.gnu.org/bugzilla/>
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91645
Aldy Hernandez <aldyh at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |aldyh at gcc dot gnu.org,
| |amacleod at redhat dot com,
| |jakub at gcc dot gnu.org,
| |law at gcc dot gnu.org
--- Comment #7 from Aldy Hernandez <aldyh at gcc dot gnu.org> ---
> Now, the problem is that GCC doesn't seem to optimize away the call to sqrtf
> based on some surrounding code. As an example, it would be neat to have this
> (or something similar) to get compiled into the same mulss-sqrtss-ret:
>
> float test (float x)
> {
> float y = x*x;
> if (y >= 0.f)
> return std::sqrt(y);
> __builtin_unreachable();
> }
>
> If I understand it correctly, the 'y >= 0.f' excludes 'y' being NaN and 'y'
> being negative (though this is excluded by 'y = x*x'), so there is no need
> to check if the argument to `std::sqrt` is any bad, enabling to just do
> 'sqrtss' and return.
I'm not an FP expert, but I think we have enough information to do this right
now. The evrp dump now has:
=========== BB 2 ============
Imports: y_2
Exports: y_2
<bb 2> :
y_2 = x_1(D) * x_1(D);
if (y_2 >= 0.0)
goto <bb 3>; [INV]
else
goto <bb 4>; [INV]
2->3 (T) y_2 : [frange] float [0.0, Inf] !NAN
2->4 (F) y_2 : [frange] float [ -Inf, 0.0]
=========== BB 3 ============
y_2 [frange] float [0.0, Inf] !NAN
<bb 3> :
_6 = __builtin_sqrtf (y_2);
return _6;
Which means that y_2 is known to be [0.0, Inf] excluding a NAN.
What needs to happen for the call to __builtin_sqrtf to be optimized to sqrtss?
next parent reply other threads:[~2022-09-03 16:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <bug-91645-4@http.gcc.gnu.org/bugzilla/>
2022-09-03 16:08 ` aldyh at gcc dot gnu.org [this message]
2022-09-03 17:33 ` law at gcc dot gnu.org
2023-03-29 17:40 ` aldyh at gcc dot gnu.org
2023-03-29 17:46 ` aldyh at gcc dot gnu.org
2023-03-30 11:50 ` jakub at gcc dot gnu.org
2023-03-30 13:03 ` jakub at gcc dot gnu.org
2023-03-30 13:30 ` jakub at gcc dot gnu.org
2023-03-31 11:43 ` cvs-commit at gcc dot gnu.org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-91645-4-R6zaNRdV2q@http.gcc.gnu.org/bugzilla/ \
--to=gcc-bugzilla@gcc.gnu.org \
--cc=gcc-bugs@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).