public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/91681] Missed optimization for 128 bit arithmetic operations
Date: Wed, 12 Jul 2023 13:14:57 +0000	[thread overview]
Message-ID: <bug-91681-4-RWyAGaxQrv@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-91681-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91681

--- Comment #5 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Roger Sayle <sayle@gcc.gnu.org>:

https://gcc.gnu.org/g:275a2124e4928c88bd5469096356ba393b6aadfb

commit r14-2466-g275a2124e4928c88bd5469096356ba393b6aadfb
Author: Roger Sayle <roger@nextmovesoftware.com>
Date:   Wed Jul 12 14:14:15 2023 +0100

    i386: Fix FAIL of gcc.target/i386/pr91681-1.c

    The recent change in TImode parameter passing on x86_64 results in the
    FAIL of pr91681-1.c.  The issue is that with the extra flexibility,
    the combine pass is now spoilt for choice between using either the
    *add<dwi>3_doubleword_concat or the *add<dwi>3_doubleword_zext
    patterns, when one operand is a *concat and the other is a zero_extend.
    The solution proposed below is provide an *add<dwi>3_doubleword_concat_zext
    define_insn_and_split, that can benefit both from the register allocation
    of *concat, and still avoid the xor normally required by zero extension.

    I'm investigating a follow-up refinement to improve register allocation
    further by avoiding the early clobber in the =&r, and handling (custom)
    reloads explicitly, but this piece resolves the testcase failure.

    2023-07-12  Roger Sayle  <roger@nextmovesoftware.com>

    gcc/ChangeLog
            PR target/91681
            * config/i386/i386.md (*add<dwi>3_doubleword_concat_zext): New
            define_insn_and_split derived from *add<dwi>3_doubleword_concat
            and *add<dwi>3_doubleword_zext.

  parent reply	other threads:[~2023-07-12 13:14 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <bug-91681-4@http.gcc.gnu.org/bugzilla/>
2021-12-27  7:29 ` pinskia at gcc dot gnu.org
2022-07-25 16:37 ` cvs-commit at gcc dot gnu.org
2023-07-07 20:00 ` roger at nextmovesoftware dot com
2023-07-12 13:14 ` cvs-commit at gcc dot gnu.org [this message]
2023-07-12 13:46 ` cvs-commit at gcc dot gnu.org
2024-01-21 23:31 ` roger at nextmovesoftware dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-91681-4-RWyAGaxQrv@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).