public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/91710] [9/10/11 Regression] unexpected ABI change note since r9-5650
Date: Fri, 16 Apr 2021 18:50:23 +0000	[thread overview]
Message-ID: <bug-91710-4-65j3P9Zf6b@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-91710-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91710

--- Comment #8 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:49813aad3292f7f2bef69206274da78a9a7116ed

commit r11-8226-g49813aad3292f7f2bef69206274da78a9a7116ed
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Fri Apr 16 20:49:33 2021 +0200

    aarch64: Don't emit -Wpsabi note when ABI was never affected [PR91710]

    As the following testcase shows, we emit a -Wpsabi note about argument
    passing change since GCC 9, but in reality the ABI didn't change.
    The alignment is 8 bits in GCC < 9 and 32 bits in GCC >= 9 and
    the aarch64_function_arg_alignment returns in that case:
    return MIN (MAX (alignment, PARM_BOUNDARY), STACK_BOUNDARY);
    so when both the old and new alignment are smaller or equal to
PARM_BOUNDARY
    (or both are larger than STACK_BOUNDARY, just in theory), even when the new
    one is bigger, it doesn't change the argument passing.

    So, the following patch changes aarch64_function_arg_alignment to tell the
    callers the exact old alignmentm so that they can test it if needed.
    The other aarch64_function_arg_alignment callers either check the
    alignment for equality against 16-byte alignment (when old alignment was
    smaller than that and the new one is 16-byte, we want to emit -Wpsabi
    in all the cases) or the va_arg case which I think is ok now too.

    2021-04-16  Jakub Jelinek  <jakub@redhat.com>

            PR target/91710
            * config/aarch64/aarch64.c (aarch64_function_arg_alignment): Change
            abi_break argument from bool * to unsigned *, store there the
pre-GCC 9
            alignment.
            (aarch64_layout_arg, aarch64_gimplify_va_arg_expr): Adjust callers.
            (aarch64_function_arg_regno_p): Likewise.  Only emit -Wpsabi note
if
            the old and new alignment after applying MIN/MAX to it is
different.

            * gcc.target/aarch64/pr91710.c: New test.

  parent reply	other threads:[~2021-04-16 18:50 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <bug-91710-4@http.gcc.gnu.org/bugzilla/>
2020-03-12 11:58 ` [Bug target/91710] [9/10 " jakub at gcc dot gnu.org
2021-03-18 15:52 ` [Bug target/91710] [9/10/11 " jakub at gcc dot gnu.org
2021-04-16 18:50 ` cvs-commit at gcc dot gnu.org [this message]
2021-04-16 18:51 ` [Bug target/91710] [9/10 " jakub at gcc dot gnu.org
2021-06-01  8:15 ` rguenth at gcc dot gnu.org
2022-05-27  9:41 ` [Bug target/91710] [10 " rguenth at gcc dot gnu.org
2022-06-28 10:38 ` jakub at gcc dot gnu.org
2023-07-07  8:35 ` rguenth at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-91710-4-65j3P9Zf6b@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).