public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug tree-optimization/92335] [10/11/12 Regression] sinking of loads happen too early which causes vectorization not to be done
[not found] <bug-92335-4@http.gcc.gnu.org/bugzilla/>
@ 2021-07-10 13:40 ` pinskia at gcc dot gnu.org
2022-01-21 13:44 ` rguenth at gcc dot gnu.org
` (6 subsequent siblings)
7 siblings, 0 replies; 8+ messages in thread
From: pinskia at gcc dot gnu.org @ 2021-07-10 13:40 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=92335
Andrew Pinski <pinskia at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords| |missed-optimization
Known to work| |7.3.0
Summary|missed transformation to |[10/11/12 Regression]
|branchless |sinking of loads happen too
| |early which causes
| |vectorization not to be
| |done
Known to fail| |10.1.0
Target Milestone|--- |10.4
--- Comment #4 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
I looked into this and find we are sinking the load of y[i] too early.
That is using -fno-tree-sink, we are able to produce the optimized code.
It would also mean it is a regression even and yes the testcase in comment #3
was able to produce vectorized code in GCC 7.3.0.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug tree-optimization/92335] [10/11/12 Regression] sinking of loads happen too early which causes vectorization not to be done
[not found] <bug-92335-4@http.gcc.gnu.org/bugzilla/>
2021-07-10 13:40 ` [Bug tree-optimization/92335] [10/11/12 Regression] sinking of loads happen too early which causes vectorization not to be done pinskia at gcc dot gnu.org
@ 2022-01-21 13:44 ` rguenth at gcc dot gnu.org
2022-06-28 10:38 ` [Bug tree-optimization/92335] [10/11/12/13 " jakub at gcc dot gnu.org
` (5 subsequent siblings)
7 siblings, 0 replies; 8+ messages in thread
From: rguenth at gcc dot gnu.org @ 2022-01-21 13:44 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=92335
Richard Biener <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |53947
Priority|P3 |P2
Last reconfirmed|2019-11-04 00:00:00 |2022-1-21
Referenced Bugs:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=53947
[Bug 53947] [meta-bug] vectorizer missed-optimizations
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug tree-optimization/92335] [10/11/12/13 Regression] sinking of loads happen too early which causes vectorization not to be done
[not found] <bug-92335-4@http.gcc.gnu.org/bugzilla/>
2021-07-10 13:40 ` [Bug tree-optimization/92335] [10/11/12 Regression] sinking of loads happen too early which causes vectorization not to be done pinskia at gcc dot gnu.org
2022-01-21 13:44 ` rguenth at gcc dot gnu.org
@ 2022-06-28 10:38 ` jakub at gcc dot gnu.org
2023-07-07 10:36 ` [Bug tree-optimization/92335] [11/12/13/14 " rguenth at gcc dot gnu.org
` (4 subsequent siblings)
7 siblings, 0 replies; 8+ messages in thread
From: jakub at gcc dot gnu.org @ 2022-06-28 10:38 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=92335
Jakub Jelinek <jakub at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|10.4 |10.5
--- Comment #5 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
GCC 10.4 is being released, retargeting bugs to GCC 10.5.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug tree-optimization/92335] [11/12/13/14 Regression] sinking of loads happen too early which causes vectorization not to be done
[not found] <bug-92335-4@http.gcc.gnu.org/bugzilla/>
` (2 preceding siblings ...)
2022-06-28 10:38 ` [Bug tree-optimization/92335] [10/11/12/13 " jakub at gcc dot gnu.org
@ 2023-07-07 10:36 ` rguenth at gcc dot gnu.org
2023-07-27 13:52 ` rguenth at gcc dot gnu.org
` (3 subsequent siblings)
7 siblings, 0 replies; 8+ messages in thread
From: rguenth at gcc dot gnu.org @ 2023-07-07 10:36 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=92335
Richard Biener <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|10.5 |11.5
--- Comment #6 from Richard Biener <rguenth at gcc dot gnu.org> ---
GCC 10 branch is being closed.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug tree-optimization/92335] [11/12/13/14 Regression] sinking of loads happen too early which causes vectorization not to be done
[not found] <bug-92335-4@http.gcc.gnu.org/bugzilla/>
` (3 preceding siblings ...)
2023-07-07 10:36 ` [Bug tree-optimization/92335] [11/12/13/14 " rguenth at gcc dot gnu.org
@ 2023-07-27 13:52 ` rguenth at gcc dot gnu.org
2023-08-02 8:46 ` cvs-commit at gcc dot gnu.org
` (2 subsequent siblings)
7 siblings, 0 replies; 8+ messages in thread
From: rguenth at gcc dot gnu.org @ 2023-07-27 13:52 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=92335
Richard Biener <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|unassigned at gcc dot gnu.org |rguenth at gcc dot gnu.org
Status|NEW |ASSIGNED
--- Comment #7 from Richard Biener <rguenth at gcc dot gnu.org> ---
I have a patch to fix this.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug tree-optimization/92335] [11/12/13/14 Regression] sinking of loads happen too early which causes vectorization not to be done
[not found] <bug-92335-4@http.gcc.gnu.org/bugzilla/>
` (4 preceding siblings ...)
2023-07-27 13:52 ` rguenth at gcc dot gnu.org
@ 2023-08-02 8:46 ` cvs-commit at gcc dot gnu.org
2023-08-02 8:47 ` [Bug tree-optimization/92335] [11/12/13 " rguenth at gcc dot gnu.org
2023-08-04 17:26 ` pinskia at gcc dot gnu.org
7 siblings, 0 replies; 8+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2023-08-02 8:46 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=92335
--- Comment #8 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Richard Biener <rguenth@gcc.gnu.org>:
https://gcc.gnu.org/g:399c8dd44ff44f4b496223c7cc980651c4d6f6a0
commit r14-2927-g399c8dd44ff44f4b496223c7cc980651c4d6f6a0
Author: Richard Biener <rguenther@suse.de>
Date: Thu Jul 27 15:34:12 2023 +0200
tree-optimization/92335 - Improve sinking heuristics for vectorization
The following delays sinking of loads within the same innermost
loop when it was unconditional before. That's a not uncommon
issue preventing vectorization when masked loads are not available.
PR tree-optimization/92335
* tree-ssa-sink.cc (select_best_block): Before loop
optimizations avoid sinking unconditional loads/stores
in innermost loops to conditional executed places.
* gcc.dg/tree-ssa/ssa-sink-10.c: Disable vectorizing.
* gcc.dg/tree-ssa/predcom-9.c: Clone from ssa-sink-10.c,
expect predictive commoning to happen instead of sinking.
* gcc.dg/vect/pr65947-3.c: Ajdust.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug tree-optimization/92335] [11/12/13 Regression] sinking of loads happen too early which causes vectorization not to be done
[not found] <bug-92335-4@http.gcc.gnu.org/bugzilla/>
` (5 preceding siblings ...)
2023-08-02 8:46 ` cvs-commit at gcc dot gnu.org
@ 2023-08-02 8:47 ` rguenth at gcc dot gnu.org
2023-08-04 17:26 ` pinskia at gcc dot gnu.org
7 siblings, 0 replies; 8+ messages in thread
From: rguenth at gcc dot gnu.org @ 2023-08-02 8:47 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=92335
Richard Biener <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Known to work| |14.0
Summary|[11/12/13/14 Regression] |[11/12/13 Regression]
|sinking of loads happen too |sinking of loads happen too
|early which causes |early which causes
|vectorization not to be |vectorization not to be
|done |done
--- Comment #9 from Richard Biener <rguenth at gcc dot gnu.org> ---
Fixed for GCC 14, very unlikely to be backported.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug tree-optimization/92335] [11/12/13 Regression] sinking of loads happen too early which causes vectorization not to be done
[not found] <bug-92335-4@http.gcc.gnu.org/bugzilla/>
` (6 preceding siblings ...)
2023-08-02 8:47 ` [Bug tree-optimization/92335] [11/12/13 " rguenth at gcc dot gnu.org
@ 2023-08-04 17:26 ` pinskia at gcc dot gnu.org
7 siblings, 0 replies; 8+ messages in thread
From: pinskia at gcc dot gnu.org @ 2023-08-04 17:26 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=92335
--- Comment #10 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
*** Bug 95084 has been marked as a duplicate of this bug. ***
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2023-08-04 17:26 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <bug-92335-4@http.gcc.gnu.org/bugzilla/>
2021-07-10 13:40 ` [Bug tree-optimization/92335] [10/11/12 Regression] sinking of loads happen too early which causes vectorization not to be done pinskia at gcc dot gnu.org
2022-01-21 13:44 ` rguenth at gcc dot gnu.org
2022-06-28 10:38 ` [Bug tree-optimization/92335] [10/11/12/13 " jakub at gcc dot gnu.org
2023-07-07 10:36 ` [Bug tree-optimization/92335] [11/12/13/14 " rguenth at gcc dot gnu.org
2023-07-27 13:52 ` rguenth at gcc dot gnu.org
2023-08-02 8:46 ` cvs-commit at gcc dot gnu.org
2023-08-02 8:47 ` [Bug tree-optimization/92335] [11/12/13 " rguenth at gcc dot gnu.org
2023-08-04 17:26 ` pinskia at gcc dot gnu.org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).