[Bug fortran/93340] [8/9/10 Regression] ICE in check_constant_initializer, at fortran/trans-decl.c:5450

[Bug fortran/93340] [8/9/10 Regression] ICE in check_constant_initializer, at fortran/trans-decl.c:5450

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93340

--- Comment #4 from anlauf at gcc dot gnu.org ---
AFAICS the code in comment#0 is non-standard:

% gfc-trunk foo.f90 -std=f2018
z1.f90:2:20:

    2 |    character c(2) /'a', 'b'(1:1)/
      |                    1
Error: GNU Extension: Old-style initialization at (1)
z1.f90:3:20:

    3 |    character d(2) /'a', 'bc'(1:1)/
      |                    1
Error: GNU Extension: Old-style initialization at (1)

[Bug fortran/93340] [8/9/10/11 Regression] ICE in check_constant_initializer, at fortran/trans-decl.c:5450

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93340

anlauf at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |anlauf at gcc dot gnu.org

--- Comment #5 from anlauf at gcc dot gnu.org ---
There is also a related missed simplification of substrings.
The dump-tree of

subroutine p
  call foo ('abcd'(1:1))
end

is:

void p ()
{
  foo (&"abcd"[1]{lb: 1 sz: 1}, 1);
}


I'd expect:

void p ()
{
  foo (&"a"[1]{lb: 1 sz: 1}, 1);
}

which we get for

  call foo ('a'(1:1))

or

  call foo ('a')

[Bug fortran/93340] [8/9/10/11 Regression] ICE in check_constant_initializer, at fortran/trans-decl.c:5450

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93340

--- Comment #6 from anlauf at gcc dot gnu.org ---
Tentative patch: https://gcc.gnu.org/pipermail/fortran/2021-January/055589.html

[Bug fortran/93340] [8/9/10/11 Regression] ICE in check_constant_initializer, at fortran/trans-decl.c:5450

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93340

--- Comment #7 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Harald Anlauf <anlauf@gcc.gnu.org>:

https://gcc.gnu.org/g:bdd1b1f55529da00b867ef05a53a08fbfc3d1c2e

commit r11-6687-gbdd1b1f55529da00b867ef05a53a08fbfc3d1c2e
Author: Harald Anlauf <anlauf@gmx.de>
Date:   Thu Jan 14 20:25:33 2021 +0100

    PR fortran/93340 - fix missed substring simplifications

    Substrings were not reduced early enough for use in initializations,
    such as DATA statements.  Add an early simplification for substrings
    with constant starting and ending points.

    gcc/fortran/ChangeLog:

            * gfortran.h (gfc_resolve_substring): Add prototype.
            * primary.c (match_string_constant): Simplify substrings with
            constant starting and ending points.
            * resolve.c: Rename resolve_substring to gfc_resolve_substring.
            (gfc_resolve_ref): Use renamed function gfc_resolve_substring.

    gcc/testsuite/ChangeLog:

            * substr_10.f90: New test.
            * substr_9.f90: New test.

[Bug fortran/93340] [8/9/10/11 Regression] ICE in check_constant_initializer, at fortran/trans-decl.c:5450

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93340

anlauf at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at gcc dot gnu.org      |anlauf at gcc dot gnu.org
             Status|NEW                         |ASSIGNED

--- Comment #8 from anlauf at gcc dot gnu.org ---
Should be fixed on master.

[Bug fortran/93340] [8/9/10/11 Regression] ICE in check_constant_initializer, at fortran/trans-decl.c:5450

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93340

--- Comment #9 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-10 branch has been updated by Harald Anlauf
<anlauf@gcc.gnu.org>:

https://gcc.gnu.org/g:c5ba7770768ed0a7b5d61a3a2fa1625d98be351f

commit r10-9391-gc5ba7770768ed0a7b5d61a3a2fa1625d98be351f
Author: Harald Anlauf <anlauf@gmx.de>
Date:   Thu Jan 14 20:25:33 2021 +0100

    PR fortran/93340 - fix missed substring simplifications

    Substrings were not reduced early enough for use in initializations,
    such as DATA statements.  Add an early simplification for substrings
    with constant starting and ending points.

    gcc/fortran/ChangeLog:

            * gfortran.h (gfc_resolve_substring): Add prototype.
            * primary.c (match_string_constant): Simplify substrings with
            constant starting and ending points.
            * resolve.c: Rename resolve_substring to gfc_resolve_substring.
            (gfc_resolve_ref): Use renamed function gfc_resolve_substring.

    gcc/testsuite/ChangeLog:

            * substr_10.f90: New test.
            * substr_9.f90: New test.

    (cherry picked from commit bdd1b1f55529da00b867ef05a53a08fbfc3d1c2e)

[Bug fortran/93340] [8/9/10/11 Regression] ICE in check_constant_initializer, at fortran/trans-decl.c:5450

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93340

--- Comment #10 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-9 branch has been updated by Harald Anlauf
<anlauf@gcc.gnu.org>:

https://gcc.gnu.org/g:2259e712a6348bd23586dde06cc874a35fdc53c3

commit r9-9252-g2259e712a6348bd23586dde06cc874a35fdc53c3
Author: Harald Anlauf <anlauf@gmx.de>
Date:   Thu Jan 14 20:25:33 2021 +0100

    PR fortran/93340 - fix missed substring simplifications

    Substrings were not reduced early enough for use in initializations,
    such as DATA statements.  Add an early simplification for substrings
    with constant starting and ending points.

    gcc/fortran/ChangeLog:

            * gfortran.h (gfc_resolve_substring): Add prototype.
            * primary.c (match_string_constant): Simplify substrings with
            constant starting and ending points.
            * resolve.c: Rename resolve_substring to gfc_resolve_substring.
            (gfc_resolve_ref): Use renamed function gfc_resolve_substring.

    gcc/testsuite/ChangeLog:

            * substr_10.f90: New test.
            * substr_9.f90: New test.

    (cherry picked from commit bdd1b1f55529da00b867ef05a53a08fbfc3d1c2e)

[Bug fortran/93340] [8 Regression] ICE in check_constant_initializer, at fortran/trans-decl.c:5450

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93340

anlauf at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED
   Target Milestone|8.5                         |9.4
            Summary|[8/9/10/11 Regression] ICE  |[8 Regression] ICE in
                   |in                          |check_constant_initializer,
                   |check_constant_initializer, |at
                   |at                          |fortran/trans-decl.c:5450
                   |fortran/trans-decl.c:5450   |

--- Comment #11 from anlauf at gcc dot gnu.org ---
Backported to 10- and 9-branches without changes.

Since it does not apply cleanly to 8-branch, it may not be worth the effort
to adjust the fix and risk new regressions in the final 8-release.
Therefore closing.

Thanks for the report!