[Bug fortran/93635] Get ICE instead of error message if user incorrectly equivalences allocateable variables that are in a NAMELIST group

[Bug fortran/93635] Get ICE instead of error message if user incorrectly equivalences allocateable variables that are in a NAMELIST group

[drikosev at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93635

Ev Drikos <drikosev at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |drikosev at gmail dot com

--- Comment #3 from Ev Drikos <drikosev at gmail dot com> ---
Created attachment 48765
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=48765&action=edit
Various Test Cases, including one for PR/93635

Hello S. Kargl,

The attached patch contains various test cases for the PR's you mentioned at:
https://groups.google.com/d/msg/comp.lang.fortran/Xu73gGydAJk/X2YXyjndCAAJ

You simply apply it to your local working tree (ignore whatever fails).

patch -p0 < gcc48-tc93635-n.patch

Just ensure that these test cases indeed make some sense; they need a review.

Ev. Drikos

[Bug fortran/93635] Get ICE instead of error message if user incorrectly equivalences allocateable variables that are in a NAMELIST group

[sgk at troutmask dot apl.washington.edu]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93635

--- Comment #4 from Steve Kargl <sgk at troutmask dot apl.washington.edu> ---
On Sun, Jun 21, 2020 at 05:44:51PM +0000, drikosev at gmail dot com wrote:
> 
> The attached patch contains various test cases for the PR's you mentioned at:
> https://groups.google.com/d/msg/comp.lang.fortran/Xu73gGydAJk/X2YXyjndCAAJ
> 
> You simply apply it to your local working tree (ignore whatever fails).
> 
> patch -p0 < gcc48-tc93635-n.patch
> 
> Just ensure that these test cases indeed make some sense; they need a review.
> 

Thanks.  Now, what is needed is someone taking the next
step to becoming a gfortran contributor in the sense 
that she/he can commit changes to source tree.

[Bug fortran/93635] Get ICE instead of error message if user incorrectly equivalences allocateable variables that are in a NAMELIST group

[drikosev at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93635

--- Comment #5 from Ev Drikos <drikosev at gmail dot com> ---
(In reply to Ev Drikos from comment #3)
> Created attachment 48765 [details]
> Various Test Cases, including one for PR/93635
> 
> Hello S. Kargl,
> 
> The attached patch contains various test cases for the PR's you mentioned at:
> https://groups.google.com/d/msg/comp.lang.fortran/Xu73gGydAJk/X2YXyjndCAAJ
> 
> You simply apply it to your local working tree (ignore whatever fails).
> 
> patch -p0 < gcc48-tc93635-n.patch
> 
> Just ensure that these test cases indeed make some sense; they need a review.
> 
> Ev. Drikos

Hello again,

1. The first test case in the patch file (elemental_optional_args_6.f90) likely
   doesn't apply smoothly but one has to change the test case (manually).
2. As I run the tests again I see that the test case coarray_3.f90 fails? due
to
   PR/95613. So, I've removed: gcc/testsuite/gfortran.dg/pr95613.f90

Ev. Drikos

PS: Hope you haven't committed these patch file yet!

[Bug fortran/93635] Get ICE instead of error message if user incorrectly equivalences allocateable variables that are in a NAMELIST group

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93635

anlauf at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |anlauf at gcc dot gnu.org

--- Comment #6 from anlauf at gcc dot gnu.org ---
Created attachment 54652
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=54652&action=edit
Updated patch

Hi Steve,

the attachment contains a slightly simpler version of the patch in comment#2.
It needs to be amended by the adjustment of gfortran.dg/pr87907.f90 and a
modification of the patterns in gfortran.dg/c-interop/c1255-2.f90 .
I've stripped the unrelated parts in comment#2.

If you agree, I can prepare the patch for submission.

[Bug fortran/93635] Get ICE instead of error message if user incorrectly equivalences allocateable variables that are in a NAMELIST group

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93635

anlauf at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |ice-on-invalid-code

--- Comment #7 from anlauf at gcc dot gnu.org ---
(In reply to anlauf from comment #6)
> Created attachment 54652 [details]
> Updated patch

Actually that patch still produces the ICE mentioned in comment#1,
which seems to follow from issues in namespace handling.

So better wait till these issues are resolved.  A hack to solve the
present PR might not be what we want...

[Bug fortran/93635] Get ICE instead of error message if user incorrectly equivalences allocateable variables that are in a NAMELIST group

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93635

--- Comment #8 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Harald Anlauf <anlauf@gcc.gnu.org>:

https://gcc.gnu.org/g:9561cf550a66a89e7c8d31202a03c4fddf82a3f2

commit r15-828-g9561cf550a66a89e7c8d31202a03c4fddf82a3f2
Author: Harald Anlauf <anlauf@gmx.de>
Date:   Thu May 23 21:13:00 2024 +0200

    Fortran: improve attribute conflict checking [PR93635]

    gcc/fortran/ChangeLog:

            PR fortran/93635
            * symbol.cc (conflict_std): Helper function for reporting attribute
            conflicts depending on the Fortran standard version.
            (conf_std): Helper macro for checking standard-dependent conflicts.
            (gfc_check_conflict): Use it.

    gcc/testsuite/ChangeLog:

            PR fortran/93635
            * gfortran.dg/c-interop/c1255-2.f90: Adjust pattern.
            * gfortran.dg/pr87907.f90: Likewise.
            * gfortran.dg/pr93635.f90: New test.

    Co-authored-by: Steven G. Kargl <kargl@gcc.gnu.org>

[Bug fortran/93635] Get ICE instead of error message if user incorrectly equivalences allocateable variables that are in a NAMELIST group

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93635

anlauf at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #9 from anlauf at gcc dot gnu.org ---
Fixed on mainline for gcc-15.