[Bug fortran/93660] Decl mismatch between fndecl TYPE and used arglist / ICE in ipa_simd_modify_function_body, at omp-simd-clone.c:993

[Bug fortran/93660] Decl mismatch between fndecl TYPE and used arglist / ICE in ipa_simd_modify_function_body, at omp-simd-clone.c:993

[burnus at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93660

Tobias Burnus <burnus at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |wrong-code
            Summary|ICE in                      |Decl mismatch between
                   |ipa_simd_modify_function_bo |fndecl TYPE and used
                   |dy, at omp-simd-clone.c:993 |arglist / ICE in
                   |                            |ipa_simd_modify_function_bo
                   |                            |dy, at omp-simd-clone.c:993
                 CC|                            |burnus at gcc dot gnu.org

--- Comment #2 from Tobias Burnus <burnus at gcc dot gnu.org> ---
The bug seems to be that
   gfc_get_function_type ()

does not contain all hidden arguments, which are then later added by
   create_function_arglist

In particular: OPTIONAL + VALUE, coarray -fcoarray=lib (token, offset), ...?

[Bug fortran/93660] Decl mismatch between fndecl TYPE and used arglist / ICE in ipa_simd_modify_function_body, at omp-simd-clone.c:993

[burnus at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93660

--- Comment #3 from Tobias Burnus <burnus at gcc dot gnu.org> ---
Patch: https://gcc.gnu.org/pipermail/fortran/2021-March/055816.html

[Bug fortran/93660] Decl mismatch between fndecl TYPE and used arglist / ICE in ipa_simd_modify_function_body, at omp-simd-clone.c:993

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93660

--- Comment #4 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tobias Burnus <burnus@gcc.gnu.org>:

https://gcc.gnu.org/g:212f4988f37ccf788c8c72b1dc952980bc9be3b7

commit r11-7788-g212f4988f37ccf788c8c72b1dc952980bc9be3b7
Author: Tobias Burnus <tobias@codesourcery.com>
Date:   Tue Mar 23 15:45:36 2021 +0100

    Fortran: Fix func decl mismatch [PR93660]

    gcc/fortran/ChangeLog:

            PR fortran/93660
            * trans-decl.c (build_function_decl): Add comment;
            increment hidden_typelist for caf_token/caf_offset.
            * trans-types.c (gfc_get_function_type): Add comment;
            add missing caf_token/caf_offset args.

    gcc/testsuite/ChangeLog:

            PR fortran/93660
            * gfortran.dg/gomp/declare-simd-coarray-lib.f90: New test.

[Bug fortran/93660] Decl mismatch between fndecl TYPE and used arglist / ICE in ipa_simd_modify_function_body, at omp-simd-clone.c:993

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93660

--- Comment #5 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-10 branch has been updated by Tobias Burnus
<burnus@gcc.gnu.org>:

https://gcc.gnu.org/g:3e34bdeaf3b9c294fa8a2b15d5efc866f377b264

commit r10-9543-g3e34bdeaf3b9c294fa8a2b15d5efc866f377b264
Author: Tobias Burnus <tobias@codesourcery.com>
Date:   Tue Mar 23 15:45:36 2021 +0100

    Fortran: Fix func decl mismatch [PR93660]

    gcc/fortran/ChangeLog:

            PR fortran/93660
            * trans-decl.c (build_function_decl): Add comment;
            increment hidden_typelist for caf_token/caf_offset.
            * trans-types.c (gfc_get_function_type): Add comment;
            add missing caf_token/caf_offset args.

    gcc/testsuite/ChangeLog:

            PR fortran/93660
            * gfortran.dg/gomp/declare-simd-coarray-lib.f90: New test.

    (cherry picked from commit 212f4988f37ccf788c8c72b1dc952980bc9be3b7)

[Bug fortran/93660] Decl mismatch between fndecl TYPE and used arglist / ICE in ipa_simd_modify_function_body, at omp-simd-clone.c:993

[burnus at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93660

Tobias Burnus <burnus at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #6 from Tobias Burnus <burnus at gcc dot gnu.org> ---
FIXED on mainline (GCC 11) and on the GCC 10 release branch – both will see a
release soon.

Thanks for all the bug reports!

[Bug fortran/93660] Decl mismatch between fndecl TYPE and used arglist / ICE in ipa_simd_modify_function_body, at omp-simd-clone.c:993

[clyon at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93660

Christophe Lyon <clyon at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |clyon at gcc dot gnu.org

--- Comment #7 from Christophe Lyon <clyon at gcc dot gnu.org> ---
Hi, the new test fails on aarch64:

FAIL: gfortran.dg/gomp/declare-simd-coarray-lib.f90   -O  (test for excess
errors)
Excess errors:
/gcc/testsuite/gfortran.dg/gomp/declare-simd-coarray-lib.f90:8:18: Warning: GCC
does not currently support mixed size types for 'simd' functions

[Bug fortran/93660] Decl mismatch between fndecl TYPE and used arglist / ICE in ipa_simd_modify_function_body, at omp-simd-clone.c:993

[burnus at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93660

--- Comment #8 from Tobias Burnus <burnus at gcc dot gnu.org> ---
(In reply to Christophe Lyon from comment #7)
> Excess errors:
> /gcc/testsuite/gfortran.dg/gomp/declare-simd-coarray-lib.f90:8:18: Warning:
> GCC does not currently support mixed size types for 'simd' functions

Looking for that string, I find plenty of those in the testsuite as:

* gcc/testsuite/g++.dg/gomp/pr88182.C:
// { dg-warning "GCC does not currently support mixed size types for 'simd'
functions" "" { target aarch64*-*-* } .-15 }

* gcc/testsuite/gcc.dg/declare-simd.c:
/* { dg-warning "GCC does not currently support mixed size types for 'simd'
functions" "" { target { { aarch64*-*-* } && lp64 } } .-1 } */

Thus, it looks as if has to be xfailed. As you can test whether adding xfail
works, can you simply add it yourself, test it and commit it then?

[Bug fortran/93660] Decl mismatch between fndecl TYPE and used arglist / ICE in ipa_simd_modify_function_body, at omp-simd-clone.c:993

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93660

--- Comment #9 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:afa8c67eb95f669a9bd8e356ffa073418bb269cb

commit r11-7892-gafa8c67eb95f669a9bd8e356ffa073418bb269cb
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Mon Mar 29 17:05:47 2021 +0200

    testsuite: Expect a warning on aarch64 for declare-simd-coarray-lib.f90
[PR93660]

    aarch64 currently doesn't support declare simd where the return value and
arguments
    have different sizes and warns about that case.  This change adds a
dg-warning
    for that case like various other tests have already.

    2021-03-29  Jakub Jelinek  <jakub@redhat.com>

            PR fortran/93660
            * gfortran.dg/gomp/declare-simd-coarray-lib.f90: Expect a mixed
size
            declare simd warning on aarch64.

[Bug fortran/93660] Decl mismatch between fndecl TYPE and used arglist / ICE in ipa_simd_modify_function_body, at omp-simd-clone.c:993

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93660

--- Comment #10 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-10 branch has been updated by Christophe Lyon
<clyon@gcc.gnu.org>:

https://gcc.gnu.org/g:960eaefb99a805dd6afdc1f223055bd2458d6c49

commit r10-9617-g960eaefb99a805dd6afdc1f223055bd2458d6c49
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Mon Mar 29 17:05:47 2021 +0200

    testsuite: Expect a warning on aarch64 for declare-simd-coarray-lib.f90
[PR93660]

    aarch64 currently doesn't support declare simd where the return value and
arguments
    have different sizes and warns about that case.  This change adds a
dg-warning
    for that case like various other tests have already.

    2021-03-29  Jakub Jelinek  <jakub@redhat.com>

            PR fortran/93660
            * gfortran.dg/gomp/declare-simd-coarray-lib.f90: Expect a mixed
size
            declare simd warning on aarch64.