[Bug fortran/93678] [9/10/11 Regression] ICE in 9.2/9.2.1 not happening in previous gfortran versions

[Bug fortran/93678] [9/10/11 Regression] ICE in 9.2/9.2.1 not happening in previous gfortran versions

[tkoenig at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93678

Thomas Koenig <tkoenig at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|ICE in 9.2/9.2.1 not        |[9/10/11 Regression] ICE in
                   |happening in previous       |9.2/9.2.1 not happening in
                   |gfortran versions           |previous gfortran versions
   Target Milestone|---                         |9.4
                 CC|                            |tkoenig at gcc dot gnu.org

[Bug fortran/93678] [9/10/11 Regression] ICE in 9.2/9.2.1 not happening in previous gfortran versions

[tkoenig at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93678

--- Comment #5 from Thomas Koenig <tkoenig at gcc dot gnu.org> ---
A somewhat smaller test case, which of course does nothing useful,
but still reproduces the ICE:

module mo_a
  implicit none
  type t_b
     integer :: n = 0
     integer :: nr = 0
     character, pointer :: buffer(:) => NULL()
   contains
     procedure :: unpackbytes => b_unpackbytes  
  end type t_b
  character :: characterarraymold(1)
contains
  subroutine b_unpackint(me, val)
    class(t_b), intent(inout) :: me
    integer, intent(out) :: val
    val = transfer(me%unpackbytes(transfer(val, characterarraymold)),  val)
  end subroutine b_unpackint
  function b_unpackbytes(me, bytearraymold) result(res)
    class(t_b), intent(inout) :: me
    character, intent(in) :: bytearraymold(:)
    character, pointer :: res(:)
  end function b_unpackbytes
end module mo_a

[Bug fortran/93678] [9/10/11 Regression] ICE with TRANSFER and typebound procedures

[tkoenig at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93678

Thomas Koenig <tkoenig at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[9/10/11 Regression] ICE in |[9/10/11 Regression] ICE
                   |9.2/9.2.1 not happening in  |with TRANSFER and typebound
                   |previous gfortran versions  |procedures

--- Comment #6 from Thomas Koenig <tkoenig at gcc dot gnu.org> ---
So, it is the typebound procedure that causes the problem.

This does not ICE:

    val = transfer(b_unpackbytes(me, characterarraymold), val)

But this does ICE:

    val = transfer(me%unpackbytes(characterarraymold), val)

[Bug fortran/93678] [8/9/10/11 Regression] ICE with TRANSFER and typebound procedures

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93678

--- Comment #7 from anlauf at gcc dot gnu.org ---
(In reply to Thomas Koenig from comment #5)
> A somewhat smaller test case, which of course does nothing useful,
> but still reproduces the ICE:

Further reduced / simplified:

module mo_a
  implicit none
  type t_b
  contains
    procedure :: unpackbytes => b_unpackbytes  
  end type t_b
contains
  subroutine b_unpackint (me)
    class(t_b), intent(inout) :: me
    integer :: val
    val = transfer (me% unpackbytes ("*"), val)
  end subroutine b_unpackint
  function b_unpackbytes (me, bytearraymold) result (res)
    class(t_b), intent(inout) :: me
    character(*), intent(in)  :: bytearraymold
    character                 :: res(1)
  end function b_unpackbytes
end module mo_a

[Bug fortran/93678] [8/9/10/11 Regression] ICE with TRANSFER and typebound procedures

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93678

--- Comment #8 from anlauf at gcc dot gnu.org ---
Further reduced:

module mo_a
  implicit none
  type t_b
  contains
    procedure :: unpackbytes => b_unpackbytes  
  end type t_b
contains
  function b_unpackbytes (me) result (res)
    class(t_b), intent(inout) :: me
    character                 :: res(1)
  end function b_unpackbytes
  subroutine b_unpackint (me)
    class(t_b), intent(inout) :: me
!   print *, b_unpackbytes (me) ! ok
    print *, me% unpackbytes () ! ICE
  end subroutine b_unpackint
end module mo_a


The "arrayness" of the result res seems to be key.

[Bug fortran/93678] [8/9/10/11 Regression] ICE with TRANSFER and typebound procedures

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93678

--- Comment #9 from anlauf at gcc dot gnu.org ---
Another data point: comparing the -fdump-fortran-original of

    res = b_unpackbytes (me) ! ok

vs.

    res = me% unpackbytes () ! ICE

I see:

    ASSIGN b_unpackint:res(FULL) b_unpackbytes[[((b_unpackint:me))]]

vs.

    ASSIGN b_unpackint:res(FULL) b_unpackbytes % _vptr %
unpackbytes[[((b_unpackint:me))]]

This hasn't changed since gcc-7.  Maybe Paul(?) has some idea?

[Bug fortran/93678] [9/10/11/12 Regression] ICE with TRANSFER and typebound procedures

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93678

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|9.4                         |9.5

--- Comment #10 from Richard Biener <rguenth at gcc dot gnu.org> ---
GCC 9.4 is being released, retargeting bugs to GCC 9.5.

[Bug fortran/93678] [10/11/12/13 Regression] ICE with TRANSFER and typebound procedures

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93678

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|9.5                         |10.4

--- Comment #11 from Richard Biener <rguenth at gcc dot gnu.org> ---
GCC 9 branch is being closed

[Bug fortran/93678] [10/11/12/13 Regression] ICE with TRANSFER and typebound procedures

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93678

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|10.4                        |10.5

--- Comment #12 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
GCC 10.4 is being released, retargeting bugs to GCC 10.5.

[Bug fortran/93678] [11/12/13/14 Regression] ICE with TRANSFER and typebound procedures

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93678

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|10.5                        |11.5

--- Comment #13 from Richard Biener <rguenth at gcc dot gnu.org> ---
GCC 10 branch is being closed.

[Bug fortran/93678] [11/12/13/14 Regression] ICE with TRANSFER and typebound procedures

[pault at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93678

Paul Thomas <pault at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at gcc dot gnu.org      |pault at gcc dot gnu.org
                 CC|                            |pault at gcc dot gnu.org

--- Comment #14 from Paul Thomas <pault at gcc dot gnu.org> ---
Created attachment 58026
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=58026&action=edit
Fix for this PR

I'll package it all up for the list in the next 24 hours. Regtests OK, the
testcase of comment 1 compiles and this runs fine:

! { dg-do compile }
! Test the fix for PR93678 in which the charlen for the 'unpackbytes'
! vtable field was incomplete and caused the ICE as indicated.
! Contributed by Luis Kornblueh  <mail.luis@web.de>
!
! The testcase was reduced by various gfortran regulars.
module mo_a
  implicit none
  type t_b
    integer :: i
  contains
    procedure :: unpackbytes => b_unpackbytes
  end type t_b
contains
  function b_unpackbytes (me) result (res)
    class(t_b), intent(inout) :: me
    character                 :: res(1)
    res = char (me%i)
  end function b_unpackbytes
  subroutine b_unpackint (me, c)
    class(t_b), intent(inout) :: me
    character, intent(in) :: c
!   print *, b_unpackbytes (me) ! ok
    if (any (me% unpackbytes () .ne. c)) stop 1 ! ICEd here
  end subroutine b_unpackint
end module mo_a

  use mo_a
  class(t_b), allocatable :: z
  allocate (z, source = t_b(97))
  call b_unpackint (z, "a")
end

[Bug fortran/93678] [11/12/13/14 Regression] ICE with TRANSFER and typebound procedures

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93678

--- Comment #15 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Paul Thomas <pault@gcc.gnu.org>:

https://gcc.gnu.org/g:c058105bc47a0701e157d1028e60f48554561f9f

commit r14-10116-gc058105bc47a0701e157d1028e60f48554561f9f
Author: Paul Thomas <pault@gcc.gnu.org>
Date:   Thu Apr 25 06:56:10 2024 +0100

    Fortran: Fix ICE in gfc_trans_create_temp_array from bad type [PR93678]

    2024-04-25  Paul Thomas  <pault@gcc.gnu.org>

    gcc/fortran
            PR fortran/93678
            * trans-expr.cc (gfc_conv_procedure_call): Use the interface,
            where possible, to obtain the type of character procedure
            pointers of class entities.

    gcc/testsuite/
            PR fortran/93678
            * gfortran.dg/pr93678.f90: New test.

[Bug fortran/93678] [11/12/13 Regression] ICE with TRANSFER and typebound procedures

[pault at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93678

Paul Thomas <pault at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[11/12/13/14 Regression]    |[11/12/13 Regression] ICE
                   |ICE with TRANSFER and       |with TRANSFER and typebound
                   |typebound procedures        |procedures

--- Comment #16 from Paul Thomas <pault at gcc dot gnu.org> ---
Fixed on mainline, so changing summary. Will backport in a couple of weeks.

Paul

[Bug fortran/93678] [11/12/13 Regression] ICE with TRANSFER and typebound procedures

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93678

--- Comment #17 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-13 branch has been updated by Paul Thomas <pault@gcc.gnu.org>:

https://gcc.gnu.org/g:80bb0bda4a96da7e690cb4df572fcb9604f511f8

commit r13-8716-g80bb0bda4a96da7e690cb4df572fcb9604f511f8
Author: Paul Thomas <pault@gcc.gnu.org>
Date:   Thu Apr 25 06:56:10 2024 +0100

    Fortran: Fix ICE in gfc_trans_create_temp_array from bad type [PR93678]

    2024-04-25  Paul Thomas  <pault@gcc.gnu.org>

    gcc/fortran
            PR fortran/93678
            * trans-expr.cc (gfc_conv_procedure_call): Use the interface,
            where possible, to obtain the type of character procedure
            pointers of class entities.

    gcc/testsuite/
            PR fortran/93678
            * gfortran.dg/pr93678.f90: New test.

    (cherry picked from commit c058105bc47a0701e157d1028e60f48554561f9f)

[Bug fortran/93678] [11/12/13 Regression] ICE with TRANSFER and typebound procedures

[pault at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93678

Paul Thomas <pault at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #18 from Paul Thomas <pault at gcc dot gnu.org> ---
Fixed on 13- through 15-branches. Thanks for the report.

Paul