[Bug fortran/94104] New: Request for diagnostic improvement

[Bug fortran/94104] New: Request for diagnostic improvement

[jrfsousa at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94104

            Bug ID: 94104
           Summary: Request for diagnostic improvement
           Product: gcc
           Version: 10.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: fortran
          Assignee: unassigned at gcc dot gnu.org
          Reporter: jrfsousa at gmail dot com
  Target Milestone: ---

Created attachment 47999
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=47999&action=edit
Code demonstrating problems.

Hi all!

Minor nitpick, the attached program raises an error:

$ gfortran ./diag.f90
./diag.f90:10:16:

   10 |   print *, sumf(a)
      |                1
Error: Actual argument for ‘a’ must be a pointer at (1)

in both:

GNU Fortran (GCC) 9.2.1 20200307

and

GNU Fortran (GCC) 10.0.1 20200307 (experimental)

The diagnostic is a bit misleading as the variable can be pointer or target.

Thank you very much.

Best regards,
José Rui

[Bug fortran/94104] Request for diagnostic improvement

[tkoenig at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94104

Thomas Koenig <tkoenig at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
   Last reconfirmed|                            |2020-04-11
             Status|UNCONFIRMED                 |NEW
                 CC|                            |tkoenig at gcc dot gnu.org
           Severity|normal                      |enhancement

--- Comment #1 from Thomas Koenig <tkoenig at gcc dot gnu.org> ---
Would be useful, yes.

[Bug fortran/94104] Request for diagnostic improvement

[jrfsousa at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94104

--- Comment #2 from José Rui Faustino de Sousa <jrfsousa at gcc dot gnu.org> ---
Patch posted:

https://gcc.gnu.org/pipermail/fortran/2021-June/056162.html

[Bug fortran/94104] Request for diagnostic improvement

[jrfsousa at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94104

--- Comment #3 from José Rui Faustino de Sousa <jrfsousa at gcc dot gnu.org> ---
Created attachment 51013
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=51013&action=edit
Error message improvement

[Bug fortran/94104] Request for diagnostic improvement

[jrfsousa at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94104

José Rui Faustino de Sousa <jrfsousa at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

[Bug fortran/94104] Request for diagnostic improvement

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94104

anlauf at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |anlauf at gcc dot gnu.org

--- Comment #4 from anlauf at gcc dot gnu.org ---
Pinged here: https://gcc.gnu.org/pipermail/fortran/2022-November/058471.html

[Bug fortran/94104] Request for diagnostic improvement

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94104

--- Comment #5 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Harald Anlauf <anlauf@gcc.gnu.org>:

https://gcc.gnu.org/g:58e7732a2feddf475e72b232bf16494d84a41acf

commit r13-3946-g58e7732a2feddf475e72b232bf16494d84a41acf
Author: José Rui Faustino de Sousa <jrfsousa@gmail.com>
Date:   Wed Nov 9 21:30:25 2022 +0100

    Fortran: diagnostics for actual arguments to pointer dummy arguments
[PR94104]

    Error message improvement.  In Fortran 2008 actual procedure arguments
    associated with a pointer, intent(in) attribute, dummy argument
    can also have the target attribute, not just pointer.

    gcc/fortran/ChangeLog:

            PR fortran/94104
            * interface.cc (gfc_compare_actual_formal): Improve error message
            dependent on Fortran standard level.

    gcc/testsuite/ChangeLog:

            PR fortran/94104
            * gfortran.dg/parens_2.f90: Adjust to improved error message.
            * gfortran.dg/PR94104a.f90: New test.
            * gfortran.dg/PR94104b.f90: New test.

[Bug fortran/94104] Request for diagnostic improvement

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94104

anlauf at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED
   Target Milestone|---                         |13.0

--- Comment #6 from anlauf at gcc dot gnu.org ---
Fixed for gcc-13.  Closing.

Thanks for the patch!