public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug rtl-optimization/94148] New: The DF framework uses bb->aux, which is for passes only
@ 2020-03-11 16:57 segher at gcc dot gnu.org
2020-03-11 16:57 ` [Bug rtl-optimization/94148] " segher at gcc dot gnu.org
` (7 more replies)
0 siblings, 8 replies; 9+ messages in thread
From: segher at gcc dot gnu.org @ 2020-03-11 16:57 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94148
Bug ID: 94148
Summary: The DF framework uses bb->aux, which is for passes
only
Product: gcc
Version: unknown
Status: UNCONFIRMED
Severity: normal
Priority: P3
Component: rtl-optimization
Assignee: unassigned at gcc dot gnu.org
Reporter: segher at gcc dot gnu.org
Target Milestone: ---
df-core.c:df_worklist_dataflow_doublequeue uses bb->aux, clobbering it,
while that field is documented as
/* Auxiliary info specific to a pass. */
PTR GTY ((skip (""))) aux;
and some passes that do use DF also use bb->aux. This gives problems
with overlapping lifetimes.
This blocks fixing PR94042 properly.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug rtl-optimization/94148] The DF framework uses bb->aux, which is for passes only
2020-03-11 16:57 [Bug rtl-optimization/94148] New: The DF framework uses bb->aux, which is for passes only segher at gcc dot gnu.org
@ 2020-03-11 16:57 ` segher at gcc dot gnu.org
2020-03-12 9:01 ` rguenth at gcc dot gnu.org
` (6 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: segher at gcc dot gnu.org @ 2020-03-11 16:57 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94148
Segher Boessenkool <segher at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |94042
Target Milestone|--- |10.0
Referenced Bugs:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94042
[Bug 94042] [10 Regression] Bootstrap fails on ppc-linux-gnu
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug rtl-optimization/94148] The DF framework uses bb->aux, which is for passes only
2020-03-11 16:57 [Bug rtl-optimization/94148] New: The DF framework uses bb->aux, which is for passes only segher at gcc dot gnu.org
2020-03-11 16:57 ` [Bug rtl-optimization/94148] " segher at gcc dot gnu.org
@ 2020-03-12 9:01 ` rguenth at gcc dot gnu.org
2020-03-12 13:55 ` segher at gcc dot gnu.org
` (5 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: rguenth at gcc dot gnu.org @ 2020-03-12 9:01 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94148
Richard Biener <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Ever confirmed|0 |1
Status|UNCONFIRMED |NEW
Last reconfirmed| |2020-03-12
--- Comment #1 from Richard Biener <rguenth at gcc dot gnu.org> ---
In fact it even assumes it is cleared on entry!
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug rtl-optimization/94148] The DF framework uses bb->aux, which is for passes only
2020-03-11 16:57 [Bug rtl-optimization/94148] New: The DF framework uses bb->aux, which is for passes only segher at gcc dot gnu.org
2020-03-11 16:57 ` [Bug rtl-optimization/94148] " segher at gcc dot gnu.org
2020-03-12 9:01 ` rguenth at gcc dot gnu.org
@ 2020-03-12 13:55 ` segher at gcc dot gnu.org
2020-03-13 17:53 ` segher at gcc dot gnu.org
` (4 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: segher at gcc dot gnu.org @ 2020-03-12 13:55 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94148
Segher Boessenkool <segher at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
Assignee|unassigned at gcc dot gnu.org |segher at gcc dot gnu.org
--- Comment #2 from Segher Boessenkool <segher at gcc dot gnu.org> ---
Yes, and it assumes it stays cleared for any new blocks, and some more
subtleties.
I have a patch.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug rtl-optimization/94148] The DF framework uses bb->aux, which is for passes only
2020-03-11 16:57 [Bug rtl-optimization/94148] New: The DF framework uses bb->aux, which is for passes only segher at gcc dot gnu.org
` (2 preceding siblings ...)
2020-03-12 13:55 ` segher at gcc dot gnu.org
@ 2020-03-13 17:53 ` segher at gcc dot gnu.org
2020-03-13 22:58 ` segher at gcc dot gnu.org
` (3 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: segher at gcc dot gnu.org @ 2020-03-13 17:53 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94148
--- Comment #3 from Segher Boessenkool <segher at gcc dot gnu.org> ---
Fixed on trunk so far.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug rtl-optimization/94148] The DF framework uses bb->aux, which is for passes only
2020-03-11 16:57 [Bug rtl-optimization/94148] New: The DF framework uses bb->aux, which is for passes only segher at gcc dot gnu.org
` (3 preceding siblings ...)
2020-03-13 17:53 ` segher at gcc dot gnu.org
@ 2020-03-13 22:58 ` segher at gcc dot gnu.org
2020-03-13 22:59 ` segher at gcc dot gnu.org
` (2 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: segher at gcc dot gnu.org @ 2020-03-13 22:58 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94148
--- Comment #4 from Segher Boessenkool <segher at gcc dot gnu.org> ---
Fixed on trunk so far.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug rtl-optimization/94148] The DF framework uses bb->aux, which is for passes only
2020-03-11 16:57 [Bug rtl-optimization/94148] New: The DF framework uses bb->aux, which is for passes only segher at gcc dot gnu.org
` (4 preceding siblings ...)
2020-03-13 22:58 ` segher at gcc dot gnu.org
@ 2020-03-13 22:59 ` segher at gcc dot gnu.org
2020-05-07 11:56 ` jakub at gcc dot gnu.org
2020-07-13 11:12 ` segher at gcc dot gnu.org
7 siblings, 0 replies; 9+ messages in thread
From: segher at gcc dot gnu.org @ 2020-03-13 22:59 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94148
--- Comment #5 from Segher Boessenkool <segher at gcc dot gnu.org> ---
commit 5c7e6d4bdf879b437b43037e10453275acabf521
Author: Segher Boessenkool <segher@kernel.crashing.org>
Date: Thu Mar 12 07:12:50 2020 +0000
df: Don't abuse bb->aux (PR94148, PR94042)
The df dataflow solvers use the aux field in the basic_block struct,
although that is reserved for any use by passes. And not only that,
it is required that you set all such fields to NULL before calling
the solvers, or you quietly get wrong results.
This changes the solvers to use a local array for last_change_age
instead, just like it already had a local array for last_visit_age.
PR rtl-optimization/94148
PR rtl-optimization/94042
* df-core.c (BB_LAST_CHANGE_AGE): Delete.
(df_worklist_propagate_forward): New parameter last_change_age, use
that instead of bb->aux.
(df_worklist_propagate_backward): Ditto.
(df_worklist_dataflow_doublequeue): Use a local array last_change_age.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug rtl-optimization/94148] The DF framework uses bb->aux, which is for passes only
2020-03-11 16:57 [Bug rtl-optimization/94148] New: The DF framework uses bb->aux, which is for passes only segher at gcc dot gnu.org
` (5 preceding siblings ...)
2020-03-13 22:59 ` segher at gcc dot gnu.org
@ 2020-05-07 11:56 ` jakub at gcc dot gnu.org
2020-07-13 11:12 ` segher at gcc dot gnu.org
7 siblings, 0 replies; 9+ messages in thread
From: jakub at gcc dot gnu.org @ 2020-05-07 11:56 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94148
Jakub Jelinek <jakub at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|10.0 |10.2
--- Comment #6 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
GCC 10.1 has been released.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug rtl-optimization/94148] The DF framework uses bb->aux, which is for passes only
2020-03-11 16:57 [Bug rtl-optimization/94148] New: The DF framework uses bb->aux, which is for passes only segher at gcc dot gnu.org
` (6 preceding siblings ...)
2020-05-07 11:56 ` jakub at gcc dot gnu.org
@ 2020-07-13 11:12 ` segher at gcc dot gnu.org
7 siblings, 0 replies; 9+ messages in thread
From: segher at gcc dot gnu.org @ 2020-07-13 11:12 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94148
Segher Boessenkool <segher at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|ASSIGNED |RESOLVED
--- Comment #7 from Segher Boessenkool <segher at gcc dot gnu.org> ---
It was fixed on trunk before GCC 10 branched off, actually.
I'm not planning on backporting it further, since the issue is ancient
(2010) and we survived all that time.
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2020-07-13 11:12 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-11 16:57 [Bug rtl-optimization/94148] New: The DF framework uses bb->aux, which is for passes only segher at gcc dot gnu.org
2020-03-11 16:57 ` [Bug rtl-optimization/94148] " segher at gcc dot gnu.org
2020-03-12 9:01 ` rguenth at gcc dot gnu.org
2020-03-12 13:55 ` segher at gcc dot gnu.org
2020-03-13 17:53 ` segher at gcc dot gnu.org
2020-03-13 22:58 ` segher at gcc dot gnu.org
2020-03-13 22:59 ` segher at gcc dot gnu.org
2020-05-07 11:56 ` jakub at gcc dot gnu.org
2020-07-13 11:12 ` segher at gcc dot gnu.org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).