public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
* [Bug target/94253] New: FAIL: gfortran.dg/bind_c_coms.f90 -O0 (test for excess errors) @ 2020-03-21 19:24 danglin at gcc dot gnu.org 2020-03-23 12:48 ` [Bug c/94253] " danglin at gcc dot gnu.org ` (5 more replies) 0 siblings, 6 replies; 7+ messages in thread From: danglin at gcc dot gnu.org @ 2020-03-21 19:24 UTC (permalink / raw) To: gcc-bugs https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94253 Bug ID: 94253 Summary: FAIL: gfortran.dg/bind_c_coms.f90 -O0 (test for excess errors) Product: gcc Version: 10.0 Status: UNCONFIRMED Severity: normal Priority: P3 Component: target Assignee: unassigned at gcc dot gnu.org Reporter: danglin at gcc dot gnu.org Target Milestone: --- Host: hppa64-hp-hpux11.11 Target: hppa64-hp-hpux11.11 Build: hppa64-hp-hpux11.11 spawn /test/gnu/gcc/objdir/gcc/testsuite/gfortran/../../gfortran -B/test/gnu/gcc/objdir/gcc/testsuite/gfortran/../../ -B/test/gnu/gcc/objdir/hppa64-hp-hpux11.11/./libgfortran/ /test/gnu/gcc/gcc/gcc/testsuite/gfortran.dg/bind_c_coms.f90 -fno-diagnostics-show-caret -fno-diagnostics-show-line-numbers -fdiagnostics-color=never -fdiagnostics-urls=never -O0 -w /test/gnu/gcc/gcc/gcc/testsuite/gfortran.dg/bind_c_coms_driver.c -B/test/gnu/gcc/objdir/hppa64-hp-hpux11.11/./libgfortran/.libs -L/test/gnu/gcc/objdir/hppa64-hp-hpux11.11/./libgfortran/.libs -L/test/gnu/gcc/objdir/hppa64-hp-hpux11.11/./libgfortran/.libs -L/test/gnu/gcc/objdir/hppa64-hp-hpux11.11/./libatomic/.libs -B/test/gnu/gcc/objdir/hppa64-hp-hpux11.11/./libquadmath/.libs -L/test/gnu/gcc/objdir/hppa64-hp-hpux11.11/./libquadmath/.libs -L/test/gnu/gcc/objdir/hppa64-hp-hpux11.11/./libquadmath/.libs -lm -o ./bind_c_coms.exe ld: (Warning) Symbol "com" in "/var/tmp//cc14WyWs.o" does not satisfy the required 16-byte alignment in "/var/tmp//cc4g1Pgg.o". 1 warnings. output is: ld: (Warning) Symbol "com" in "/var/tmp//cc14WyWs.o" does not satisfy the required 16-byte alignment in "/var/tmp//cc4g1Pgg.o". 1 warnings. FAIL: gfortran.dg/bind_c_coms.f90 -O0 (test for excess errors) Excess errors: ld: (Warning) Symbol "com" in "/var/tmp//cc14WyWs.o" does not satisfy the required 16-byte alignment in "/var/tmp//cc4g1Pgg.o". 1 warnings. Fails at all optimizations. We now have in bind_c_coms_driver.s: .section .bss .align 8 .type com, @object .size com, 16 .align 8 com: .block 16 We used to have: .section .bss com .comm 16 The later provides 16-byte alignment. Looks to me like there are problems with both pa_asm_output_aligned_bss() and pa_asm_output_aligned_common(). It looks like allocations in the BSS need to be aligned to a power of 2 alignment greater than the size of the block. ^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug c/94253] FAIL: gfortran.dg/bind_c_coms.f90 -O0 (test for excess errors) 2020-03-21 19:24 [Bug target/94253] New: FAIL: gfortran.dg/bind_c_coms.f90 -O0 (test for excess errors) danglin at gcc dot gnu.org @ 2020-03-23 12:48 ` danglin at gcc dot gnu.org 2020-03-24 18:42 ` danglin at gcc dot gnu.org ` (4 subsequent siblings) 5 siblings, 0 replies; 7+ messages in thread From: danglin at gcc dot gnu.org @ 2020-03-23 12:48 UTC (permalink / raw) To: gcc-bugs https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94253 John David Anglin <danglin at gcc dot gnu.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|target |c --- Comment #1 from John David Anglin <danglin at gcc dot gnu.org> --- The alignments provided by ASM_OUTPUT_ALIGNED_COMMON and ASM_OUTPUT_ALIGNED_BSS are not identical on hppa. The c driver has switched from using ASM_OUTPUT_ALIGNED_COMMON to ASM_OUTPUT_ALIGNED_BSS when compiling bind_c_coms_driver.c. ^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug c/94253] FAIL: gfortran.dg/bind_c_coms.f90 -O0 (test for excess errors) 2020-03-21 19:24 [Bug target/94253] New: FAIL: gfortran.dg/bind_c_coms.f90 -O0 (test for excess errors) danglin at gcc dot gnu.org 2020-03-23 12:48 ` [Bug c/94253] " danglin at gcc dot gnu.org @ 2020-03-24 18:42 ` danglin at gcc dot gnu.org 2020-03-25 14:44 ` danglin at gcc dot gnu.org ` (3 subsequent siblings) 5 siblings, 0 replies; 7+ messages in thread From: danglin at gcc dot gnu.org @ 2020-03-24 18:42 UTC (permalink / raw) To: gcc-bugs https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94253 --- Comment #2 from John David Anglin <danglin at gcc dot gnu.org> --- r278376 was okay. r278658 was bad. ^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug c/94253] FAIL: gfortran.dg/bind_c_coms.f90 -O0 (test for excess errors) 2020-03-21 19:24 [Bug target/94253] New: FAIL: gfortran.dg/bind_c_coms.f90 -O0 (test for excess errors) danglin at gcc dot gnu.org 2020-03-23 12:48 ` [Bug c/94253] " danglin at gcc dot gnu.org 2020-03-24 18:42 ` danglin at gcc dot gnu.org @ 2020-03-25 14:44 ` danglin at gcc dot gnu.org 2024-01-08 20:28 ` [Bug testsuite/94253] " cvs-commit at gcc dot gnu.org ` (2 subsequent siblings) 5 siblings, 0 replies; 7+ messages in thread From: danglin at gcc dot gnu.org @ 2020-03-25 14:44 UTC (permalink / raw) To: gcc-bugs https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94253 --- Comment #3 from John David Anglin <danglin at gcc dot gnu.org> --- Okay, the problem is the test lacks a '-fcommon' option. The default was changed here: 2019-11-20 Wilco Dijkstra <wdijkstr@arm.com> PR85678 * common.opt (fcommon): Change init to 1. * doc/invoke.texi (-fcommon): Update documentation. This means almost all the places in the testsuite where we add '-fno-common' are unnecessary... ^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug testsuite/94253] FAIL: gfortran.dg/bind_c_coms.f90 -O0 (test for excess errors) 2020-03-21 19:24 [Bug target/94253] New: FAIL: gfortran.dg/bind_c_coms.f90 -O0 (test for excess errors) danglin at gcc dot gnu.org ` (2 preceding siblings ...) 2020-03-25 14:44 ` danglin at gcc dot gnu.org @ 2024-01-08 20:28 ` cvs-commit at gcc dot gnu.org 2024-01-08 20:34 ` danglin at gcc dot gnu.org 2024-01-20 17:14 ` pinskia at gcc dot gnu.org 5 siblings, 0 replies; 7+ messages in thread From: cvs-commit at gcc dot gnu.org @ 2024-01-08 20:28 UTC (permalink / raw) To: gcc-bugs https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94253 --- Comment #4 from GCC Commits <cvs-commit at gcc dot gnu.org> --- The master branch has been updated by John David Anglin <danglin@gcc.gnu.org>: https://gcc.gnu.org/g:932b8d077c23986da5279bf8b5d84875de1fb826 commit r14-7015-g932b8d077c23986da5279bf8b5d84875de1fb826 Author: John David Anglin <danglin@gcc.gnu.org> Date: Mon Jan 8 20:27:20 2024 +0000 hppa: Fix bind_c_coms.f90 and bind_c_vars.f90 tests on hppa Commit 6271dd98 changed the default from -fcommon to -fno-common. This silently changed the alignment of uninitialized BSS data on hppa where the alignment of common data must be greater or equal to the alignment of the largest type that will fit in the block. For example, the alignment of `double d[2];' changed from 16 to 8 on hppa64. The hppa architecture requires strict alignment and the linker warns about inconsistent alignment of variables. This change broke the gfortran.dg/bind_c_coms.f90 and gfortran.dg/bind_c_vars.f90 tests. These tests check whether bind_c works between fortran and C. Adding the -fcommon option fixes the tests. Probably, gcc and HP C are now by default inconsistent but that's water under the bridge. 2024-01-08 John David Anglin <danglin@gcc.gnu.org> gcc/testsuite/ChangeLog: PR testsuite/94253 * gfortran.dg/bind_c_coms.f90: Add -fcommon option on hppa*-*-*. * gfortran.dg/bind_c_vars.f90: Likewise. ^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug testsuite/94253] FAIL: gfortran.dg/bind_c_coms.f90 -O0 (test for excess errors) 2020-03-21 19:24 [Bug target/94253] New: FAIL: gfortran.dg/bind_c_coms.f90 -O0 (test for excess errors) danglin at gcc dot gnu.org ` (3 preceding siblings ...) 2024-01-08 20:28 ` [Bug testsuite/94253] " cvs-commit at gcc dot gnu.org @ 2024-01-08 20:34 ` danglin at gcc dot gnu.org 2024-01-20 17:14 ` pinskia at gcc dot gnu.org 5 siblings, 0 replies; 7+ messages in thread From: danglin at gcc dot gnu.org @ 2024-01-08 20:34 UTC (permalink / raw) To: gcc-bugs https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94253 John David Anglin <danglin at gcc dot gnu.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution|--- |FIXED --- Comment #5 from John David Anglin <danglin at gcc dot gnu.org> --- Fixed on trunk. ^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug testsuite/94253] FAIL: gfortran.dg/bind_c_coms.f90 -O0 (test for excess errors) 2020-03-21 19:24 [Bug target/94253] New: FAIL: gfortran.dg/bind_c_coms.f90 -O0 (test for excess errors) danglin at gcc dot gnu.org ` (4 preceding siblings ...) 2024-01-08 20:34 ` danglin at gcc dot gnu.org @ 2024-01-20 17:14 ` pinskia at gcc dot gnu.org 5 siblings, 0 replies; 7+ messages in thread From: pinskia at gcc dot gnu.org @ 2024-01-20 17:14 UTC (permalink / raw) To: gcc-bugs https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94253 Andrew Pinski <pinskia at gcc dot gnu.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|--- |14.0 ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2024-01-20 17:14 UTC | newest] Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2020-03-21 19:24 [Bug target/94253] New: FAIL: gfortran.dg/bind_c_coms.f90 -O0 (test for excess errors) danglin at gcc dot gnu.org 2020-03-23 12:48 ` [Bug c/94253] " danglin at gcc dot gnu.org 2020-03-24 18:42 ` danglin at gcc dot gnu.org 2020-03-25 14:44 ` danglin at gcc dot gnu.org 2024-01-08 20:28 ` [Bug testsuite/94253] " cvs-commit at gcc dot gnu.org 2024-01-08 20:34 ` danglin at gcc dot gnu.org 2024-01-20 17:14 ` pinskia at gcc dot gnu.org
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).