[Bug fortran/94327] New: Bind(c) argument attributes are incorrectly set

[Bug fortran/94327] New: Bind(c) argument attributes are incorrectly set

[jrfsousa at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94327

            Bug ID: 94327
           Summary: Bind(c) argument attributes are incorrectly set
           Product: gcc
           Version: 10.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: fortran
          Assignee: unassigned at gcc dot gnu.org
          Reporter: jrfsousa at gmail dot com
  Target Milestone: ---

Created attachment 48112
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=48112&action=edit
Fortran code demonstrating problems.

Hi all!

Argument attributes should match the dummy argument attribute not the effective
argument's.

Found in both:

GNU Fortran (GCC) 9.3.1 20200324

and

GNU Fortran (GCC) 10.0.1 20200324 (experimental)

Thank you very much.

Best regards,
José Rui

[Bug fortran/94327] Bind(c) argument attributes are incorrectly set

[jrfsousa at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94327

--- Comment #1 from José Rui Faustino de Sousa <jrfsousa at gmail dot com> ---
Created attachment 48113
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=48113&action=edit
C code demonstrating problems.

[Bug fortran/94327] Bind(c) argument attributes are incorrectly set

[dominiq at lps dot ens.fr]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94327

Dominique d'Humieres <dominiq at lps dot ens.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever confirmed|0                           |1
   Last reconfirmed|                            |2020-07-26

--- Comment #2 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
Confirmed. From GCC9 up to GCC11 the test stop with 21 and 32, cfi_p being 0.

GCC7 and 8 fail with

Assertion failed: (this->elem_len==4), function attribute, file pr94327.c, line
89.

[Bug fortran/94327] Bind(c) argument attributes are incorrectly set

[jrfsousa at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94327

--- Comment #3 from José Rui Faustino de Sousa <jrfsousa at gcc dot gnu.org> ---
Patch posted:

https://gcc.gnu.org/pipermail/fortran/2021-May/056054.html

[Bug fortran/94327] Bind(c) argument attributes are incorrectly set

[dominiq at lps dot ens.fr]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94327

Dominique d'Humieres <dominiq at lps dot ens.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

--- Comment #4 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
> Patch posted:
>
> https://gcc.gnu.org/pipermail/fortran/2021-May/056054.html

The patch fixes this PR, see also pr94331.

[Bug fortran/94327] Bind(c) argument attributes are incorrectly set

[jrfsousa at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94327

--- Comment #5 from José Rui Faustino de Sousa <jrfsousa at gcc dot gnu.org> ---
Updated patch:

https://gcc.gnu.org/pipermail/fortran/2021-June/056163.html

[Bug fortran/94327] Bind(c) argument attributes are incorrectly set

[jrfsousa at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94327

--- Comment #6 from José Rui Faustino de Sousa <jrfsousa at gcc dot gnu.org> ---
Created attachment 51016
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=51016&action=edit
Updated patch.

[Bug fortran/94327] Bind(c) argument attributes are incorrectly set

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94327

--- Comment #7 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tobias Burnus <burnus@gcc.gnu.org>:

https://gcc.gnu.org/g:0cbf03689e3e7d9d6002b8e5d159ef3716d0404c

commit r12-2511-g0cbf03689e3e7d9d6002b8e5d159ef3716d0404c
Author: Tobias Burnus <tobias@codesourcery.com>
Date:   Mon Jul 26 14:20:46 2021 +0200

    PR fortran/93308/93963/94327/94331/97046 problems raised by descriptor
handling

    Fortran: Fix attributes and bounds in ISO_Fortran_binding.

    2021-07-26  José Rui Faustino de Sousa  <jrfsousa@gmail.com>
                Tobias Burnus  <tobias@codesourcery.com>

            PR fortran/93308
            PR fortran/93963
            PR fortran/94327
            PR fortran/94331
            PR fortran/97046

    gcc/fortran/ChangeLog:

            * trans-decl.c (convert_CFI_desc): Only copy out the descriptor
            if necessary.
            * trans-expr.c (gfc_conv_gfc_desc_to_cfi_desc): Updated attribute
            handling which reflect a previous intermediate version of the
            standard. Only copy out the descriptor if necessary.

    libgfortran/ChangeLog:

            * runtime/ISO_Fortran_binding.c (cfi_desc_to_gfc_desc): Add code
            to verify the descriptor. Correct bounds calculation.
            (gfc_desc_to_cfi_desc): Add code to verify the descriptor.

    gcc/testsuite/ChangeLog:

            * gfortran.dg/ISO_Fortran_binding_1.f90: Add pointer attribute,
            this test is still erroneous but now it compiles.
            * gfortran.dg/bind_c_array_params_2.f90: Update regex to match
            code changes.
            * gfortran.dg/PR93308.f90: New test.
            * gfortran.dg/PR93963.f90: New test.
            * gfortran.dg/PR94327.c: New test.
            * gfortran.dg/PR94327.f90: New test.
            * gfortran.dg/PR94331.c: New test.
            * gfortran.dg/PR94331.f90: New test.
            * gfortran.dg/PR97046.f90: New test.

[Bug fortran/94327] Bind(c) argument attributes are incorrectly set

[burnus at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94327

Tobias Burnus <burnus at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |burnus at gcc dot gnu.org
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #8 from Tobias Burnus <burnus at gcc dot gnu.org> ---
Close as FIXED.

Except for the version == 0 which should be version == 1, as #define
CFI_VERSION 1,
the testcase of comment 0 (Fortran part) and comment 1 (C part) do pass now.

Thanks for bug reports José and your patch(es)!