[Bug c/94579] New: OVS compiled with gcc10 with -fanalyzer

[Bug c/94579] New: OVS compiled with gcc10 with -fanalyzer

[u9012063 at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94579

            Bug ID: 94579
           Summary: OVS compiled with gcc10 with -fanalyzer
           Product: gcc
           Version: 10.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c
          Assignee: unassigned at gcc dot gnu.org
          Reporter: u9012063 at gmail dot com
  Target Milestone: ---

Hi,
I'd like to create an account to submit a bug for gcc10
when compiling openvswitch
$ uname -a
Linux osboxes 5.5.0-rc1+ #112 SMP Fri Feb 21 10:28:49 PST 2020 x86_64 x86_64
x86_64 GNU/L
$ gcc -v
Using built-in specs.
COLLECT_GCC=gcc
COLLECT_LTO_WRAPPER=/usr/local/libexec/gcc/x86_64-pc-linux-gnu/10.0.1/lto-wrapper
Target: x86_64-pc-linux-gnu
Configured with: ./configure
Thread model: posix
Supported LTO compression algorithms: zlib
gcc version 10.0.1 20200405 (experimental) (GCC) 

$ git clone https://github.com/openvswitch/ovs.git
$ cd ovs
$ ./boot.sh; ./configure; make CFLAGS+=-fanalyzer

In file included from lib/flow.h:31,
                 from lib/flow.c:18:
lib/packets.h: In function ‘in6_addr_mapped_ipv4’:
lib/packets.h:1187:12: internal compiler error: in saved_diagnostic,
at analyzer/diagnostic-manager.cc:84
 1187 |     return ip6;
      |            ^~~
0x7888f9 ana::saved_diagnostic::saved_diagnostic(ana::state_machine
const*, ana::exploded_node const*, ana::supernode const*, gimple
const*, ana::stmt_finder*, tree_node*, unsigned int,
ana::pending_diagnostic*)
../.././gcc/analyzer/diagnostic-manager.cc:84
0x1757703 ana::diagnostic_manager::add_diagnostic(ana::state_machine
const*, ana::exploded_node const*, ana::supernode const*, gimple
const*, ana::stmt_finder*, tree_node*, unsigned int,
ana::pending_diagnostic*)
../.././gcc/analyzer/diagnostic-manager.cc:175
0x17578f9 ana::diagnostic_manager::add_diagnostic(ana::exploded_node
const*, ana::supernode const*, gimple const*, ana::stmt_finder*,
ana::pending_diagnostic*)
../.././gcc/analyzer/diagnostic-manager.cc:192
0x10aead4 ana::impl_region_model_context::warn(ana::pending_diagnostic*)
../.././gcc/analyzer/engine.cc:114
0x10d3664 ana::region_model::deref_rvalue(ana::svalue_id,
ana::region_model_context*)
../.././gcc/analyzer/region-model.cc:5458
0x10d59de ana::region_model::get_or_create_mem_ref(tree_node*,
ana::svalue_id, ana::svalue_id, ana::region_model_context*)
../.././gcc/analyzer/region-model.cc:6971
0x10d62b3 ana::region_model::get_lvalue(ana::path_var,
ana::region_model_context*)
../.././gcc/analyzer/region-model.cc:5068
0x10de90d ana::region_model::update_for_return_superedge(ana::return_superedge
const&, ana::region_model_context*)
../.././gcc/analyzer/region-model.cc:6171
0x10dea17 ana::region_model::maybe_update_for_edge(ana::superedge
const&, gimple const*, ana::region_model_context*)
../.././gcc/analyzer/region-model.cc:6092
0x10c37d2 ana::program_state::on_edge(ana::exploded_graph&,
ana::exploded_node const&, ana::superedge const*, ana::state_change*)
../.././gcc/analyzer/program-state.cc:829
0x10af589 ana::exploded_node::on_edge(ana::exploded_graph&,
ana::superedge const*, ana::program_point*, ana::program_state*,
ana::state_change*) const
../.././gcc/analyzer/engine.cc:1153
0x10b6b5b ana::exploded_graph::process_node(ana::exploded_node*)
../.././gcc/analyzer/engine.cc:2597
0x10b716a ana::exploded_graph::process_worklist()
../.././gcc/analyzer/engine.cc:2348
0x10b787b ana::impl_run_checkers(ana::logger*)
../.././gcc/analyzer/engine.cc:4029
0x10b840c ana::run_checkers()
../.././gcc/analyzer/engine.cc:4097
0x10ad598 execute
../.././gcc/analyzer/analyzer-pass.cc:84
Please submit a full bug report,
with preprocessed source if appropriate.
Please include the complete backtrace with any bug report.
See <https://gcc.gnu.org/bugs/> for instructions.

[Bug c/94579] OVS compiled with gcc10 with -fanalyzer

[u9012063 at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94579

--- Comment #1 from William Tu <u9012063 at gmail dot com> ---
Created attachment 48260
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=48260&action=edit
flow.i file in zip format

[Bug c/94579] OVS compiled with gcc10 with -fanalyzer

[u9012063 at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94579

--- Comment #2 from William Tu <u9012063 at gmail dot com> ---
libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I ./include -I ./include -I ./lib
-I ./lib -Wstrict-prototypes -Wall -Wextra -Wno-sign-compare -Wpointer-arith
-Wformat -Wformat-security -Wswitch-enum -Wunused-parameter -Wbad-function-cast
-Wcast-align -Wstrict-prototypes -Wold-style-definition -Wmissing-prototypes
-Wmissing-field-initializers -fno-strict-aliasing -Wswitch-bool
-Wlogical-not-parentheses -Wsizeof-array-argument -Wbool-compare
-Wshift-negative-value -Wduplicated-cond -Wshadow -Wmultistatement-macros
-Wcast-align=strict -fanalyzer -MT lib/flow.lo -MD -MP -MF lib/.deps/flow.Tpo
-c lib/flow.c -o lib/flow.o
during IPA pass: analyzer
In file included from lib/flow.h:31,
                 from lib/flow.c:18:
lib/packets.h: In function ‘in6_addr_mapped_ipv4’:

[Bug c/94579] OVS compiled with gcc10 with -fanalyzer since r10-7502-ga96f1c38a787fbc8

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94579

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
                 CC|                            |marxin at gcc dot gnu.org
      Known to fail|                            |10.0
   Target Milestone|---                         |10.0
           Assignee|unassigned at gcc dot gnu.org      |dmalcolm at gcc dot gnu.org
            Summary|OVS compiled with gcc10     |OVS compiled with gcc10
                   |with -fanalyzer             |with -fanalyzer since
                   |                            |r10-7502-ga96f1c38a787fbc8
             Status|UNCONFIRMED                 |ASSIGNED
   Last reconfirmed|                            |2020-04-14

--- Comment #3 from Martin Liška <marxin at gcc dot gnu.org> ---
Thank you for the report. Confirmed, started with r10-7502-ga96f1c38a787fbc8

$ cat pr94579.i
struct a *c;
struct a {
  int b;
} d() {
}

void e()

{
  *c = d();
}

[Bug c/94579] OVS compiled with gcc10 with -fanalyzer since r10-7502-ga96f1c38a787fbc8

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94579

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|10.0                        |---
           Keywords|                            |ice-on-valid-code

[Bug c/94579] OVS compiled with gcc10 with -fanalyzer since r10-7502-ga96f1c38a787fbc8

[asolokha at gmx dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94579

Arseny Solokha <asolokha at gmx dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |asolokha at gmx dot com

--- Comment #4 from Arseny Solokha <asolokha at gmx dot com> ---
It is probably a duplicate of PR94503.

[Bug analyzer/94579] OVS compiled with gcc10 with -fanalyzer since r10-7502-ga96f1c38a787fbc8

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94579

--- Comment #5 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by David Malcolm <dmalcolm@gcc.gnu.org>:

https://gcc.gnu.org/g:955ea7b58e4f1e3cc5083e88575161168c147254

commit r12-5642-g955ea7b58e4f1e3cc5083e88575161168c147254
Author: David Malcolm <dmalcolm@redhat.com>
Date:   Tue Nov 30 15:31:59 2021 -0500

    analyzer: add regression test [PR94579]

    gcc/testsuite/ChangeLog:
            PR analyzer/94579
            * gcc.dg/analyzer/pr94579.c: New test.

    Signed-off-by: David Malcolm <dmalcolm@redhat.com>

[Bug analyzer/94579] OVS compiled with gcc10 with -fanalyzer since r10-7502-ga96f1c38a787fbc8

[dmalcolm at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94579

David Malcolm <dmalcolm at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #6 from David Malcolm <dmalcolm at gcc dot gnu.org> ---
I've heavily rewritten the code since gcc 10, and can't reproduce the issue.

I've added the reproducer from comment #3 to the regression tests (as per
comment #5).  Marking as resolved.